0.6.6: follow-ups from the Model K softmax self-check review (#254)

Abierto
#261 1 comentario 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
5/5
Tiempo estimado
Más de una semana
Aptitud para principiantes
35/100
Tipo de issue
Error
Claridad
Bastante claro
Estado de actividad
Activo
Stack tecnológico
cpp

Línea de trabajo

Start by reading the review follow-ups in this issue and the implementation and tests for the create-time self-check introduced in #254. Trace preparation, embedded manifest and shader loading, digest generation, and the game-path executor's runtime creation. Done means the five listed gaps are addressed, with negative controls and boundary shapes tested and end-to-end creation measured on supported devices.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

Follow-ups from the review rounds of #254 (Model K softmax weight rounding in one mixed-precision FMA, with a create-time self-check). None of them changes the output of a frame that passes the self-check. They are tracked here for 0.6.6.

1. Shape coverage beyond the sampled sizes

The self-check runs each selectable softmax stage at the window offsets the frames use, but only at sampled output sizes (for example, the m stage only at one large base). A defect that depends on the map size, such as a small m map or partial windows at an edge, could pass the check. Add shape-dependent negative controls, and cover boundary and partial-window shapes, or verify the compiled data flow independently of the sampled sizes.

2. Preparation that silently skips a port

The create-time preparation step returns success for a manifest entry whose variant does not match or whose root signature is unsupported, while the launch path later refuses the same entry. Such an entry, even with a corrupt shader, then passes create and fails on the first frame. Make preparation fail on these cases, and test them.

3. Stale embedded manifest and shader pairs

The manifest and each shader fall back to the embedded copies independently. A runtime built from a reused output folder could embed an old, matching pair, which then passes the integrity check when the loose files are absent. The fixed-weight stages are not in the output-hash self-check. Bind the embedded artifacts to the intended build's sources (the new per-entry source digests are a start), and refuse stale ones before embedding.

4. Self-check digest inputs and reference provenance

The digest that binds the reference header to its sources does not yet include the stage table and layout helpers, the FP16 conversion used to make the synthetic inputs, or the separately compiled probe. The header generator also stamps the current digest onto a reference build without checking that build's own provenance. Include those inputs, and verify the reference build before stamping.

5. Create time

Native create with the self-check takes about 1.7 s at 1440p Quality, and the game-path executor creates the runtime twice. Reduce the duplicate check (for example, reuse a verified result safely within one process), and measure end-to-end creation on supported devices.

Lenguaje dominante
C++
Estrellas
12
Forks
2
Merge medio
3 h 10 min
PR fusionados (30 d)
171

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de phantoslayer21/wronggpu

Todos los issues de phantoslayer21/wronggpu

Issues similares

Más issues de C++

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.