0.6.6: follow-ups from the Model K softmax self-check review (#254)

未关闭
#261 1 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
5/5
预计耗时
一周以上
新手友好度
35/100
Issue 类型
缺陷
描述清晰度
基本清楚
活跃度
活跃
技术栈
cpp

调研方向

Start by reading the review follow-ups in this issue and the implementation and tests for the create-time self-check introduced in #254. Trace preparation, embedded manifest and shader loading, digest generation, and the game-path executor's runtime creation. Done means the five listed gaps are addressed, with negative controls and boundary shapes tested and end-to-end creation measured on supported devices.

由索引模型根据 Issue 内容生成。

描述

Follow-ups from the review rounds of #254 (Model K softmax weight rounding in one mixed-precision FMA, with a create-time self-check). None of them changes the output of a frame that passes the self-check. They are tracked here for 0.6.6.

1. Shape coverage beyond the sampled sizes

The self-check runs each selectable softmax stage at the window offsets the frames use, but only at sampled output sizes (for example, the m stage only at one large base). A defect that depends on the map size, such as a small m map or partial windows at an edge, could pass the check. Add shape-dependent negative controls, and cover boundary and partial-window shapes, or verify the compiled data flow independently of the sampled sizes.

2. Preparation that silently skips a port

The create-time preparation step returns success for a manifest entry whose variant does not match or whose root signature is unsupported, while the launch path later refuses the same entry. Such an entry, even with a corrupt shader, then passes create and fails on the first frame. Make preparation fail on these cases, and test them.

3. Stale embedded manifest and shader pairs

The manifest and each shader fall back to the embedded copies independently. A runtime built from a reused output folder could embed an old, matching pair, which then passes the integrity check when the loose files are absent. The fixed-weight stages are not in the output-hash self-check. Bind the embedded artifacts to the intended build's sources (the new per-entry source digests are a start), and refuse stale ones before embedding.

4. Self-check digest inputs and reference provenance

The digest that binds the reference header to its sources does not yet include the stage table and layout helpers, the FP16 conversion used to make the synthetic inputs, or the separately compiled probe. The header generator also stamps the current digest onto a reference build without checking that build's own provenance. Include those inputs, and verify the reference build before stamping.

5. Create time

Native create with the self-check takes about 1.7 s at 1440p Quality, and the game-path executor creates the runtime twice. Reduce the duplicate check (for example, reuse a verified result safely within one process), and measure end-to-end creation on supported devices.

主要语言
C++
星标
12
派生
2
平均合并
3 小时 10 分钟
30 天内合并 PR
171

环境准备

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

phantoslayer21/wronggpu 的其他 Issue

查看 phantoslayer21/wronggpu 的全部 Issue

相似的 Issue

更多 C++ Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。