0.6.6: follow-ups from the Model K softmax self-check review (#254)
メンテナーはふだん 1 日以内に返信
まだ誰も着手していません。
評価
- 難易度
- 5/5
- 見積もり時間
- 1週間以上
- 初心者へのやさしさ
- 35/100
- issue の種類
- バグ
- 明瞭さ
- おおむね明確
- 活発さ
- 活発
- 技術スタック
- cpp
- 領域
- backend, performance
調査の方向性
Start by reading the review follow-ups in this issue and the implementation and tests for the create-time self-check introduced in #254. Trace preparation, embedded manifest and shader loading, digest generation, and the game-path executor's runtime creation. Done means the five listed gaps are addressed, with negative controls and boundary shapes tested and end-to-end creation measured on supported devices.
索引モデルが issue の本文から書いたものです。
説明
Follow-ups from the review rounds of #254 (Model K softmax weight rounding in one mixed-precision FMA, with a create-time self-check). None of them changes the output of a frame that passes the self-check. They are tracked here for 0.6.6.
1. Shape coverage beyond the sampled sizes
The self-check runs each selectable softmax stage at the window offsets the frames use, but only at sampled output sizes (for example, the m stage only at one large base). A defect that depends on the map size, such as a small m map or partial windows at an edge, could pass the check. Add shape-dependent negative controls, and cover boundary and partial-window shapes, or verify the compiled data flow independently of the sampled sizes.
2. Preparation that silently skips a port
The create-time preparation step returns success for a manifest entry whose variant does not match or whose root signature is unsupported, while the launch path later refuses the same entry. Such an entry, even with a corrupt shader, then passes create and fails on the first frame. Make preparation fail on these cases, and test them.
3. Stale embedded manifest and shader pairs
The manifest and each shader fall back to the embedded copies independently. A runtime built from a reused output folder could embed an old, matching pair, which then passes the integrity check when the loose files are absent. The fixed-weight stages are not in the output-hash self-check. Bind the embedded artifacts to the intended build's sources (the new per-entry source digests are a start), and refuse stale ones before embedding.
4. Self-check digest inputs and reference provenance
The digest that binds the reference header to its sources does not yet include the stage table and layout helpers, the FP16 conversion used to make the synthetic inputs, or the separately compiled probe. The header generator also stamps the current digest onto a reference build without checking that build's own provenance. Include those inputs, and verify the reference build before stamping.
5. Create time
Native create with the self-check takes about 1.7 s at 1440p Quality, and the game-path executor creates the runtime twice. Reduce the duplicate check (for example, reuse a verified result safely within one process), and measure end-to-end creation on supported devices.
- 主要言語
- C++
- スター
- 12
- フォーク
- 2
- 平均マージ
- 3時間 10分
- マージ済み PR(30日)
- 171
環境構築
- Dockerfile・Docker Compose ファイルなし
- プルリクエストのテンプレートあり
- コントリビューションガイドを読む
はじめの一歩
- issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
- 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
- リポジトリをフォークし、ブランチを切って変更します。
- issue 番号を参照したプルリクエストを送ります。
phantoslayer21/wronggpu のほかの issue
-
難易度 2/5 1〜3時間 初心者へのやさしさ 88/100
phantoslayer21/wronggpu#275 ·
メンテナーはふだん 1 日以内に返信
-
難易度 2/5 1〜3時間 初心者へのやさしさ 82/100
phantoslayer21/wronggpu#274 ·
メンテナーはふだん 1 日以内に返信
-
bug
難易度 2/5 1〜3時間 初心者へのやさしさ 88/100
phantoslayer21/wronggpu#241 ·
メンテナーはふだん 1 日以内に返信
-
bug build
難易度 2/5 1〜3時間 初心者へのやさしさ 74/100
phantoslayer21/wronggpu#234 ·
メンテナーはふだん 1 日以内に返信
-
bug build
難易度 2/5 1〜3時間 初心者へのやさしさ 80/100
phantoslayer21/wronggpu#233 ·
メンテナーはふだん 1 日以内に返信
phantoslayer21/wronggpu の issue をすべて見る
似ている issue
-
ai_p2
難易度 2/5 1〜3時間 初心者へのやさしさ 80/100
ClickHouse/ClickHouse#132519 ·
メンテナーはふだん 1 日以内に返信
-
[Bug]: VST3 getMidiControllerAssignment reads past midiControllerToParameter for program changeオープン
難易度 2/5 1〜3時間 初心者へのやさしさ 76/100
juce-framework/JUCE#1810 ·
-
難易度 1/5 1時間未満 初心者へのやさしさ 82/100
petercorke/robotics-toolbox-python#952 ·
メンテナーはふだん 1 日以内に返信
-
NatronRenderer: a Python error in the script (-t / project script) doesn't change the exit statusオープンfunc:engine type:bug
難易度 2/5 1〜3時間 初心者へのやさしさ 72/100
NatronGitHub/Natron#1276 ·
メンテナーはふだん 1 日以内に返信
-
難易度 1/5 1〜3時間 初心者へのやさしさ 77/100
メンテナーはふだん 1 日以内に返信