Library: bound memory while creating and downloading archives

Offen
  • Stimmt etwas nicht?
#481 3 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen

Maintainer antworten meist innerhalb von 1 Tag

Dieses Issue hat noch niemand übernommen.

Bewertung

Schwierigkeit
5/5
Geschätzter Aufwand
Über eine Woche
Anfängerfreundlichkeit
32/100
Issue-Typ
Bug
Klarheit
Klar beschrieben
Aktivitätsstatus
Aktiv
Tech-Stack
rust
Bereich
backend, security

Rechercherichtung

Start with elastos/crates/elastos-server/src/library.rs at the archive creation points cited in the issue, then trace the response handling in api/gateway_provider_proxy.rs. Reproduce with incompressible input larger than the proposed RAM budget and measure peak RSS and responsiveness on Mac and Linux. Done means archive creation and export meet an enforced budget or stream from bounded staging, with Download and Compress tests covering folders and selections, safe cleanup, archive integrity, full protected input authentication, and a recorded release disposition.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Beschreibung

User impact

Library builds a folder or selection archive in memory before sending it. A set of individually valid media files can therefore consume memory proportional to the total archive, with further buffers when Compress saves a protected result. The user needs a bounded export that keeps Home responsive and explains a capacity refusal.

Found during the systematic audit in #93. Proposed priority: P2, with an explicit release decision after a bounded-memory reproduction. This is source evidence; peak memory and installed failure threshold remain unmeasured.

Source evidence

Applies to fetched develop 3beb816438fd567145a8d725e22465bd83277cf0 and local candidate 460b1888d344f52cebd1c25866be88ff4085f035.

  • Develop tar.gz creation writes to a growing Vec<u8>; ZIP does the same at line 3920. Candidate equivalents are library.rs:3970 and :3991.
  • Candidate library.rs:4001 returns the entire ZIP buffer. Selection archives use the same approach.
  • api/gateway_provider_proxy.rs:1156-1166 chunks an already complete buffer into the HTTP response. This bounds network chunk size, not archive construction memory.
  • The per-file upload limit does not bound a folder's aggregate size. The train's archive extraction limits protect a different operation.

Acceptance

  • Choose and enforce an archive creation memory/size budget, or stage to an owned bounded file and stream it.
  • Use incompressible input larger than the accepted RAM budget; record peak RSS and Home responsiveness on Mac and Linux.
  • Test Download and Compress for folders and selections.
  • Cancellation and errors clean up only owned partial output; the source files remain intact.
  • Archive integrity and full authentication of protected input are verified.
  • Record the exact candidate and the release disposition.

Related existing work: #445 lists/decrypts files, #450 opens individual protected files, #449 bounds extraction, #444 protects startup/update/recovery from large objects. This issue owns archive creation and export, so it does not duplicate those tasks.

Vorherrschende Sprache
Rust
Sterne
6
Forks
2
Ø Merge
1 T. 3 Std.
Gemergte PRs (30 T.)
42

Entwicklungsumgebung

Dieses Projekt bietet weder Dev-Container noch Dockerfile noch Beitragsleitfaden – die Einrichtung liegt bei Ihnen. Beginnen Sie mit der README; die allgemeinen Schritte stehen in unserem Leitfaden für den ersten Beitrag.

Erste Schritte

  1. Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
  2. Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
  3. Forken Sie das Repository und arbeiten Sie in einem Branch.
  4. Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.

Mehr aus elastos/elastos-runtime

Alle Issues in elastos/elastos-runtime

Ähnliche Issues

Weitere Issues zu Rust

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.