Library: bound memory while creating and downloading archives

Ouverte
  • Quelque chose ne va pas ?
#481 3 commentaires 0 réactions 0 personnes assignées Voir sur GitHub

Les mainteneurs répondent en général sous 1 jour

Personne n'a encore pris cette issue.

Évaluation

Difficulté
5/5
Temps estimé
Plus d'une semaine
Accessibilité débutants
32/100
Type d'issue
Bug
Clarté
Clairement spécifiée
Activité
Active
Stack technique
rust
Domaine
backend, security

Piste de recherche

Start with elastos/crates/elastos-server/src/library.rs at the archive creation points cited in the issue, then trace the response handling in api/gateway_provider_proxy.rs. Reproduce with incompressible input larger than the proposed RAM budget and measure peak RSS and responsiveness on Mac and Linux. Done means archive creation and export meet an enforced budget or stream from bounded staging, with Download and Compress tests covering folders and selections, safe cleanup, archive integrity, full protected input authentication, and a recorded release disposition.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Description

User impact

Library builds a folder or selection archive in memory before sending it. A set of individually valid media files can therefore consume memory proportional to the total archive, with further buffers when Compress saves a protected result. The user needs a bounded export that keeps Home responsive and explains a capacity refusal.

Found during the systematic audit in #93. Proposed priority: P2, with an explicit release decision after a bounded-memory reproduction. This is source evidence; peak memory and installed failure threshold remain unmeasured.

Source evidence

Applies to fetched develop 3beb816438fd567145a8d725e22465bd83277cf0 and local candidate 460b1888d344f52cebd1c25866be88ff4085f035.

  • Develop tar.gz creation writes to a growing Vec<u8>; ZIP does the same at line 3920. Candidate equivalents are library.rs:3970 and :3991.
  • Candidate library.rs:4001 returns the entire ZIP buffer. Selection archives use the same approach.
  • api/gateway_provider_proxy.rs:1156-1166 chunks an already complete buffer into the HTTP response. This bounds network chunk size, not archive construction memory.
  • The per-file upload limit does not bound a folder's aggregate size. The train's archive extraction limits protect a different operation.

Acceptance

  • Choose and enforce an archive creation memory/size budget, or stage to an owned bounded file and stream it.
  • Use incompressible input larger than the accepted RAM budget; record peak RSS and Home responsiveness on Mac and Linux.
  • Test Download and Compress for folders and selections.
  • Cancellation and errors clean up only owned partial output; the source files remain intact.
  • Archive integrity and full authentication of protected input are verified.
  • Record the exact candidate and the release disposition.

Related existing work: #445 lists/decrypts files, #450 opens individual protected files, #449 bounds extraction, #444 protects startup/update/recovery from large objects. This issue owns archive creation and export, so it does not duplicate those tasks.

Langage dominant
Rust
Étoiles
6
Forks
2
Merge moyen
1 j 3 h
PR mergées (30 j)
42

Préparer son environnement

Ce projet ne fournit ni conteneur de développement, ni Dockerfile, ni guide de contribution : l'installation est à votre charge. Commencez par son README, et consultez notre guide de la première contribution pour les étapes générales.

Par où commencer

  1. Lisez l'issue en entier, puis le guide de contribution du projet.
  2. Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
  3. Forkez le dépôt et travaillez sur une branche.
  4. Ouvrez une pull request qui référence le numéro de l'issue.

Autres issues de elastos/elastos-runtime

Toutes les issues de elastos/elastos-runtime

Issues similaires

Plus d'issues Rust

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.