Library: bound memory while creating and downloading archives

未关闭
#481 3 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
5/5
预计耗时
一周以上
新手友好度
32/100
Issue 类型
缺陷
描述清晰度
描述清楚
活跃度
活跃
技术栈
rust
领域
backend, security

调研方向

Start with elastos/crates/elastos-server/src/library.rs at the archive creation points cited in the issue, then trace the response handling in api/gateway_provider_proxy.rs. Reproduce with incompressible input larger than the proposed RAM budget and measure peak RSS and responsiveness on Mac and Linux. Done means archive creation and export meet an enforced budget or stream from bounded staging, with Download and Compress tests covering folders and selections, safe cleanup, archive integrity, full protected input authentication, and a recorded release disposition.

由索引模型根据 Issue 内容生成。

描述

User impact

Library builds a folder or selection archive in memory before sending it. A set of individually valid media files can therefore consume memory proportional to the total archive, with further buffers when Compress saves a protected result. The user needs a bounded export that keeps Home responsive and explains a capacity refusal.

Found during the systematic audit in #93. Proposed priority: P2, with an explicit release decision after a bounded-memory reproduction. This is source evidence; peak memory and installed failure threshold remain unmeasured.

Source evidence

Applies to fetched develop 3beb816438fd567145a8d725e22465bd83277cf0 and local candidate 460b1888d344f52cebd1c25866be88ff4085f035.

  • Develop tar.gz creation writes to a growing Vec<u8>; ZIP does the same at line 3920. Candidate equivalents are library.rs:3970 and :3991.
  • Candidate library.rs:4001 returns the entire ZIP buffer. Selection archives use the same approach.
  • api/gateway_provider_proxy.rs:1156-1166 chunks an already complete buffer into the HTTP response. This bounds network chunk size, not archive construction memory.
  • The per-file upload limit does not bound a folder's aggregate size. The train's archive extraction limits protect a different operation.

Acceptance

  • Choose and enforce an archive creation memory/size budget, or stage to an owned bounded file and stream it.
  • Use incompressible input larger than the accepted RAM budget; record peak RSS and Home responsiveness on Mac and Linux.
  • Test Download and Compress for folders and selections.
  • Cancellation and errors clean up only owned partial output; the source files remain intact.
  • Archive integrity and full authentication of protected input are verified.
  • Record the exact candidate and the release disposition.

Related existing work: #445 lists/decrypts files, #450 opens individual protected files, #449 bounds extraction, #444 protects startup/update/recovery from large objects. This issue owns archive creation and export, so it does not duplicate those tasks.

主要语言
Rust
星标
6
派生
2
平均合并
1 天 3 小时
30 天内合并 PR
42

环境准备

这个项目没有提供开发容器、Dockerfile 或贡献指南,环境需要你自己搭建:先看它的 README,通用步骤见我们的新手贡献指南。

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

elastos/elastos-runtime 的其他 Issue

查看 elastos/elastos-runtime 的全部 Issue

相似的 Issue

更多 Rust Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。