Library: bound memory while creating and downloading archives

Abierto
  • ¿Algo no está bien?
#481 3 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
5/5
Tiempo estimado
Más de una semana
Aptitud para principiantes
32/100
Tipo de issue
Error
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
rust
Área
backend, security

Línea de trabajo

Start with elastos/crates/elastos-server/src/library.rs at the archive creation points cited in the issue, then trace the response handling in api/gateway_provider_proxy.rs. Reproduce with incompressible input larger than the proposed RAM budget and measure peak RSS and responsiveness on Mac and Linux. Done means archive creation and export meet an enforced budget or stream from bounded staging, with Download and Compress tests covering folders and selections, safe cleanup, archive integrity, full protected input authentication, and a recorded release disposition.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

User impact

Library builds a folder or selection archive in memory before sending it. A set of individually valid media files can therefore consume memory proportional to the total archive, with further buffers when Compress saves a protected result. The user needs a bounded export that keeps Home responsive and explains a capacity refusal.

Found during the systematic audit in #93. Proposed priority: P2, with an explicit release decision after a bounded-memory reproduction. This is source evidence; peak memory and installed failure threshold remain unmeasured.

Source evidence

Applies to fetched develop 3beb816438fd567145a8d725e22465bd83277cf0 and local candidate 460b1888d344f52cebd1c25866be88ff4085f035.

  • Develop tar.gz creation writes to a growing Vec<u8>; ZIP does the same at line 3920. Candidate equivalents are library.rs:3970 and :3991.
  • Candidate library.rs:4001 returns the entire ZIP buffer. Selection archives use the same approach.
  • api/gateway_provider_proxy.rs:1156-1166 chunks an already complete buffer into the HTTP response. This bounds network chunk size, not archive construction memory.
  • The per-file upload limit does not bound a folder's aggregate size. The train's archive extraction limits protect a different operation.

Acceptance

  • Choose and enforce an archive creation memory/size budget, or stage to an owned bounded file and stream it.
  • Use incompressible input larger than the accepted RAM budget; record peak RSS and Home responsiveness on Mac and Linux.
  • Test Download and Compress for folders and selections.
  • Cancellation and errors clean up only owned partial output; the source files remain intact.
  • Archive integrity and full authentication of protected input are verified.
  • Record the exact candidate and the release disposition.

Related existing work: #445 lists/decrypts files, #450 opens individual protected files, #449 bounds extraction, #444 protects startup/update/recovery from large objects. This issue owns archive creation and export, so it does not duplicate those tasks.

Lenguaje dominante
Rust
Estrellas
6
Forks
2
Merge medio
1 d 3 h
PR fusionados (30 d)
42

Preparar el entorno

Este proyecto no incluye contenedor de desarrollo, Dockerfile ni guía de contribución, así que la configuración corre por tu cuenta: empieza por su README y consulta nuestra guía para la primera contribución para los pasos generales.

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de elastos/elastos-runtime

Todos los issues de elastos/elastos-runtime

Issues similares

Más issues de Rust

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.