[Flaky test] TestBackgroundWorktreeIsolationAndMerge
Maintainer antworten meist innerhalb von 1 Tag
Bewertung
- Schwierigkeit
- 3/5
- Geschätzter Aufwand
- Ein halber Tag
- Anfängerfreundlichkeit
- 20/100
Rechercherichtung
Start with the concurrent launch in pkg/runtime/background_worktree_test.go (lines 134-139) and the completed assertion at line 156, then find where the background agent path runs git worktree add. Run the repro loop from the issue to see the commondir failure. Done means the flaky subtest passes reliably, either by serializing per-repo creation or retrying transient failures. PR #4923 is already open against this, so check it before starting.
Vom Indexierungsmodell aus dem Issue-Text verfasst.
Beschreibung
Description
Failed once on PR #4907's test-linux (run 43133474124, first attempt, Nov 12). The linked=false subtest launches two background agents that create their git worktrees concurrently in the same repo (pkg/runtime/background_worktree_test.go:134-139); task first failed with
creating background worktree: creating git worktree: exit status 128:
Preparing worktree (new branch 'worktree-agent-bb8bc299-...')
fatal: failed to read .git/worktrees/agent-788eb22e-.../commondir: Success
while task second completed normally — its worktree is exactly the admin entry first's git worktree add stumbled on. A short read of a half-written commondir (errno 0 ⇒ "Success") means one git worktree add read another's in-flight administrative entry and exited 128, so the task was marked failed and the test's completed assertion (background_worktree_test.go:156) failed.
I reproduced the git-level race locally (linux/amd64, git 2.51.0), independently of the test harness: 16 concurrent git worktree add in a fresh repo, 400 rounds — 51 rounds hit exactly this error (fatal: failed to read .git/worktrees/<name>/commondir: Success, plus an ENOENT variant), with several concurrent adds stumbling over the same half-written entry within one round. The test itself only races 2 concurrent adds, which matches its low flake rate; CI runner I/O widens the window.
Expected Behavior
Concurrent background worktree creation in one repo is safe; a transient git failure of this kind doesn't fail a task the test expects to complete.
Actual Behavior
Intermittently, one concurrent creation fails on a half-written admin entry and the task is recorded as failed.
Steps to Reproduce
- Run the repro script (pasted under Error output) on Linux
- It races 16 concurrent
git worktree addin a fresh repo, 400 rounds - Measured here: 51/400 rounds hit the error below
Docker Agent version
No response
OS & terminal
No response
Model used
No response
Error output
hits=0
for r in $(seq 1 400); do
base=$(mktemp -d)
git init -q $base/repo
git -C $base/repo commit -q --allow-empty -m i
for i in $(seq 1 16); do
( git -C $base/repo worktree add $base/w$i HEAD >/dev/null 2>$base/err$i ) &
done
wait
grep -q commondir $base/err* 2>/dev/null && hits=$((hits+1))
rm -rf $base
done
echo "rounds with a commondir failure: $hits/400" # measured: 51/400
Screenshots
No response
Additional context
report-main-failures only auto-files flakes seen on main, so this PR-run failure isn't in the tracker yet. Suggested direction:
serialize per-repo worktree creation in the background-agent path, or retry a creation that fails with a transient commondir read error.
Happy to work on the fix.
- Vorherrschende Sprache
- Go
- Sterne
- 4.7k
- Forks
- 565
- Ø Merge
- 18 Std. 52 Min.
- Gemergte PRs (30 T.)
- 221
Entwicklungsumgebung
Startet den Dev-Container des Projekts im Browser, mit Ihrem eigenen GitHub-Konto.
- Enthält ein Dockerfile oder eine Docker-Compose-Datei
- Keine Pull-Request-Vorlage
- Kein Beitragsleitfaden
Erste Schritte
- Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
- Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
- Forken Sie das Repository und arbeiten Sie in einem Branch.
- Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.
Mehr aus docker/docker-agent
-
edit_file diff rendering panics on invalid UTF-8 textEvtl. vergeben @TDnorthgarden hat das heute übernommen. Offenarea/tui
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 85/100
docker/docker-agent#4955 ·
Maintainer antworten meist innerhalb von 1 Tag
-
A setting to turn off the models.dev catalog download (offline and strict-network use)Evtl. vergeben @3431481073 hat das vor 19 Tagen übernommen. Offenarea/config area/models
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 72/100
docker/docker-agent#4714 ·
Maintainer antworten meist innerhalb von 1 Tag
-
Error when trying to run sandbox example?Evtl. wieder frei @dgageot hat das vor 28 Tagen übernommen, und es ist kein Pull Request offen. Offenarea/cli
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 62/100
docker/docker-agent#4672 · 1 Kommentar · 1 Reaktion · 1 zugewiesene Person ·
Maintainer antworten meist innerhalb von 1 Tag
-
`edit_file` silently edits the first match when `oldText` occurs more than onceEvtl. vergeben @dwin-gharibi hat das vor 103 Tagen übernommen. Offenarea/tools
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 78/100
docker/docker-agent#3929 · 2 Kommentare ·
Maintainer antworten meist innerhalb von 1 Tag
-
area/api area/runtime
Schwierigkeit 4/5 3-5 Tage Anfängerfreundlichkeit 48/100
docker/docker-agent#4951 ·
Maintainer antworten meist innerhalb von 1 Tag
Alle Issues in docker/docker-agent
Ähnliche Issues
-
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 78/100
IBM-Cloud/terraform-provider-ibm#7115 ·
Maintainer antworten meist innerhalb von 2 Tagen
-
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 86/100
fluxcd/notification-controller#1441 ·
Maintainer antworten meist innerhalb von 1 Tag
-
bug
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 66/100
volcengine/volcengine-go-sdk#163 · 1 Kommentar ·
-
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 76/100
OneBusAway/maglev#2145 ·
Maintainer antworten meist innerhalb von 2 Tagen
-
priority/medium status/ready type/chore
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 84/100
discobox-ai/discobox#1357 ·
Maintainer antworten meist innerhalb von 1 Tag