[Flaky test] TestBackgroundWorktreeIsolationAndMerge
Los mantenedores suelen responder en 1 día
Evaluación
- Dificultad
- 3/5
- Tiempo estimado
- Medio día
- Aptitud para principiantes
- 20/100
Línea de trabajo
Start with the concurrent launch in pkg/runtime/background_worktree_test.go (lines 134-139) and the completed assertion at line 156, then find where the background agent path runs git worktree add. Run the repro loop from the issue to see the commondir failure. Done means the flaky subtest passes reliably, either by serializing per-repo creation or retrying transient failures. PR #4923 is already open against this, so check it before starting.
Escrito por el modelo de indexación a partir del texto del issue.
Descripción
Description
Failed once on PR #4907's test-linux (run 43133474124, first attempt, Nov 12). The linked=false subtest launches two background agents that create their git worktrees concurrently in the same repo (pkg/runtime/background_worktree_test.go:134-139); task first failed with
creating background worktree: creating git worktree: exit status 128:
Preparing worktree (new branch 'worktree-agent-bb8bc299-...')
fatal: failed to read .git/worktrees/agent-788eb22e-.../commondir: Success
while task second completed normally — its worktree is exactly the admin entry first's git worktree add stumbled on. A short read of a half-written commondir (errno 0 ⇒ "Success") means one git worktree add read another's in-flight administrative entry and exited 128, so the task was marked failed and the test's completed assertion (background_worktree_test.go:156) failed.
I reproduced the git-level race locally (linux/amd64, git 2.51.0), independently of the test harness: 16 concurrent git worktree add in a fresh repo, 400 rounds — 51 rounds hit exactly this error (fatal: failed to read .git/worktrees/<name>/commondir: Success, plus an ENOENT variant), with several concurrent adds stumbling over the same half-written entry within one round. The test itself only races 2 concurrent adds, which matches its low flake rate; CI runner I/O widens the window.
Expected Behavior
Concurrent background worktree creation in one repo is safe; a transient git failure of this kind doesn't fail a task the test expects to complete.
Actual Behavior
Intermittently, one concurrent creation fails on a half-written admin entry and the task is recorded as failed.
Steps to Reproduce
- Run the repro script (pasted under Error output) on Linux
- It races 16 concurrent
git worktree addin a fresh repo, 400 rounds - Measured here: 51/400 rounds hit the error below
Docker Agent version
No response
OS & terminal
No response
Model used
No response
Error output
hits=0
for r in $(seq 1 400); do
base=$(mktemp -d)
git init -q $base/repo
git -C $base/repo commit -q --allow-empty -m i
for i in $(seq 1 16); do
( git -C $base/repo worktree add $base/w$i HEAD >/dev/null 2>$base/err$i ) &
done
wait
grep -q commondir $base/err* 2>/dev/null && hits=$((hits+1))
rm -rf $base
done
echo "rounds with a commondir failure: $hits/400" # measured: 51/400
Screenshots
No response
Additional context
report-main-failures only auto-files flakes seen on main, so this PR-run failure isn't in the tracker yet. Suggested direction:
serialize per-repo worktree creation in the background-agent path, or retry a creation that fails with a transient commondir read error.
Happy to work on the fix.
- Lenguaje dominante
- Go
- Estrellas
- 4.7k
- Forks
- 565
- Merge medio
- 18 h 52 min
- PR fusionados (30 d)
- 221
Preparar el entorno
Inicia el contenedor de desarrollo del proyecto en tu navegador, con tu propia cuenta de GitHub.
- Incluye un Dockerfile o un archivo de Docker Compose
- Sin plantilla de pull request
- Sin guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Más de docker/docker-agent
-
edit_file diff rendering panics on invalid UTF-8 textPosiblemente ocupada @TDnorthgarden la tomó hoy. Abiertoarea/tui
Dificultad 2/5 1-3 horas Aptitud para principiantes 85/100
docker/docker-agent#4955 ·
Los mantenedores suelen responder en 1 día
-
A setting to turn off the models.dev catalog download (offline and strict-network use)Posiblemente ocupada @3431481073 la tomó hace 19 días. Abiertoarea/config area/models
Dificultad 2/5 1-3 horas Aptitud para principiantes 72/100
docker/docker-agent#4714 ·
Los mantenedores suelen responder en 1 día
-
Error when trying to run sandbox example?Quizá libre de nuevo @dgageot la tomó hace 28 días y no hay ningún pull request abierto. Abiertoarea/cli
Dificultad 2/5 1-3 horas Aptitud para principiantes 62/100
docker/docker-agent#4672 · 1 comentario · 1 reacción · 1 asignado ·
Los mantenedores suelen responder en 1 día
-
`edit_file` silently edits the first match when `oldText` occurs more than oncePosiblemente ocupada @dwin-gharibi la tomó hace 103 días. Abiertoarea/tools
Dificultad 2/5 1-3 horas Aptitud para principiantes 78/100
docker/docker-agent#3929 · 2 comentarios ·
Los mantenedores suelen responder en 1 día
-
area/api area/runtime
Dificultad 4/5 3-5 días Aptitud para principiantes 48/100
docker/docker-agent#4951 ·
Los mantenedores suelen responder en 1 día
Todos los issues de docker/docker-agent
Issues similares
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 78/100
IBM-Cloud/terraform-provider-ibm#7115 ·
Los mantenedores suelen responder en 2 días
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 86/100
fluxcd/notification-controller#1441 ·
Los mantenedores suelen responder en 1 día
-
bug
Dificultad 2/5 1-3 horas Aptitud para principiantes 66/100
volcengine/volcengine-go-sdk#163 · 1 comentario ·
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 76/100
OneBusAway/maglev#2145 ·
Los mantenedores suelen responder en 2 días
-
priority/medium status/ready type/chore
Dificultad 2/5 1-3 horas Aptitud para principiantes 84/100
discobox-ai/discobox#1357 ·
Los mantenedores suelen responder en 1 día