[Flaky test] TestBackgroundWorktreeIsolationAndMerge
维护者通常 1 天内回复
评估
调研方向
Start with the concurrent launch in pkg/runtime/background_worktree_test.go (lines 134-139) and the completed assertion at line 156, then find where the background agent path runs git worktree add. Run the repro loop from the issue to see the commondir failure. Done means the flaky subtest passes reliably, either by serializing per-repo creation or retrying transient failures. PR #4923 is already open against this, so check it before starting.
由索引模型根据 Issue 内容生成。
描述
Description
Failed once on PR #4907's test-linux (run 43133474124, first attempt, Nov 12). The linked=false subtest launches two background agents that create their git worktrees concurrently in the same repo (pkg/runtime/background_worktree_test.go:134-139); task first failed with
creating background worktree: creating git worktree: exit status 128:
Preparing worktree (new branch 'worktree-agent-bb8bc299-...')
fatal: failed to read .git/worktrees/agent-788eb22e-.../commondir: Success
while task second completed normally — its worktree is exactly the admin entry first's git worktree add stumbled on. A short read of a half-written commondir (errno 0 ⇒ "Success") means one git worktree add read another's in-flight administrative entry and exited 128, so the task was marked failed and the test's completed assertion (background_worktree_test.go:156) failed.
I reproduced the git-level race locally (linux/amd64, git 2.51.0), independently of the test harness: 16 concurrent git worktree add in a fresh repo, 400 rounds — 51 rounds hit exactly this error (fatal: failed to read .git/worktrees/<name>/commondir: Success, plus an ENOENT variant), with several concurrent adds stumbling over the same half-written entry within one round. The test itself only races 2 concurrent adds, which matches its low flake rate; CI runner I/O widens the window.
Expected Behavior
Concurrent background worktree creation in one repo is safe; a transient git failure of this kind doesn't fail a task the test expects to complete.
Actual Behavior
Intermittently, one concurrent creation fails on a half-written admin entry and the task is recorded as failed.
Steps to Reproduce
- Run the repro script (pasted under Error output) on Linux
- It races 16 concurrent
git worktree addin a fresh repo, 400 rounds - Measured here: 51/400 rounds hit the error below
Docker Agent version
No response
OS & terminal
No response
Model used
No response
Error output
hits=0
for r in $(seq 1 400); do
base=$(mktemp -d)
git init -q $base/repo
git -C $base/repo commit -q --allow-empty -m i
for i in $(seq 1 16); do
( git -C $base/repo worktree add $base/w$i HEAD >/dev/null 2>$base/err$i ) &
done
wait
grep -q commondir $base/err* 2>/dev/null && hits=$((hits+1))
rm -rf $base
done
echo "rounds with a commondir failure: $hits/400" # measured: 51/400
Screenshots
No response
Additional context
report-main-failures only auto-files flakes seen on main, so this PR-run failure isn't in the tracker yet. Suggested direction:
serialize per-repo worktree creation in the background-agent path, or retry a creation that fails with a transient commondir read error.
Happy to work on the fix.
- 主要语言
- Go
- 星标
- 4.7k
- 派生
- 565
- 平均合并
- 18 小时 52 分钟
- 30 天内合并 PR
- 221
环境准备
在浏览器里用你自己的 GitHub 账号启动这个项目的开发容器。
- 提供 Dockerfile 或 Docker Compose 文件
- 没有 Pull Request 模板
- 没有贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
docker/docker-agent 的其他 Issue
-
edit_file diff rendering panics on invalid UTF-8 text可能已有人在做 @TDnorthgarden 今天认领。 未关闭area/tui
难度 2/5 1-3 小时 新手友好度 85/100
docker/docker-agent#4955 ·
维护者通常 1 天内回复
-
A setting to turn off the models.dev catalog download (offline and strict-network use)可能已有人在做 @3431481073 于 19 天前认领。 未关闭area/config area/models
难度 2/5 1-3 小时 新手友好度 72/100
docker/docker-agent#4714 ·
维护者通常 1 天内回复
-
Error when trying to run sandbox example?可能重新可做 @dgageot 于 28 天前认领,目前没有进行中的 PR。 未关闭area/cli
难度 2/5 1-3 小时 新手友好度 62/100
docker/docker-agent#4672 · 1 条评论 · 1 个 reaction · 已指派 1 人 ·
维护者通常 1 天内回复
-
`edit_file` silently edits the first match when `oldText` occurs more than once可能已有人在做 @dwin-gharibi 于 103 天前认领。 未关闭area/tools
难度 2/5 1-3 小时 新手友好度 78/100
docker/docker-agent#3929 · 2 条评论 ·
维护者通常 1 天内回复
-
area/api area/runtime
难度 4/5 3-5 天 新手友好度 48/100
docker/docker-agent#4951 ·
维护者通常 1 天内回复
查看 docker/docker-agent 的全部 Issue
相似的 Issue
-
难度 2/5 1-3 小时 新手友好度 78/100
IBM-Cloud/terraform-provider-ibm#7115 ·
维护者通常 2 天内回复
-
难度 2/5 1-3 小时 新手友好度 86/100
fluxcd/notification-controller#1441 ·
维护者通常 1 天内回复
-
bug
难度 2/5 1-3 小时 新手友好度 66/100
volcengine/volcengine-go-sdk#163 · 1 条评论 ·
-
难度 2/5 1-3 小时 新手友好度 76/100
OneBusAway/maglev#2145 ·
维护者通常 2 天内回复
-
priority/medium status/ready type/chore
难度 2/5 1-3 小时 新手友好度 84/100
discobox-ai/discobox#1357 ·
维护者通常 1 天内回复