[Flaky test] TestBackgroundWorktreeIsolationAndMerge
Mantenedores costumam responder em até 1 dia
Avaliação
- Dificuldade
- 3/5
- Tempo estimado
- Meio dia
- Facilidade para iniciantes
- 20/100
Direção de pesquisa
Start with the concurrent launch in pkg/runtime/background_worktree_test.go (lines 134-139) and the completed assertion at line 156, then find where the background agent path runs git worktree add. Run the repro loop from the issue to see the commondir failure. Done means the flaky subtest passes reliably, either by serializing per-repo creation or retrying transient failures. PR #4923 is already open against this, so check it before starting.
Escrita pelo modelo de indexação a partir do texto da issue.
Descrição
Description
Failed once on PR #4907's test-linux (run 43133474124, first attempt, Nov 12). The linked=false subtest launches two background agents that create their git worktrees concurrently in the same repo (pkg/runtime/background_worktree_test.go:134-139); task first failed with
creating background worktree: creating git worktree: exit status 128:
Preparing worktree (new branch 'worktree-agent-bb8bc299-...')
fatal: failed to read .git/worktrees/agent-788eb22e-.../commondir: Success
while task second completed normally — its worktree is exactly the admin entry first's git worktree add stumbled on. A short read of a half-written commondir (errno 0 ⇒ "Success") means one git worktree add read another's in-flight administrative entry and exited 128, so the task was marked failed and the test's completed assertion (background_worktree_test.go:156) failed.
I reproduced the git-level race locally (linux/amd64, git 2.51.0), independently of the test harness: 16 concurrent git worktree add in a fresh repo, 400 rounds — 51 rounds hit exactly this error (fatal: failed to read .git/worktrees/<name>/commondir: Success, plus an ENOENT variant), with several concurrent adds stumbling over the same half-written entry within one round. The test itself only races 2 concurrent adds, which matches its low flake rate; CI runner I/O widens the window.
Expected Behavior
Concurrent background worktree creation in one repo is safe; a transient git failure of this kind doesn't fail a task the test expects to complete.
Actual Behavior
Intermittently, one concurrent creation fails on a half-written admin entry and the task is recorded as failed.
Steps to Reproduce
- Run the repro script (pasted under Error output) on Linux
- It races 16 concurrent
git worktree addin a fresh repo, 400 rounds - Measured here: 51/400 rounds hit the error below
Docker Agent version
No response
OS & terminal
No response
Model used
No response
Error output
hits=0
for r in $(seq 1 400); do
base=$(mktemp -d)
git init -q $base/repo
git -C $base/repo commit -q --allow-empty -m i
for i in $(seq 1 16); do
( git -C $base/repo worktree add $base/w$i HEAD >/dev/null 2>$base/err$i ) &
done
wait
grep -q commondir $base/err* 2>/dev/null && hits=$((hits+1))
rm -rf $base
done
echo "rounds with a commondir failure: $hits/400" # measured: 51/400
Screenshots
No response
Additional context
report-main-failures only auto-files flakes seen on main, so this PR-run failure isn't in the tracker yet. Suggested direction:
serialize per-repo worktree creation in the background-agent path, or retry a creation that fails with a transient commondir read error.
Happy to work on the fix.
- Linguagem predominante
- Go
- Estrelas
- 4.7k
- Forks
- 565
- Merge médio
- 18h 52min
- PRs com merge (30d)
- 221
Preparar o ambiente
Inicia o contêiner de desenvolvimento do projeto no navegador, com a sua própria conta do GitHub.
- Inclui um Dockerfile ou arquivo Docker Compose
- Sem modelo de pull request
- Sem guia de contribuição
Primeiros passos
- Leia a issue inteira e depois o guia de contribuição do projeto.
- Comente na issue dizendo que vai assumir — evita que duas pessoas façam o mesmo trabalho.
- Faça um fork do repositório e trabalhe em uma branch.
- Abra um pull request que referencie o número da issue.
Mais de docker/docker-agent
-
edit_file diff rendering panics on invalid UTF-8 textTalvez já em andamento @TDnorthgarden assumiu hoje. Abertaarea/tui
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 85/100
docker/docker-agent#4955 ·
Mantenedores costumam responder em até 1 dia
-
A setting to turn off the models.dev catalog download (offline and strict-network use)Talvez já em andamento @3431481073 assumiu há 19 dias. Abertaarea/config area/models
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 72/100
docker/docker-agent#4714 ·
Mantenedores costumam responder em até 1 dia
-
Error when trying to run sandbox example?Talvez livre de novo @dgageot assumiu há 28 dias e não há nenhum pull request aberto. Abertaarea/cli
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 62/100
docker/docker-agent#4672 · 1 comentário · 1 reação · 1 responsável ·
Mantenedores costumam responder em até 1 dia
-
`edit_file` silently edits the first match when `oldText` occurs more than onceTalvez já em andamento @dwin-gharibi assumiu há 104 dias. Abertaarea/tools
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 78/100
docker/docker-agent#3929 · 2 comentários ·
Mantenedores costumam responder em até 1 dia
-
area/api area/runtime
Dificuldade 4/5 3-5 dias Facilidade para iniciantes 48/100
docker/docker-agent#4951 ·
Mantenedores costumam responder em até 1 dia
Todas as issues de docker/docker-agent
Issues semelhantes
-
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 65/100
hexlet-basics/hexlet-basics#968 ·
Mantenedores costumam responder em até 1 dia
-
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 79/100
kubernetes-sigs/scheduler-plugins#1031 ·
-
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 78/100
Netcracker/qubership-authz-agent#311 ·
Mantenedores costumam responder em até 1 dia
-
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 78/100
Mantenedores costumam responder em até 1 dia
-
agent-review-finding chore
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 74/100
jordansmall/spindrift#7254 ·
Mantenedores costumam responder em até 1 dia