Closing a TUI tab leaks its runtime, session and context in --listen mode
Maintainer antworten meist innerhalb von 1 Tag
@pcbeingused333 arbeitet bereits daran.
Seit 14.11.2026.
Bewertung
- Schwierigkeit
- 4/5
- Geschätzter Aufwand
- 3-5 Tage
- Anfängerfreundlichkeit
- 35/100
Rechercherichtung
Read AttachRuntime (pkg/server/session_manager.go around lines 451-463) next to finishSessionDeletion (lines 958-992), since the detach path should mirror the cleanup there. Then check the tab-close flow in Supervisor.CloseSession (pkg/tui/service/supervisor/supervisor.go:308) and the injector registration in cmd/root/run_listen.go:49. Done means a closed tab disappears from GET /api/sessions, its context is cancelled, and the persisted session still exists.
Vom Indexierungsmodell aus dem Issue-Text verfasst.
Beschreibung
Description
In --listen mode every TUI tab attaches its runtime to the serving session
manager, and there is no detach path. The only code that removes an entry
from runtimeSessions is session deletion
(DeleteSession/BatchDeleteSessions → finishSessionDeletion,
pkg/server/session_manager.go:958-992), while closing a tab goes through
Supervisor.CloseSession (pkg/tui/service/supervisor/supervisor.go:308),
which cancels the TUI-local context and removes the tab from the supervisor
— but is not a session deletion, so none of that cleanup ever runs for a
closed tab.
Per closed tab, the following stay reachable for the life of the process:
- the
runtime.Runtimeandsession.Sessionheld by theactiveRuntimes
entry (session_manager.go:451-463); - the context created by
context.WithCancel(context.WithoutCancel(ctx))
insideAttachRuntime— itscancelis only invoked on session deletion,
so the whole context tree is retained; - the follow-up injector registered at
cmd/root/run_listen.go:49
(sm.RegisterFollowUpInjector(sess.ID, a.InjectUserMessage)), a closure
that keeps the tab's*app.Appreachable; - the recall handler
AttachRuntimeinstalls on the runtime
(session_manager.go:460).
A long-running --listen process that cycles through tabs therefore
accumulates one runtime+session+context set per closed tab, none of it
collectable. A single CLI run is bounded by process exit; the same
unbounded accumulation applies to embedders that attach runtimes to a
serve api session manager.
Expected Behavior
Closing a tab releases what the tab attached to the session manager: the
runtimeSessions entry is removed, its context cancelled, and the follow-up
injector / recall handler dropped — while the persisted session itself stays
(tab close ≠ session delete).
Actual Behavior
Closed tabs keep their runtime, session and context attached until the
process exits. GET /api/sessions keeps listing tabs that were closed,
because GetActiveSessions ranges over runtimeSessions
(session_manager.go:505-510).
Steps to Reproduce
docker-agent run config.yaml --listen 127.0.0.1:8080- In the TUI, open several new tabs (each spawned tab attaches to the
serving manager — see the wiring comment atcmd/root/run_listen.go:31-43) - Close the tabs
curl http://127.0.0.1:8080/api/sessions— every closed tab still shows
up as an active session, and the underlying runtime/session/context are
never released
Docker Agent version
docker-agent version dev Commit: 3c9f6d4
OS & terminal
No response
Model used
No response
Error output
Screenshots
No response
Additional context
Verified on current main (3c9f6d45b): no DetachRuntime exists anywhere
in the tree, and runtimeSessions.Delete has exactly one call site (session
deletion).
Suggested direction: a DetachRuntime(sessionID) symmetric with
AttachRuntime, called from the tab-close path — remove the entry, call
cancel(), and unregister the follow-up injector, recall handler and
event-log references (mirroring finishSessionDeletion's cleanup at
session_manager.go:989-992), leaving the persisted session intact. The
locker AttachRuntime returns carries the #3590 stream-guard contract
(callers hold it across direct RunStream calls), so a detach path must
keep that contract working for still-attached runtimes.
- Vorherrschende Sprache
- Go
- Sterne
- 4.7k
- Forks
- 565
- Ø Merge
- 18 Std. 52 Min.
- Gemergte PRs (30 T.)
- 221
Entwicklungsumgebung
Startet den Dev-Container des Projekts im Browser, mit Ihrem eigenen GitHub-Konto.
- Enthält ein Dockerfile oder eine Docker-Compose-Datei
- Keine Pull-Request-Vorlage
- Kein Beitragsleitfaden
Erste Schritte
- Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
- Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
- Forken Sie das Repository und arbeiten Sie in einem Branch.
- Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.
Mehr aus docker/docker-agent
-
edit_file diff rendering panics on invalid UTF-8 textEvtl. vergeben @TDnorthgarden hat das heute übernommen. Offenarea/tui
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 85/100
docker/docker-agent#4955 ·
Maintainer antworten meist innerhalb von 1 Tag
-
A setting to turn off the models.dev catalog download (offline and strict-network use)Evtl. vergeben @3431481073 hat das vor 19 Tagen übernommen. Offenarea/config area/models
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 72/100
docker/docker-agent#4714 ·
Maintainer antworten meist innerhalb von 1 Tag
-
Error when trying to run sandbox example?Evtl. wieder frei @dgageot hat das vor 28 Tagen übernommen, und es ist kein Pull Request offen. Offenarea/cli
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 62/100
docker/docker-agent#4672 · 1 Kommentar · 1 Reaktion · 1 zugewiesene Person ·
Maintainer antworten meist innerhalb von 1 Tag
-
`edit_file` silently edits the first match when `oldText` occurs more than onceEvtl. vergeben @dwin-gharibi hat das vor 103 Tagen übernommen. Offenarea/tools
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 78/100
docker/docker-agent#3929 · 2 Kommentare ·
Maintainer antworten meist innerhalb von 1 Tag
-
area/api area/runtime
Schwierigkeit 4/5 3-5 Tage Anfängerfreundlichkeit 48/100
docker/docker-agent#4951 ·
Maintainer antworten meist innerhalb von 1 Tag
Alle Issues in docker/docker-agent
Ähnliche Issues
-
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 78/100
IBM-Cloud/terraform-provider-ibm#7115 ·
Maintainer antworten meist innerhalb von 2 Tagen
-
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 86/100
fluxcd/notification-controller#1441 ·
Maintainer antworten meist innerhalb von 1 Tag
-
bug
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 66/100
volcengine/volcengine-go-sdk#163 · 1 Kommentar ·
-
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 76/100
OneBusAway/maglev#2145 ·
Maintainer antworten meist innerhalb von 2 Tagen
-
priority/medium status/ready type/chore
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 84/100
discobox-ai/discobox#1357 ·
Maintainer antworten meist innerhalb von 1 Tag