Closing a TUI tab leaks its runtime, session and context in --listen mode
维护者通常 1 天内回复
@pcbeingused333 已经在做这个了。
开始于 2026年11月14日。
评估
调研方向
Read AttachRuntime (pkg/server/session_manager.go around lines 451-463) next to finishSessionDeletion (lines 958-992), since the detach path should mirror the cleanup there. Then check the tab-close flow in Supervisor.CloseSession (pkg/tui/service/supervisor/supervisor.go:308) and the injector registration in cmd/root/run_listen.go:49. Done means a closed tab disappears from GET /api/sessions, its context is cancelled, and the persisted session still exists.
由索引模型根据 Issue 内容生成。
描述
Description
In --listen mode every TUI tab attaches its runtime to the serving session
manager, and there is no detach path. The only code that removes an entry
from runtimeSessions is session deletion
(DeleteSession/BatchDeleteSessions → finishSessionDeletion,
pkg/server/session_manager.go:958-992), while closing a tab goes through
Supervisor.CloseSession (pkg/tui/service/supervisor/supervisor.go:308),
which cancels the TUI-local context and removes the tab from the supervisor
— but is not a session deletion, so none of that cleanup ever runs for a
closed tab.
Per closed tab, the following stay reachable for the life of the process:
- the
runtime.Runtimeandsession.Sessionheld by theactiveRuntimes
entry (session_manager.go:451-463); - the context created by
context.WithCancel(context.WithoutCancel(ctx))
insideAttachRuntime— itscancelis only invoked on session deletion,
so the whole context tree is retained; - the follow-up injector registered at
cmd/root/run_listen.go:49
(sm.RegisterFollowUpInjector(sess.ID, a.InjectUserMessage)), a closure
that keeps the tab's*app.Appreachable; - the recall handler
AttachRuntimeinstalls on the runtime
(session_manager.go:460).
A long-running --listen process that cycles through tabs therefore
accumulates one runtime+session+context set per closed tab, none of it
collectable. A single CLI run is bounded by process exit; the same
unbounded accumulation applies to embedders that attach runtimes to a
serve api session manager.
Expected Behavior
Closing a tab releases what the tab attached to the session manager: the
runtimeSessions entry is removed, its context cancelled, and the follow-up
injector / recall handler dropped — while the persisted session itself stays
(tab close ≠ session delete).
Actual Behavior
Closed tabs keep their runtime, session and context attached until the
process exits. GET /api/sessions keeps listing tabs that were closed,
because GetActiveSessions ranges over runtimeSessions
(session_manager.go:505-510).
Steps to Reproduce
docker-agent run config.yaml --listen 127.0.0.1:8080- In the TUI, open several new tabs (each spawned tab attaches to the
serving manager — see the wiring comment atcmd/root/run_listen.go:31-43) - Close the tabs
curl http://127.0.0.1:8080/api/sessions— every closed tab still shows
up as an active session, and the underlying runtime/session/context are
never released
Docker Agent version
docker-agent version dev Commit: 3c9f6d4
OS & terminal
No response
Model used
No response
Error output
Screenshots
No response
Additional context
Verified on current main (3c9f6d45b): no DetachRuntime exists anywhere
in the tree, and runtimeSessions.Delete has exactly one call site (session
deletion).
Suggested direction: a DetachRuntime(sessionID) symmetric with
AttachRuntime, called from the tab-close path — remove the entry, call
cancel(), and unregister the follow-up injector, recall handler and
event-log references (mirroring finishSessionDeletion's cleanup at
session_manager.go:989-992), leaving the persisted session intact. The
locker AttachRuntime returns carries the #3590 stream-guard contract
(callers hold it across direct RunStream calls), so a detach path must
keep that contract working for still-attached runtimes.
- 主要语言
- Go
- 星标
- 4.7k
- 派生
- 565
- 平均合并
- 18 小时 52 分钟
- 30 天内合并 PR
- 221
环境准备
在浏览器里用你自己的 GitHub 账号启动这个项目的开发容器。
- 提供 Dockerfile 或 Docker Compose 文件
- 没有 Pull Request 模板
- 没有贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
docker/docker-agent 的其他 Issue
-
edit_file diff rendering panics on invalid UTF-8 text可能已有人在做 @TDnorthgarden 今天认领。 未关闭area/tui
难度 2/5 1-3 小时 新手友好度 85/100
docker/docker-agent#4955 ·
维护者通常 1 天内回复
-
A setting to turn off the models.dev catalog download (offline and strict-network use)可能已有人在做 @3431481073 于 19 天前认领。 未关闭area/config area/models
难度 2/5 1-3 小时 新手友好度 72/100
docker/docker-agent#4714 ·
维护者通常 1 天内回复
-
Error when trying to run sandbox example?可能已有人在做 @dgageot 于 28 天前认领。 未关闭area/cli
难度 2/5 1-3 小时 新手友好度 62/100
docker/docker-agent#4672 · 1 条评论 · 1 个 reaction · 已指派 1 人 ·
维护者通常 1 天内回复
-
`edit_file` silently edits the first match when `oldText` occurs more than once可能已有人在做 @dwin-gharibi 于 103 天前认领。 未关闭area/tools
难度 2/5 1-3 小时 新手友好度 78/100
docker/docker-agent#3929 · 2 条评论 ·
维护者通常 1 天内回复
-
area/api area/runtime
难度 4/5 3-5 天 新手友好度 48/100
docker/docker-agent#4951 ·
维护者通常 1 天内回复
查看 docker/docker-agent 的全部 Issue
相似的 Issue
-
难度 2/5 1-3 小时 新手友好度 78/100
IBM-Cloud/terraform-provider-ibm#7115 ·
维护者通常 2 天内回复
-
难度 2/5 1-3 小时 新手友好度 86/100
fluxcd/notification-controller#1441 ·
维护者通常 1 天内回复
-
bug
难度 2/5 1-3 小时 新手友好度 66/100
volcengine/volcengine-go-sdk#163 · 1 条评论 ·
-
难度 2/5 1-3 小时 新手友好度 76/100
OneBusAway/maglev#2145 ·
维护者通常 2 天内回复
-
priority/medium status/ready type/chore
难度 2/5 1-3 小时 新手友好度 84/100
discobox-ai/discobox#1357 ·
维护者通常 1 天内回复