Closing a TUI tab leaks its runtime, session and context in --listen mode

未关闭
#4,909 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

@pcbeingused333 已经在做这个了。

开始于 2026年11月14日。

  • #4930 来自 @pcbeingused333 —— 未关闭
  • #4931 来自 @PerryLink —— 未关闭

评估

难度
4/5
预计耗时
3-5 天
新手友好度
35/100
Issue 类型
缺陷
描述清晰度
描述清楚
活跃度
活跃
技术栈
go
领域
backend, cli

调研方向

Read AttachRuntime (pkg/server/session_manager.go around lines 451-463) next to finishSessionDeletion (lines 958-992), since the detach path should mirror the cleanup there. Then check the tab-close flow in Supervisor.CloseSession (pkg/tui/service/supervisor/supervisor.go:308) and the injector registration in cmd/root/run_listen.go:49. Done means a closed tab disappears from GET /api/sessions, its context is cancelled, and the persisted session still exists.

由索引模型根据 Issue 内容生成。

描述

area/api area/runtime area/sessions area/tui
Description

In --listen mode every TUI tab attaches its runtime to the serving session
manager, and there is no detach path. The only code that removes an entry
from runtimeSessions is session deletion
(DeleteSession/BatchDeleteSessions → finishSessionDeletion,
pkg/server/session_manager.go:958-992), while closing a tab goes through
Supervisor.CloseSession (pkg/tui/service/supervisor/supervisor.go:308),
which cancels the TUI-local context and removes the tab from the supervisor
— but is not a session deletion, so none of that cleanup ever runs for a
closed tab.

Per closed tab, the following stay reachable for the life of the process:

  • the runtime.Runtime and session.Session held by the activeRuntimes
    entry (session_manager.go:451-463);
  • the context created by context.WithCancel(context.WithoutCancel(ctx))
    inside AttachRuntime — its cancel is only invoked on session deletion,
    so the whole context tree is retained;
  • the follow-up injector registered at cmd/root/run_listen.go:49
    (sm.RegisterFollowUpInjector(sess.ID, a.InjectUserMessage)), a closure
    that keeps the tab's *app.App reachable;
  • the recall handler AttachRuntime installs on the runtime
    (session_manager.go:460).

A long-running --listen process that cycles through tabs therefore
accumulates one runtime+session+context set per closed tab, none of it
collectable. A single CLI run is bounded by process exit; the same
unbounded accumulation applies to embedders that attach runtimes to a
serve api session manager.

Expected Behavior

Closing a tab releases what the tab attached to the session manager: the
runtimeSessions entry is removed, its context cancelled, and the follow-up
injector / recall handler dropped — while the persisted session itself stays
(tab close ≠ session delete).

Actual Behavior

Closed tabs keep their runtime, session and context attached until the
process exits. GET /api/sessions keeps listing tabs that were closed,
because GetActiveSessions ranges over runtimeSessions
(session_manager.go:505-510).

Steps to Reproduce
  1. docker-agent run config.yaml --listen 127.0.0.1:8080
  2. In the TUI, open several new tabs (each spawned tab attaches to the
    serving manager — see the wiring comment at cmd/root/run_listen.go:31-43)
  3. Close the tabs
  4. curl http://127.0.0.1:8080/api/sessions — every closed tab still shows
    up as an active session, and the underlying runtime/session/context are
    never released
Docker Agent version

docker-agent version dev Commit: 3c9f6d4

OS & terminal

No response

Model used

No response

Error output

Screenshots

No response

Additional context

Verified on current main (3c9f6d45b): no DetachRuntime exists anywhere
in the tree, and runtimeSessions.Delete has exactly one call site (session
deletion).

Suggested direction: a DetachRuntime(sessionID) symmetric with
AttachRuntime, called from the tab-close path — remove the entry, call
cancel(), and unregister the follow-up injector, recall handler and
event-log references (mirroring finishSessionDeletion's cleanup at
session_manager.go:989-992), leaving the persisted session intact. The
locker AttachRuntime returns carries the #3590 stream-guard contract
(callers hold it across direct RunStream calls), so a detach path must
keep that contract working for still-attached runtimes.

主要语言
Go
星标
4.7k
派生
565
平均合并
18 小时 52 分钟
30 天内合并 PR
221

环境准备

在 Codespaces 中打开

在浏览器里用你自己的 GitHub 账号启动这个项目的开发容器。

  • 提供 Dockerfile 或 Docker Compose 文件
  • 没有 Pull Request 模板
  • 没有贡献指南

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

docker/docker-agent 的其他 Issue

查看 docker/docker-agent 的全部 Issue

相似的 Issue

更多 Go Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。