Closing a TUI tab leaks its runtime, session and context in --listen mode

Aberta
#4,909 0 comentários 0 reações 0 responsáveis Ver no GitHub

Mantenedores costumam responder em até 1 dia

@pcbeingused333 já está trabalhando nisso.

Desde 14/11/2026.

  • #4930 de @pcbeingused333 — aberto
  • #4931 de @PerryLink — aberto

Avaliação

Dificuldade
4/5
Tempo estimado
3-5 dias
Facilidade para iniciantes
35/100
Tipo de issue
Bug
Clareza
Claramente especificada
Status de atividade
Ativa
Stack de tecnologia
go
Domínio
backend, cli

Direção de pesquisa

Read AttachRuntime (pkg/server/session_manager.go around lines 451-463) next to finishSessionDeletion (lines 958-992), since the detach path should mirror the cleanup there. Then check the tab-close flow in Supervisor.CloseSession (pkg/tui/service/supervisor/supervisor.go:308) and the injector registration in cmd/root/run_listen.go:49. Done means a closed tab disappears from GET /api/sessions, its context is cancelled, and the persisted session still exists.

Escrita pelo modelo de indexação a partir do texto da issue.

Descrição

area/api area/runtime area/sessions area/tui
Description

In --listen mode every TUI tab attaches its runtime to the serving session
manager, and there is no detach path. The only code that removes an entry
from runtimeSessions is session deletion
(DeleteSession/BatchDeleteSessions → finishSessionDeletion,
pkg/server/session_manager.go:958-992), while closing a tab goes through
Supervisor.CloseSession (pkg/tui/service/supervisor/supervisor.go:308),
which cancels the TUI-local context and removes the tab from the supervisor
— but is not a session deletion, so none of that cleanup ever runs for a
closed tab.

Per closed tab, the following stay reachable for the life of the process:

  • the runtime.Runtime and session.Session held by the activeRuntimes
    entry (session_manager.go:451-463);
  • the context created by context.WithCancel(context.WithoutCancel(ctx))
    inside AttachRuntime — its cancel is only invoked on session deletion,
    so the whole context tree is retained;
  • the follow-up injector registered at cmd/root/run_listen.go:49
    (sm.RegisterFollowUpInjector(sess.ID, a.InjectUserMessage)), a closure
    that keeps the tab's *app.App reachable;
  • the recall handler AttachRuntime installs on the runtime
    (session_manager.go:460).

A long-running --listen process that cycles through tabs therefore
accumulates one runtime+session+context set per closed tab, none of it
collectable. A single CLI run is bounded by process exit; the same
unbounded accumulation applies to embedders that attach runtimes to a
serve api session manager.

Expected Behavior

Closing a tab releases what the tab attached to the session manager: the
runtimeSessions entry is removed, its context cancelled, and the follow-up
injector / recall handler dropped — while the persisted session itself stays
(tab close ≠ session delete).

Actual Behavior

Closed tabs keep their runtime, session and context attached until the
process exits. GET /api/sessions keeps listing tabs that were closed,
because GetActiveSessions ranges over runtimeSessions
(session_manager.go:505-510).

Steps to Reproduce
  1. docker-agent run config.yaml --listen 127.0.0.1:8080
  2. In the TUI, open several new tabs (each spawned tab attaches to the
    serving manager — see the wiring comment at cmd/root/run_listen.go:31-43)
  3. Close the tabs
  4. curl http://127.0.0.1:8080/api/sessions — every closed tab still shows
    up as an active session, and the underlying runtime/session/context are
    never released
Docker Agent version

docker-agent version dev Commit: 3c9f6d4

OS & terminal

No response

Model used

No response

Error output

Screenshots

No response

Additional context

Verified on current main (3c9f6d45b): no DetachRuntime exists anywhere
in the tree, and runtimeSessions.Delete has exactly one call site (session
deletion).

Suggested direction: a DetachRuntime(sessionID) symmetric with
AttachRuntime, called from the tab-close path — remove the entry, call
cancel(), and unregister the follow-up injector, recall handler and
event-log references (mirroring finishSessionDeletion's cleanup at
session_manager.go:989-992), leaving the persisted session intact. The
locker AttachRuntime returns carries the #3590 stream-guard contract
(callers hold it across direct RunStream calls), so a detach path must
keep that contract working for still-attached runtimes.

Linguagem predominante
Go
Estrelas
4.7k
Forks
565
Merge médio
18h 52min
PRs com merge (30d)
221

Preparar o ambiente

Abrir no Codespaces

Inicia o contêiner de desenvolvimento do projeto no navegador, com a sua própria conta do GitHub.

  • Inclui um Dockerfile ou arquivo Docker Compose
  • Sem modelo de pull request
  • Sem guia de contribuição

Primeiros passos

  1. Leia a issue inteira e depois o guia de contribuição do projeto.
  2. Comente na issue dizendo que vai assumir — evita que duas pessoas façam o mesmo trabalho.
  3. Faça um fork do repositório e trabalhe em uma branch.
  4. Abra um pull request que referencie o número da issue.

Mais de docker/docker-agent

Todas as issues de docker/docker-agent

Issues semelhantes

Mais issues de Go

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.