Closing a TUI tab leaks its runtime, session and context in --listen mode
I maintainer di solito rispondono entro 1 giorno
@pcbeingused333 ci sta già lavorando.
Dal 14/11/2026.
Valutazione
- Difficoltà
- 4/5
- Tempo stimato
- 3-5 giorni
- Idoneità per principianti
- 35/100
Direzione di ricerca
Read AttachRuntime (pkg/server/session_manager.go around lines 451-463) next to finishSessionDeletion (lines 958-992), since the detach path should mirror the cleanup there. Then check the tab-close flow in Supervisor.CloseSession (pkg/tui/service/supervisor/supervisor.go:308) and the injector registration in cmd/root/run_listen.go:49. Done means a closed tab disappears from GET /api/sessions, its context is cancelled, and the persisted session still exists.
Scritto dal modello di indicizzazione a partire dal testo della issue.
Descrizione
Description
In --listen mode every TUI tab attaches its runtime to the serving session
manager, and there is no detach path. The only code that removes an entry
from runtimeSessions is session deletion
(DeleteSession/BatchDeleteSessions → finishSessionDeletion,
pkg/server/session_manager.go:958-992), while closing a tab goes through
Supervisor.CloseSession (pkg/tui/service/supervisor/supervisor.go:308),
which cancels the TUI-local context and removes the tab from the supervisor
— but is not a session deletion, so none of that cleanup ever runs for a
closed tab.
Per closed tab, the following stay reachable for the life of the process:
- the
runtime.Runtimeandsession.Sessionheld by theactiveRuntimes
entry (session_manager.go:451-463); - the context created by
context.WithCancel(context.WithoutCancel(ctx))
insideAttachRuntime— itscancelis only invoked on session deletion,
so the whole context tree is retained; - the follow-up injector registered at
cmd/root/run_listen.go:49
(sm.RegisterFollowUpInjector(sess.ID, a.InjectUserMessage)), a closure
that keeps the tab's*app.Appreachable; - the recall handler
AttachRuntimeinstalls on the runtime
(session_manager.go:460).
A long-running --listen process that cycles through tabs therefore
accumulates one runtime+session+context set per closed tab, none of it
collectable. A single CLI run is bounded by process exit; the same
unbounded accumulation applies to embedders that attach runtimes to a
serve api session manager.
Expected Behavior
Closing a tab releases what the tab attached to the session manager: the
runtimeSessions entry is removed, its context cancelled, and the follow-up
injector / recall handler dropped — while the persisted session itself stays
(tab close ≠ session delete).
Actual Behavior
Closed tabs keep their runtime, session and context attached until the
process exits. GET /api/sessions keeps listing tabs that were closed,
because GetActiveSessions ranges over runtimeSessions
(session_manager.go:505-510).
Steps to Reproduce
docker-agent run config.yaml --listen 127.0.0.1:8080- In the TUI, open several new tabs (each spawned tab attaches to the
serving manager — see the wiring comment atcmd/root/run_listen.go:31-43) - Close the tabs
curl http://127.0.0.1:8080/api/sessions— every closed tab still shows
up as an active session, and the underlying runtime/session/context are
never released
Docker Agent version
docker-agent version dev Commit: 3c9f6d4
OS & terminal
No response
Model used
No response
Error output
Screenshots
No response
Additional context
Verified on current main (3c9f6d45b): no DetachRuntime exists anywhere
in the tree, and runtimeSessions.Delete has exactly one call site (session
deletion).
Suggested direction: a DetachRuntime(sessionID) symmetric with
AttachRuntime, called from the tab-close path — remove the entry, call
cancel(), and unregister the follow-up injector, recall handler and
event-log references (mirroring finishSessionDeletion's cleanup at
session_manager.go:989-992), leaving the persisted session intact. The
locker AttachRuntime returns carries the #3590 stream-guard contract
(callers hold it across direct RunStream calls), so a detach path must
keep that contract working for still-attached runtimes.
- Lingua principale
- Go
- Stelle
- 4.7k
- Fork
- 565
- Merge medio
- 18h 52m
- PR unite (30g)
- 221
Preparare l'ambiente
Avvia il container di sviluppo del progetto nel browser, con il tuo account GitHub.
- Include un Dockerfile o un file Docker Compose
- Nessun modello di pull request
- Nessuna guida per i contributori
Come iniziare
- Leggi tutta la issue e poi la guida ai contributi del progetto.
- Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
- Fai un fork del repository e lavora su un branch.
- Apri una pull request che faccia riferimento al numero della issue.
Altre issue di docker/docker-agent
-
edit_file diff rendering panics on invalid UTF-8 textForse già presa @TDnorthgarden l’ha presa oggi. Apertaarea/tui
Difficoltà 2/5 1-3 ore Idoneità per principianti 85/100
docker/docker-agent#4955 ·
I maintainer di solito rispondono entro 1 giorno
-
A setting to turn off the models.dev catalog download (offline and strict-network use)Forse già presa @3431481073 l’ha presa 19 giorni fa. Apertaarea/config area/models
Difficoltà 2/5 1-3 ore Idoneità per principianti 72/100
docker/docker-agent#4714 ·
I maintainer di solito rispondono entro 1 giorno
-
Error when trying to run sandbox example?Forse già presa @dgageot l’ha presa 28 giorni fa. Apertaarea/cli
Difficoltà 2/5 1-3 ore Idoneità per principianti 62/100
docker/docker-agent#4672 · 1 commento · 1 reazione · 1 assegnatario ·
I maintainer di solito rispondono entro 1 giorno
-
`edit_file` silently edits the first match when `oldText` occurs more than onceForse già presa @dwin-gharibi l’ha presa 103 giorni fa. Apertaarea/tools
Difficoltà 2/5 1-3 ore Idoneità per principianti 78/100
docker/docker-agent#3929 · 2 commenti ·
I maintainer di solito rispondono entro 1 giorno
-
area/api area/runtime
Difficoltà 4/5 3-5 giorni Idoneità per principianti 48/100
docker/docker-agent#4951 ·
I maintainer di solito rispondono entro 1 giorno
Tutte le issue di docker/docker-agent
Issue simili
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 86/100
fluxcd/notification-controller#1441 ·
I maintainer di solito rispondono entro 1 giorno
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 76/100
OneBusAway/maglev#2145 ·
I maintainer di solito rispondono entro 2 giorni
-
priority/medium status/ready type/chore
Difficoltà 2/5 1-3 ore Idoneità per principianti 84/100
discobox-ai/discobox#1357 ·
I maintainer di solito rispondono entro 1 giorno
-
TestPseudoLocaleRemote fails now and then: it types the code before the laptop asks for itForse già presa @fzn0x l’ha presa oggi. Apertabug priority: low
Difficoltà 2/5 1-3 ore Idoneità per principianti 88/100
I maintainer di solito rispondono entro 1 giorno
-
enhancement ui/ux
Difficoltà 2/5 1-3 ore Idoneità per principianti 68/100
jbigler/railswitch#243 ·
I maintainer di solito rispondono entro 1 giorno