Wire the Incremental Review Path With Full Diff Fallback

Offen
#182 0 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen

Maintainer antworten meist innerhalb von 1 Tag

Dieses Issue hat noch niemand übernommen.

Bewertung

Schwierigkeit
4/5
Geschätzter Aufwand
3-5 Tage
Anfängerfreundlichkeit
55/100
Issue-Typ
Feature
Klarheit
Klar beschrieben
Aktivitätsstatus
Aktiv
Tech-Stack
typescript
Bereich
backend, devtools

Rechercherichtung

Start with packages/core/src/review/phase.ts, then trace how previousCommitSha, getIncrementalDiffFiles, and loadSuppressedFingerprints are provided to the review phase. Add coverage for incremental reviews, missing-SHA fallback, and the setting-off path; the issue names npm run typecheck, npm test, and npm run lint as verification commands. Done means incremental jobs review only the commit-delta files, retain PR context, suppress duplicate findings, and record the reviewed commit range in the job summary.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Beschreibung

enhancement good first issue

Goal

Wire the incremental review path into the review phase (packages/core/src/review/phase.ts) when config.review.incremental === true, including the full-diff fallback.

Background

This sub-issue connects the earlier pieces: the review.incremental setting, the resolved previousCommitSha, and getIncrementalDiffFiles. When the setting is on and a previous SHA exists, the LLM review runs only on the incremental file set. Otherwise the review falls back to the current full PR diff.

This sub-issue is part of the parent issue: incremental reviews on synchronize events.

What to Build

  • In the review phase, branch on config.review.incremental and the presence of previousCommitSha
  • When incremental: use getIncrementalDiffFiles and run LLM review only on those files
  • Retain PR-level context (title, description) for the review prompt and summary
  • Continue to suppress already-flagged findings via the existing loadSuppressedFingerprints mechanism so duplicate comments are not re-posted
  • Fall back to the full PR diff when previousCommitSha is missing (first push, or superseded prior job)
  • Update the job summary to note that the review was incremental and which commit range was reviewed

Done When

  • review.incremental: true with a valid previous SHA reviews only the commit-delta files
  • Missing previous SHA falls back gracefully to the full PR diff
  • Suppressed findings are not re-posted on incremental reviews
  • Job summary records the reviewed commit range for incremental jobs
  • Existing full reviews (auto-triggered and mention-triggered) are unchanged when the setting is off
  • Tests cover the incremental path, the fallback, and the off-by-default behavior
  • npm run typecheck, npm test, and npm run lint all pass
Vorherrschende Sprache
TypeScript
Sterne
125
Forks
23
Ø Merge
2 T. 13 Std.
Gemergte PRs (30 T.)
12

Entwicklungsumgebung

Erste Schritte

  1. Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
  2. Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
  3. Forken Sie das Repository und arbeiten Sie in einem Branch.
  4. Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.

Mehr aus devarshishimpi/codra

Alle Issues in devarshishimpi/codra

Ähnliche Issues

Weitere Issues zu TypeScript

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.