Wire the Incremental Review Path With Full Diff Fallback

Ouverte
#182 0 commentaires 0 réactions 0 personnes assignées Voir sur GitHub

Les mainteneurs répondent en général sous 1 jour

Personne n'a encore pris cette issue.

Évaluation

Difficulté
4/5
Temps estimé
3-5 jours
Accessibilité débutants
55/100
Type d'issue
Fonctionnalité
Clarté
Clairement spécifiée
Activité
Active
Stack technique
typescript
Domaine
backend, devtools

Piste de recherche

Start with packages/core/src/review/phase.ts, then trace how previousCommitSha, getIncrementalDiffFiles, and loadSuppressedFingerprints are provided to the review phase. Add coverage for incremental reviews, missing-SHA fallback, and the setting-off path; the issue names npm run typecheck, npm test, and npm run lint as verification commands. Done means incremental jobs review only the commit-delta files, retain PR context, suppress duplicate findings, and record the reviewed commit range in the job summary.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Description

enhancement good first issue

Goal

Wire the incremental review path into the review phase (packages/core/src/review/phase.ts) when config.review.incremental === true, including the full-diff fallback.

Background

This sub-issue connects the earlier pieces: the review.incremental setting, the resolved previousCommitSha, and getIncrementalDiffFiles. When the setting is on and a previous SHA exists, the LLM review runs only on the incremental file set. Otherwise the review falls back to the current full PR diff.

This sub-issue is part of the parent issue: incremental reviews on synchronize events.

What to Build

  • In the review phase, branch on config.review.incremental and the presence of previousCommitSha
  • When incremental: use getIncrementalDiffFiles and run LLM review only on those files
  • Retain PR-level context (title, description) for the review prompt and summary
  • Continue to suppress already-flagged findings via the existing loadSuppressedFingerprints mechanism so duplicate comments are not re-posted
  • Fall back to the full PR diff when previousCommitSha is missing (first push, or superseded prior job)
  • Update the job summary to note that the review was incremental and which commit range was reviewed

Done When

  • review.incremental: true with a valid previous SHA reviews only the commit-delta files
  • Missing previous SHA falls back gracefully to the full PR diff
  • Suppressed findings are not re-posted on incremental reviews
  • Job summary records the reviewed commit range for incremental jobs
  • Existing full reviews (auto-triggered and mention-triggered) are unchanged when the setting is off
  • Tests cover the incremental path, the fallback, and the off-by-default behavior
  • npm run typecheck, npm test, and npm run lint all pass
Langage dominant
TypeScript
Étoiles
125
Forks
23
Merge moyen
2 j 13 h
PR mergées (30 j)
12

Préparer son environnement

Par où commencer

  1. Lisez l'issue en entier, puis le guide de contribution du projet.
  2. Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
  3. Forkez le dépôt et travaillez sur une branche.
  4. Ouvrez une pull request qui référence le numéro de l'issue.

Autres issues de devarshishimpi/codra

Toutes les issues de devarshishimpi/codra

Issues similaires

Plus d'issues TypeScript

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.