Wire the Incremental Review Path With Full Diff Fallback
维护者通常 1 天内回复
还没有人认领这个 Issue。
评估
- 难度
- 4/5
- 预计耗时
- 3-5 天
- 新手友好度
- 55/100
- Issue 类型
- 功能
- 描述清晰度
- 描述清楚
- 活跃度
- 活跃
- 技术栈
- typescript
调研方向
Start with packages/core/src/review/phase.ts, then trace how previousCommitSha, getIncrementalDiffFiles, and loadSuppressedFingerprints are provided to the review phase. Add coverage for incremental reviews, missing-SHA fallback, and the setting-off path; the issue names npm run typecheck, npm test, and npm run lint as verification commands. Done means incremental jobs review only the commit-delta files, retain PR context, suppress duplicate findings, and record the reviewed commit range in the job summary.
由索引模型根据 Issue 内容生成。
描述
Goal
Wire the incremental review path into the review phase (packages/core/src/review/phase.ts) when config.review.incremental === true, including the full-diff fallback.
Background
This sub-issue connects the earlier pieces: the review.incremental setting, the resolved previousCommitSha, and getIncrementalDiffFiles. When the setting is on and a previous SHA exists, the LLM review runs only on the incremental file set. Otherwise the review falls back to the current full PR diff.
This sub-issue is part of the parent issue: incremental reviews on synchronize events.
What to Build
- In the review phase, branch on
config.review.incrementaland the presence ofpreviousCommitSha - When incremental: use
getIncrementalDiffFilesand run LLM review only on those files - Retain PR-level context (title, description) for the review prompt and summary
- Continue to suppress already-flagged findings via the existing
loadSuppressedFingerprintsmechanism so duplicate comments are not re-posted - Fall back to the full PR diff when
previousCommitShais missing (first push, or superseded prior job) - Update the job summary to note that the review was incremental and which commit range was reviewed
Done When
-
review.incremental: truewith a valid previous SHA reviews only the commit-delta files - Missing previous SHA falls back gracefully to the full PR diff
- Suppressed findings are not re-posted on incremental reviews
- Job summary records the reviewed commit range for incremental jobs
- Existing full reviews (auto-triggered and mention-triggered) are unchanged when the setting is off
- Tests cover the incremental path, the fallback, and the off-by-default behavior
-
npm run typecheck,npm test, andnpm run lintall pass
- 主要语言
- TypeScript
- 星标
- 125
- 派生
- 23
- 平均合并
- 2 天 13 小时
- 30 天内合并 PR
- 12
环境准备
- 提供 Dockerfile 或 Docker Compose 文件
- 有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
devarshishimpi/codra 的其他 Issue
-
bug good first issue
难度 2/5 1-3 小时 新手友好度 84/100
devarshishimpi/codra#178 ·
维护者通常 1 天内回复
-
bug good first issue
难度 2/5 1-3 小时 新手友好度 78/100
devarshishimpi/codra#176 ·
维护者通常 1 天内回复
-
enhancement good first issue
难度 4/5 3-5 天 新手友好度 48/100
devarshishimpi/codra#186 ·
维护者通常 1 天内回复
-
enhancement good first issue
难度 4/5 3-5 天 新手友好度 55/100
devarshishimpi/codra#185 ·
维护者通常 1 天内回复
-
enhancement good first issue
难度 4/5 3-5 天 新手友好度 58/100
devarshishimpi/codra#184 ·
维护者通常 1 天内回复
查看 devarshishimpi/codra 的全部 Issue
相似的 Issue
-
难度 1/5 1-3 小时 新手友好度 83/100
gofish-graphics/gofish-graphics#1384 ·
维护者通常 1 天内回复
-
adapter bug
难度 2/5 1-3 小时 新手友好度 83/100
Olanetsoft/agent-lookout#353 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 68/100
vicharanashala/vibe#1542 ·
维护者通常 1 天内回复
-
bug chore P2 size:XS
难度 2/5 1-3 小时 新手友好度 77/100
josephfung/curia#2666 ·
维护者通常 1 天内回复
-
area: batch
难度 2/5 1-3 小时 新手友好度 75/100
inabagumi/shinju-date#7294 ·
维护者通常 1 天内回复