Wire the Incremental Review Path With Full Diff Fallback

Abierto
#182 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
4/5
Tiempo estimado
3-5 días
Aptitud para principiantes
55/100
Tipo de issue
Nueva funcionalidad
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
typescript
Área
backend, devtools

Línea de trabajo

Start with packages/core/src/review/phase.ts, then trace how previousCommitSha, getIncrementalDiffFiles, and loadSuppressedFingerprints are provided to the review phase. Add coverage for incremental reviews, missing-SHA fallback, and the setting-off path; the issue names npm run typecheck, npm test, and npm run lint as verification commands. Done means incremental jobs review only the commit-delta files, retain PR context, suppress duplicate findings, and record the reviewed commit range in the job summary.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

enhancement good first issue

Goal

Wire the incremental review path into the review phase (packages/core/src/review/phase.ts) when config.review.incremental === true, including the full-diff fallback.

Background

This sub-issue connects the earlier pieces: the review.incremental setting, the resolved previousCommitSha, and getIncrementalDiffFiles. When the setting is on and a previous SHA exists, the LLM review runs only on the incremental file set. Otherwise the review falls back to the current full PR diff.

This sub-issue is part of the parent issue: incremental reviews on synchronize events.

What to Build

  • In the review phase, branch on config.review.incremental and the presence of previousCommitSha
  • When incremental: use getIncrementalDiffFiles and run LLM review only on those files
  • Retain PR-level context (title, description) for the review prompt and summary
  • Continue to suppress already-flagged findings via the existing loadSuppressedFingerprints mechanism so duplicate comments are not re-posted
  • Fall back to the full PR diff when previousCommitSha is missing (first push, or superseded prior job)
  • Update the job summary to note that the review was incremental and which commit range was reviewed

Done When

  • review.incremental: true with a valid previous SHA reviews only the commit-delta files
  • Missing previous SHA falls back gracefully to the full PR diff
  • Suppressed findings are not re-posted on incremental reviews
  • Job summary records the reviewed commit range for incremental jobs
  • Existing full reviews (auto-triggered and mention-triggered) are unchanged when the setting is off
  • Tests cover the incremental path, the fallback, and the off-by-default behavior
  • npm run typecheck, npm test, and npm run lint all pass
Lenguaje dominante
TypeScript
Estrellas
125
Forks
23
Merge medio
2 d 13 h
PR fusionados (30 d)
12

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de devarshishimpi/codra

Todos los issues de devarshishimpi/codra

Issues similares

Más issues de TypeScript

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.