Fix few issues into release-candidate branch, with now the branch not contains

Offen
  • Stimmt etwas nicht?
#889 2 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen

Maintainer antworten meist innerhalb von 1 Tag

Dieses Issue hat noch niemand übernommen.

Bewertung

Schwierigkeit
4/5
Geschätzter Aufwand
3-5 Tage
Anfängerfreundlichkeit
25/100
Issue-Typ
Bug
Klarheit
Größtenteils klar
Aktivitätsstatus
Aktiv
Tech-Stack
rust, yaml
Bereich
internationalization, testing

Rechercherichtung

Review the three attached patches and compare their changes with the release-candidate and main branches. Start with Rules/Languages/en/unicode-full.yaml and Rules/Languages/hu/navigate.yaml, then inspect tests/languages/hu/navigate.rs and tests/Language/hu/mtable.rs. Confirm which changes fit the release-candidate policy and whether they preserve the reported Hungarian translation fixes and tests.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Beschreibung

discussion rules translation

Hi Boys,

@NSoiffer, @moritz-gross, I doed three release-candidate branch compatible patches, with do all wanted fixes to release-candidate branch contains the latest good hungarian translations, similar with main branch.
I fixed following things:

  • Fixing unwanted duplicates with Rules/Languages/en/unicode-full.yaml file,
  • Added october 6 merged Rules/Languages/hu/navigate.yaml change (without test code files, if the test file code modifications is not fitting the release-candidate branch policy),
  • Create a patch with applying tests/languages/hu/navigate.rs new test, similar with main branch, and add new row separator and column separator related tests in tests/Language/hu/mtable.rs file.
    Because me not have possibility to open a PR with release-candidate branch target branch, I attaching both three patches. Please merge selective this changes to the release-candidate branch, depending with the release-candidate branch policy.
    I don't no when coming out the next MathCAT stable release (I seeing the 0.7.7 release is comed out yesterday, congratulate the new release).
    I would like only to land this new october merged translation fixes are landing the new stable release in future. :-):-)
    Me full good if you merging only the two yaml files related patches to the release-candidate branch, if Rust test files code modification or new test file code file creation is not enabled into RC state.

I attaching the three patches:
fix_unwanted_unicode_duplicates.patch
fix_navigate_translations.patch

add_navigate_and_mtable_row_separator_tests.patch

Hopefully any I this day doed change are you merging the upstream release-candidate branch. Me translator audit tool now shows good results, similar with main branch, and all 637 hungarian tests are right passed my local system, similar with main branch.
So, if you merging for example the two yaml files related two patches, the hungarian main branch awailable MathCAT translations and release-candidate branch translations are equals good, equals the october 6 fixed state.

I wish for you a good weekend, and very congratulate the new MathCAT 7.7 stable release.

Attila

Vorherrschende Sprache
Rust
Sterne
130
Forks
96
Ø Merge
22 Std. 13 Min.
Gemergte PRs (30 T.)
87

Entwicklungsumgebung

Erste Schritte

  1. Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
  2. Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
  3. Forken Sie das Repository und arbeiten Sie in einem Branch.
  4. Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.

Mehr aus daisy/MathCAT

Alle Issues in daisy/MathCAT

Ähnliche Issues

Weitere Issues zu Rust

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.