Fix few issues into release-candidate branch, with now the branch not contains

未关闭
#889 2 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
4/5
预计耗时
3-5 天
新手友好度
25/100
Issue 类型
缺陷
描述清晰度
基本清楚
活跃度
活跃
技术栈
rust, yaml

调研方向

Review the three attached patches and compare their changes with the release-candidate and main branches. Start with Rules/Languages/en/unicode-full.yaml and Rules/Languages/hu/navigate.yaml, then inspect tests/languages/hu/navigate.rs and tests/Language/hu/mtable.rs. Confirm which changes fit the release-candidate policy and whether they preserve the reported Hungarian translation fixes and tests.

由索引模型根据 Issue 内容生成。

描述

discussion rules translation

Hi Boys,

@NSoiffer, @moritz-gross, I doed three release-candidate branch compatible patches, with do all wanted fixes to release-candidate branch contains the latest good hungarian translations, similar with main branch.
I fixed following things:

  • Fixing unwanted duplicates with Rules/Languages/en/unicode-full.yaml file,
  • Added october 6 merged Rules/Languages/hu/navigate.yaml change (without test code files, if the test file code modifications is not fitting the release-candidate branch policy),
  • Create a patch with applying tests/languages/hu/navigate.rs new test, similar with main branch, and add new row separator and column separator related tests in tests/Language/hu/mtable.rs file.
    Because me not have possibility to open a PR with release-candidate branch target branch, I attaching both three patches. Please merge selective this changes to the release-candidate branch, depending with the release-candidate branch policy.
    I don't no when coming out the next MathCAT stable release (I seeing the 0.7.7 release is comed out yesterday, congratulate the new release).
    I would like only to land this new october merged translation fixes are landing the new stable release in future. :-):-)
    Me full good if you merging only the two yaml files related patches to the release-candidate branch, if Rust test files code modification or new test file code file creation is not enabled into RC state.

I attaching the three patches:
fix_unwanted_unicode_duplicates.patch
fix_navigate_translations.patch

add_navigate_and_mtable_row_separator_tests.patch

Hopefully any I this day doed change are you merging the upstream release-candidate branch. Me translator audit tool now shows good results, similar with main branch, and all 637 hungarian tests are right passed my local system, similar with main branch.
So, if you merging for example the two yaml files related two patches, the hungarian main branch awailable MathCAT translations and release-candidate branch translations are equals good, equals the october 6 fixed state.

I wish for you a good weekend, and very congratulate the new MathCAT 7.7 stable release.

Attila

主要语言
Rust
星标
130
派生
96
平均合并
1 天 1 小时
30 天内合并 PR
84

环境准备

  • 没有 Dockerfile 或 Docker Compose 文件
  • 没有 Pull Request 模板
  • 阅读贡献指南

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

daisy/MathCAT 的其他 Issue

查看 daisy/MathCAT 的全部 Issue

相似的 Issue

更多 Rust Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。