Fix few issues into release-candidate branch, with now the branch not contains

Aperta
  • Qualcosa non va?
#889 2 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
4/5
Tempo stimato
3-5 giorni
Idoneità per principianti
25/100
Tipo di issue
Bug
Chiarezza
Abbastanza chiara
Stato di attività
Attiva
Stack tecnologico
rust, yaml
Ambito
internationalization, testing

Direzione di ricerca

Review the three attached patches and compare their changes with the release-candidate and main branches. Start with Rules/Languages/en/unicode-full.yaml and Rules/Languages/hu/navigate.yaml, then inspect tests/languages/hu/navigate.rs and tests/Language/hu/mtable.rs. Confirm which changes fit the release-candidate policy and whether they preserve the reported Hungarian translation fixes and tests.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

discussion rules translation

Hi Boys,

@NSoiffer, @moritz-gross, I doed three release-candidate branch compatible patches, with do all wanted fixes to release-candidate branch contains the latest good hungarian translations, similar with main branch.
I fixed following things:

  • Fixing unwanted duplicates with Rules/Languages/en/unicode-full.yaml file,
  • Added october 6 merged Rules/Languages/hu/navigate.yaml change (without test code files, if the test file code modifications is not fitting the release-candidate branch policy),
  • Create a patch with applying tests/languages/hu/navigate.rs new test, similar with main branch, and add new row separator and column separator related tests in tests/Language/hu/mtable.rs file.
    Because me not have possibility to open a PR with release-candidate branch target branch, I attaching both three patches. Please merge selective this changes to the release-candidate branch, depending with the release-candidate branch policy.
    I don't no when coming out the next MathCAT stable release (I seeing the 0.7.7 release is comed out yesterday, congratulate the new release).
    I would like only to land this new october merged translation fixes are landing the new stable release in future. :-):-)
    Me full good if you merging only the two yaml files related patches to the release-candidate branch, if Rust test files code modification or new test file code file creation is not enabled into RC state.

I attaching the three patches:
fix_unwanted_unicode_duplicates.patch
fix_navigate_translations.patch

add_navigate_and_mtable_row_separator_tests.patch

Hopefully any I this day doed change are you merging the upstream release-candidate branch. Me translator audit tool now shows good results, similar with main branch, and all 637 hungarian tests are right passed my local system, similar with main branch.
So, if you merging for example the two yaml files related two patches, the hungarian main branch awailable MathCAT translations and release-candidate branch translations are equals good, equals the october 6 fixed state.

I wish for you a good weekend, and very congratulate the new MathCAT 7.7 stable release.

Attila

Lingua principale
Rust
Stelle
130
Fork
96
Merge medio
1g 1h
PR unite (30g)
84

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di daisy/MathCAT

Tutte le issue di daisy/MathCAT

Issue simili

Altre issue su Rust

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.