Fix few issues into release-candidate branch, with now the branch not contains

Abierto
  • ¿Algo no está bien?
#889 2 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
4/5
Tiempo estimado
3-5 días
Aptitud para principiantes
25/100
Tipo de issue
Error
Claridad
Bastante claro
Estado de actividad
Activo
Stack tecnológico
rust, yaml
Área
internationalization, testing

Línea de trabajo

Review the three attached patches and compare their changes with the release-candidate and main branches. Start with Rules/Languages/en/unicode-full.yaml and Rules/Languages/hu/navigate.yaml, then inspect tests/languages/hu/navigate.rs and tests/Language/hu/mtable.rs. Confirm which changes fit the release-candidate policy and whether they preserve the reported Hungarian translation fixes and tests.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

discussion rules translation

Hi Boys,

@NSoiffer, @moritz-gross, I doed three release-candidate branch compatible patches, with do all wanted fixes to release-candidate branch contains the latest good hungarian translations, similar with main branch.
I fixed following things:

  • Fixing unwanted duplicates with Rules/Languages/en/unicode-full.yaml file,
  • Added october 6 merged Rules/Languages/hu/navigate.yaml change (without test code files, if the test file code modifications is not fitting the release-candidate branch policy),
  • Create a patch with applying tests/languages/hu/navigate.rs new test, similar with main branch, and add new row separator and column separator related tests in tests/Language/hu/mtable.rs file.
    Because me not have possibility to open a PR with release-candidate branch target branch, I attaching both three patches. Please merge selective this changes to the release-candidate branch, depending with the release-candidate branch policy.
    I don't no when coming out the next MathCAT stable release (I seeing the 0.7.7 release is comed out yesterday, congratulate the new release).
    I would like only to land this new october merged translation fixes are landing the new stable release in future. :-):-)
    Me full good if you merging only the two yaml files related patches to the release-candidate branch, if Rust test files code modification or new test file code file creation is not enabled into RC state.

I attaching the three patches:
fix_unwanted_unicode_duplicates.patch
fix_navigate_translations.patch

add_navigate_and_mtable_row_separator_tests.patch

Hopefully any I this day doed change are you merging the upstream release-candidate branch. Me translator audit tool now shows good results, similar with main branch, and all 637 hungarian tests are right passed my local system, similar with main branch.
So, if you merging for example the two yaml files related two patches, the hungarian main branch awailable MathCAT translations and release-candidate branch translations are equals good, equals the october 6 fixed state.

I wish for you a good weekend, and very congratulate the new MathCAT 7.7 stable release.

Attila

Lenguaje dominante
Rust
Estrellas
130
Forks
96
Merge medio
1 d 1 h
PR fusionados (30 d)
84

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de daisy/MathCAT

Todos los issues de daisy/MathCAT

Issues similares

Más issues de Rust

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.