Hacktoberfest 2026: die Issues, die Maintainer für den Oktober markiert haben – offen und einsteigerfreundlich. Hacktoberfest-Issues durchsuchen

adb: mark every host refusal as `hostRefusal` and derive `dispatched: "no"` from it

Offen
  • Stimmt etwas nicht?
#3,075 0 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen

Maintainer antworten meist innerhalb von 1 Tag

Dieses Issue hat noch niemand übernommen.

Bewertung

Schwierigkeit
4/5
Geschätzter Aufwand
3-5 Tage
Anfängerfreundlichkeit
68/100
Issue-Typ
Bug
Klarheit
Klar beschrieben
Aktivitätsstatus
Aktiv
Tech-Stack
android, typescript
Bereich
mobile, testing

Rechercherichtung

Start with packages/platform-android/src/adb-failure.ts and input-actions.ts, then inspect contracts/fixtures/dispatch-disclosure.json and the Android driver tests. Run the relevant adb-failure and dispatch-disclosure tests to trace attachAdbFailureHint through the real executor. Done means all six host refusals are classified, disclosure reports dispatched: "no" when appropriate, and pnpm check:affected --run passes.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Beschreibung

needs-triage

Part of #3069.

Purpose

#3055 adds hostRefusal: true to the device_offline classification in packages/platform-android/src/adb-failure.ts, meaning the host adb refused the command before it reached the device. Five other reasons in the same matcher table are host refusals too and carry no flag: device_unauthorized, multiple_devices, no_devices, device_not_found, server_version_mismatch. On the dispatched branch, discloseAdbInputDispatch in input-actions.ts says no only for TOOL_MISSING, so an input tap refused for an unauthorized device reads unknown today.

Required behavior

  • Each host-refusal reason in ANDROID_ADB_FAILURE_MATCHERS carries hostRefusal: true. A reason that can also come from a command that ran on the device (install_*, connection_dropped, timeout) does not.
  • attachAdbFailureHint keeps stamping details.adbHostRefusal.
  • discloseAdbInputDispatch and the helper-session producers say dispatched: "no" when adbHostRefusal === true and no earlier step was dispatched (dispatchedSteps === 0). The classifier is the single source; no second string match.
  • One row per host refusal in contracts/fixtures/dispatch-disclosure.json, each driven through attachAdbFailureHint and the real executor.

Completion conditions

  • adb-failure.test.ts asserts hostRefusal for the six reasons and its absence for the rest.
  • The dispatch-disclosure gate passes with the new rows owned by the Android driver test.
  • pnpm check:affected --run passes.

Dependencies

Blocked by: #3055 (introduces hostRefusal) and #3071 (introduces the table).

Vorherrschende Sprache
TypeScript
Sterne
4.8k
Forks
315
Ø Merge
11 Std. 27 Min.
Gemergte PRs (30 T.)
556

Entwicklungsumgebung

Erste Schritte

  1. Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
  2. Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
  3. Forken Sie das Repository und arbeiten Sie in einem Branch.
  4. Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.

Mehr aus callstack/agent-device

Alle Issues in callstack/agent-device

Ähnliche Issues

Weitere Issues zu TypeScript

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.