Hacktoberfest 2026: los issues que los mantenedores marcaron para octubre, abiertos y aptos para principiantes. Explorar issues de Hacktoberfest

adb: mark every host refusal as `hostRefusal` and derive `dispatched: "no"` from it

Abierto
  • ¿Algo no está bien?
#3,075 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
4/5
Tiempo estimado
3-5 días
Aptitud para principiantes
68/100
Tipo de issue
Error
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
android, typescript
Área
mobile, testing

Línea de trabajo

Start with packages/platform-android/src/adb-failure.ts and input-actions.ts, then inspect contracts/fixtures/dispatch-disclosure.json and the Android driver tests. Run the relevant adb-failure and dispatch-disclosure tests to trace attachAdbFailureHint through the real executor. Done means all six host refusals are classified, disclosure reports dispatched: "no" when appropriate, and pnpm check:affected --run passes.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

needs-triage

Part of #3069.

Purpose

#3055 adds hostRefusal: true to the device_offline classification in packages/platform-android/src/adb-failure.ts, meaning the host adb refused the command before it reached the device. Five other reasons in the same matcher table are host refusals too and carry no flag: device_unauthorized, multiple_devices, no_devices, device_not_found, server_version_mismatch. On the dispatched branch, discloseAdbInputDispatch in input-actions.ts says no only for TOOL_MISSING, so an input tap refused for an unauthorized device reads unknown today.

Required behavior

  • Each host-refusal reason in ANDROID_ADB_FAILURE_MATCHERS carries hostRefusal: true. A reason that can also come from a command that ran on the device (install_*, connection_dropped, timeout) does not.
  • attachAdbFailureHint keeps stamping details.adbHostRefusal.
  • discloseAdbInputDispatch and the helper-session producers say dispatched: "no" when adbHostRefusal === true and no earlier step was dispatched (dispatchedSteps === 0). The classifier is the single source; no second string match.
  • One row per host refusal in contracts/fixtures/dispatch-disclosure.json, each driven through attachAdbFailureHint and the real executor.

Completion conditions

  • adb-failure.test.ts asserts hostRefusal for the six reasons and its absence for the rest.
  • The dispatch-disclosure gate passes with the new rows owned by the Android driver test.
  • pnpm check:affected --run passes.

Dependencies

Blocked by: #3055 (introduces hostRefusal) and #3071 (introduces the table).

Lenguaje dominante
TypeScript
Estrellas
4.8k
Forks
315
Merge medio
11 h 27 min
PR fusionados (30 d)
556

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de callstack/agent-device

Todos los issues de callstack/agent-device

Issues similares

Más issues de TypeScript

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.