Hacktoberfest 2026: le issue che i maintainer hanno segnato per ottobre, aperte e adatte ai principianti. Sfoglia le issue Hacktoberfest

adb: mark every host refusal as `hostRefusal` and derive `dispatched: "no"` from it

Aperta
  • Qualcosa non va?
#3,075 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
4/5
Tempo stimato
3-5 giorni
Idoneità per principianti
68/100
Tipo di issue
Bug
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
android, typescript
Ambito
mobile, testing

Direzione di ricerca

Start with packages/platform-android/src/adb-failure.ts and input-actions.ts, then inspect contracts/fixtures/dispatch-disclosure.json and the Android driver tests. Run the relevant adb-failure and dispatch-disclosure tests to trace attachAdbFailureHint through the real executor. Done means all six host refusals are classified, disclosure reports dispatched: "no" when appropriate, and pnpm check:affected --run passes.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

needs-triage

Part of #3069.

Purpose

#3055 adds hostRefusal: true to the device_offline classification in packages/platform-android/src/adb-failure.ts, meaning the host adb refused the command before it reached the device. Five other reasons in the same matcher table are host refusals too and carry no flag: device_unauthorized, multiple_devices, no_devices, device_not_found, server_version_mismatch. On the dispatched branch, discloseAdbInputDispatch in input-actions.ts says no only for TOOL_MISSING, so an input tap refused for an unauthorized device reads unknown today.

Required behavior

  • Each host-refusal reason in ANDROID_ADB_FAILURE_MATCHERS carries hostRefusal: true. A reason that can also come from a command that ran on the device (install_*, connection_dropped, timeout) does not.
  • attachAdbFailureHint keeps stamping details.adbHostRefusal.
  • discloseAdbInputDispatch and the helper-session producers say dispatched: "no" when adbHostRefusal === true and no earlier step was dispatched (dispatchedSteps === 0). The classifier is the single source; no second string match.
  • One row per host refusal in contracts/fixtures/dispatch-disclosure.json, each driven through attachAdbFailureHint and the real executor.

Completion conditions

  • adb-failure.test.ts asserts hostRefusal for the six reasons and its absence for the rest.
  • The dispatch-disclosure gate passes with the new rows owned by the Android driver test.
  • pnpm check:affected --run passes.

Dependencies

Blocked by: #3055 (introduces hostRefusal) and #3071 (introduces the table).

Lingua principale
TypeScript
Stelle
4.8k
Fork
315
Merge medio
11h 27m
PR unite (30g)
556

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di callstack/agent-device

Tutte le issue di callstack/agent-device

Issue simili

Altre issue su TypeScript

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.