MPP: credential is always sent in Authorization, ignoring header="Payment-Authorization" in the challenge

Offen Anfängerfreundlich
#702 0 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen

Maintainer antworten meist innerhalb von 1 Tag

@abhiramshaji-cyber arbeitet bereits daran.

Seit 27.10.2026.

  • #719 von @abhiramshaji-cyber — offen

Bewertung

Schwierigkeit
2/5
Geschätzter Aufwand
1-3 Stunden
Anfängerfreundlichkeit
68/100
Issue-Typ
Bug
Klarheit
Klar beschrieben
Aktivitätsstatus
Aktiv
Tech-Stack
python
Bereich
api, backend

Rechercherichtung

Beginne in bedrock_agentcore/payments/manager.py bei PaymentManager._generate_mpp_payment_header und verfolge, wie der ausgewählte Challenge-Header generate_payment_header erreicht. Prüfe, wie der Strands-Handler und die LangGraph-Middleware zurückgegebene Header anwenden, und füge gezielte Tests für Payment-Authorization und das standardmäßige Verhalten von Authorization hinzu oder führe sie aus. Fertig ist die Aufgabe, wenn der ausgewählte Header die Zugangsdaten enthält und ein vorhandener Authorization-Wert des Aufrufers erhalten bleibt.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Beschreibung

bug

Describe the bug

The MPP core spec lets a challenge choose the request header for the credential. With header="Payment-Authorization", the client must send the credential in Payment-Authorization, so that Authorization stays free for the client's own authentication (draft-httpauth-payment-01, section "Credentials"). The server accepts the credential only from the selected field, and a client that does not support Payment-Authorization must not send a credential for such a challenge.

PaymentManager._generate_mpp_payment_header always returns {"Authorization": "Payment <credential>"}, whatever the selected challenge says. For a challenge with header="Payment-Authorization", the SDK:

  • pays it (ProcessPayment is called);
  • returns the credential under Authorization, where the server does not look for it;
  • replaces the caller's own Authorization value (for example a Bearer token) when the Strands plugin or the LangGraph middleware applies the header to the retried request (apply_payment_header updates the headers dict).

mppx servers send this parameter when created with Mppx.create({ requiresAuth: true, ... }) (added in mppx 0.9.0), and then read the credential only from Payment-Authorization.

To Reproduce

bedrock-agentcore 1.24.1 (main at b70e0b7), Python 3.10:

import base64
import json
from unittest.mock import MagicMock, patch

from bedrock_agentcore.payments.integrations.handlers import GenericPaymentHandler
from bedrock_agentcore.payments.manager import PaymentManager

request = {
    "amount": "1000",
    "currency": "0x036CbD53842c5426634e7929541eC2318f3dCF71",
    "recipient": "0x742d35Cc6634C0532925a3b844Bc9e7595f8fE00",
    "methodDetails": {"chainId": 84532},
}
encoded = base64.urlsafe_b64encode(json.dumps(request, separators=(",", ":")).encode()).decode().rstrip("=")
challenge = (
    f'Payment id="x7Tg2pLqR9mKvNwY3hBcZa", realm="api.example.com", method="evm", intent="charge", '
    f'header="Payment-Authorization", request="{encoded}"'
)

with patch("boto3.Session") as session:
    session.return_value.region_name = "us-west-2"
    manager = PaymentManager(
        payment_manager_arn="arn:aws:bedrock-agentcore:us-west-2:123456789012:payment-manager/pm-abc123",
        region_name="us-west-2",
    )
manager._payment_client = MagicMock()
manager._payment_client.get_payment_instrument.return_value = {
    "paymentInstrument": {"paymentInstrumentDetails": {"embeddedCryptoWallet": {"network": "ETHEREUM"}}}
}
manager._payment_client.process_payment.return_value = {
    "processPayment": {
        "status": "PROOF_GENERATED",
        "paymentOutput": {"mpp": {"selectedPaymentId": "x7Tg2pLqR9mKvNwY3hBcZa", "paymentCredential": "eyJ0b2tlbiI6MX0"}},
    }
}

payment_header = manager.generate_payment_header(
    user_id="user-1",
    payment_instrument_id="pi-1",
    payment_session_id="ps-1",
    payment_required_request={"statusCode": 402, "headers": {"WWW-Authenticate": challenge}, "body": {}},
)
print("ProcessPayment calls:", manager._payment_client.process_payment.call_count)
print("payment header:", payment_header)

tool_input = {"url": "https://api.example.com/resource", "headers": {"Authorization": "Bearer mF_9.B5f-4.1JqM"}}
GenericPaymentHandler().apply_payment_header(tool_input, payment_header)
print("retried request headers:", tool_input["headers"])

Output:

ProcessPayment calls: 1
payment header: {'Authorization': 'Payment eyJ0b2tlbiI6MX0'}
retried request headers: {'Authorization': 'Payment eyJ0b2tlbiI6MX0'}

Expected behavior

For a challenge with header="Payment-Authorization", generate_payment_header returns {"Payment-Authorization": "Payment <credential>"}, and the retried request keeps its own Authorization header. A challenge without header keeps using Authorization, as now. Until the field is supported, such a challenge should not be selected or paid.

Additional context

  • The parameter was added to the spec in tempoxyz/mpp-specs#328 (2026-08-25), a week after MPP support landed here in #643 (2026-08-18).
  • The spec also asks the client to echo header in the credential's challenge object. The raw challenge, including header, is already forwarded to ProcessPayment, so that part may be handled by the service; I could not check it.
Vorherrschende Sprache
Python
Sterne
786
Forks
163
Ø Merge
4 Std.
Gemergte PRs (30 T.)
22

Entwicklungsumgebung

Erste Schritte

  1. Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
  2. Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
  3. Forken Sie das Repository und arbeiten Sie in einem Branch.
  4. Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.

Mehr aus aws/bedrock-agentcore-sdk-python

Alle Issues in aws/bedrock-agentcore-sdk-python

Ähnliche Issues

Weitere Issues zu Python

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.