MPP: credential is always sent in Authorization, ignoring header="Payment-Authorization" in the challenge
Maintainer antworten meist innerhalb von 1 Tag
Bewertung
- Schwierigkeit
- 2/5
- Geschätzter Aufwand
- 1-3 Stunden
- Anfängerfreundlichkeit
- 68/100
Rechercherichtung
Beginne in bedrock_agentcore/payments/manager.py bei PaymentManager._generate_mpp_payment_header und verfolge, wie der ausgewählte Challenge-Header generate_payment_header erreicht. Prüfe, wie der Strands-Handler und die LangGraph-Middleware zurückgegebene Header anwenden, und füge gezielte Tests für Payment-Authorization und das standardmäßige Verhalten von Authorization hinzu oder führe sie aus. Fertig ist die Aufgabe, wenn der ausgewählte Header die Zugangsdaten enthält und ein vorhandener Authorization-Wert des Aufrufers erhalten bleibt.
Vom Indexierungsmodell aus dem Issue-Text verfasst.
Beschreibung
Describe the bug
The MPP core spec lets a challenge choose the request header for the credential. With header="Payment-Authorization", the client must send the credential in Payment-Authorization, so that Authorization stays free for the client's own authentication (draft-httpauth-payment-01, section "Credentials"). The server accepts the credential only from the selected field, and a client that does not support Payment-Authorization must not send a credential for such a challenge.
PaymentManager._generate_mpp_payment_header always returns {"Authorization": "Payment <credential>"}, whatever the selected challenge says. For a challenge with header="Payment-Authorization", the SDK:
- pays it (
ProcessPaymentis called); - returns the credential under
Authorization, where the server does not look for it; - replaces the caller's own
Authorizationvalue (for example a Bearer token) when the Strands plugin or the LangGraph middleware applies the header to the retried request (apply_payment_headerupdates the headers dict).
mppx servers send this parameter when created with Mppx.create({ requiresAuth: true, ... }) (added in mppx 0.9.0), and then read the credential only from Payment-Authorization.
To Reproduce
bedrock-agentcore 1.24.1 (main at b70e0b7), Python 3.10:
import base64
import json
from unittest.mock import MagicMock, patch
from bedrock_agentcore.payments.integrations.handlers import GenericPaymentHandler
from bedrock_agentcore.payments.manager import PaymentManager
request = {
"amount": "1000",
"currency": "0x036CbD53842c5426634e7929541eC2318f3dCF71",
"recipient": "0x742d35Cc6634C0532925a3b844Bc9e7595f8fE00",
"methodDetails": {"chainId": 84532},
}
encoded = base64.urlsafe_b64encode(json.dumps(request, separators=(",", ":")).encode()).decode().rstrip("=")
challenge = (
f'Payment id="x7Tg2pLqR9mKvNwY3hBcZa", realm="api.example.com", method="evm", intent="charge", '
f'header="Payment-Authorization", request="{encoded}"'
)
with patch("boto3.Session") as session:
session.return_value.region_name = "us-west-2"
manager = PaymentManager(
payment_manager_arn="arn:aws:bedrock-agentcore:us-west-2:123456789012:payment-manager/pm-abc123",
region_name="us-west-2",
)
manager._payment_client = MagicMock()
manager._payment_client.get_payment_instrument.return_value = {
"paymentInstrument": {"paymentInstrumentDetails": {"embeddedCryptoWallet": {"network": "ETHEREUM"}}}
}
manager._payment_client.process_payment.return_value = {
"processPayment": {
"status": "PROOF_GENERATED",
"paymentOutput": {"mpp": {"selectedPaymentId": "x7Tg2pLqR9mKvNwY3hBcZa", "paymentCredential": "eyJ0b2tlbiI6MX0"}},
}
}
payment_header = manager.generate_payment_header(
user_id="user-1",
payment_instrument_id="pi-1",
payment_session_id="ps-1",
payment_required_request={"statusCode": 402, "headers": {"WWW-Authenticate": challenge}, "body": {}},
)
print("ProcessPayment calls:", manager._payment_client.process_payment.call_count)
print("payment header:", payment_header)
tool_input = {"url": "https://api.example.com/resource", "headers": {"Authorization": "Bearer mF_9.B5f-4.1JqM"}}
GenericPaymentHandler().apply_payment_header(tool_input, payment_header)
print("retried request headers:", tool_input["headers"])
Output:
ProcessPayment calls: 1
payment header: {'Authorization': 'Payment eyJ0b2tlbiI6MX0'}
retried request headers: {'Authorization': 'Payment eyJ0b2tlbiI6MX0'}
Expected behavior
For a challenge with header="Payment-Authorization", generate_payment_header returns {"Payment-Authorization": "Payment <credential>"}, and the retried request keeps its own Authorization header. A challenge without header keeps using Authorization, as now. Until the field is supported, such a challenge should not be selected or paid.
Additional context
- The parameter was added to the spec in tempoxyz/mpp-specs#328 (2026-08-25), a week after MPP support landed here in #643 (2026-08-18).
- The spec also asks the client to echo
headerin the credential'schallengeobject. The raw challenge, includingheader, is already forwarded toProcessPayment, so that part may be handled by the service; I could not check it.
- Vorherrschende Sprache
- Python
- Sterne
- 786
- Forks
- 163
- Ø Merge
- 4 Std.
- Gemergte PRs (30 T.)
- 22
Entwicklungsumgebung
- Kein Dockerfile und keine Docker-Compose-Datei
- Keine Pull-Request-Vorlage
- Beitragsleitfaden lesen
Erste Schritte
- Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
- Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
- Forken Sie das Repository und arbeiten Sie in einem Branch.
- Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.
Mehr aus aws/bedrock-agentcore-sdk-python
-
bug high-severity
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 72/100
aws/bedrock-agentcore-sdk-python#752 ·
Maintainer antworten meist innerhalb von 1 Tag
-
OpenAIConverseConverter restores an empty history when one blob or text payload fails to parseOffenbug
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 82/100
aws/bedrock-agentcore-sdk-python#751 · 1 Reaktion ·
Maintainer antworten meist innerhalb von 1 Tag
-
delete_all_long_term_memories_in_namespace deletes only the first 10 recordsEvtl. vergeben @Fire162 hat das vor 18 Tagen übernommen. Offenbug high-severity
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 75/100
aws/bedrock-agentcore-sdk-python#727 ·
Maintainer antworten meist innerhalb von 1 Tag
-
[Bug] update_message fails with parameter validation error when SessionMessage.message_id is a Strands positional integer indexEvtl. vergeben @citizen204 hat das vor 144 Tagen übernommen. Offen
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 68/100
aws/bedrock-agentcore-sdk-python#556 ·
Maintainer antworten meist innerhalb von 1 Tag
-
CodeInterpreter should not require a region argumentEvtl. vergeben @citizen204 hat das vor 159 Tagen übernommen. Offen
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 68/100
aws/bedrock-agentcore-sdk-python#511 ·
Maintainer antworten meist innerhalb von 1 Tag
Alle Issues in aws/bedrock-agentcore-sdk-python
Ähnliche Issues
-
Schwierigkeit 1/5 Unter einer Stunde Anfängerfreundlichkeit 88/100
snap-stanford/Biomni#380 ·
-
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 74/100
microsoft/playwright-python#3361 ·
Maintainer antworten meist innerhalb von 1 Tag
-
documentation priority: low size: S status: needs triage
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 74/100
cubrid-lab/sqlalchemy-cubrid#1397 ·
Maintainer antworten meist innerhalb von 1 Tag
-
documentation priority: low size: S status: needs triage
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 72/100
cubrid-lab/pycubrid#1307 ·
Maintainer antworten meist innerhalb von 1 Tag
-
[Bug]: Installer hides SSL certificate errors as bare URLError, and the suggested fix can't workOffenbug
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 80/100
ShaftHQ/chaosengine-harness#143 ·
Maintainer antworten meist innerhalb von 1 Tag