MPP: credential is always sent in Authorization, ignoring header="Payment-Authorization" in the challenge

Abierto Apto para principiantes
#702 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

@abhiramshaji-cyber ya está trabajando en esto.

Desde el 27/10/2026.

  • #719 de @abhiramshaji-cyber — abierto

Evaluación

Dificultad
2/5
Tiempo estimado
1-3 horas
Aptitud para principiantes
68/100
Tipo de issue
Error
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
python
Área
api, backend

Línea de trabajo

Empieza en bedrock_agentcore/payments/manager.py, en PaymentManager._generate_mpp_payment_header, y sigue cómo llega el encabezado de desafío seleccionado a generate_payment_header. Comprueba cómo el controlador de Strands y el middleware de LangGraph aplican los encabezados devueltos, y añade o ejecuta pruebas específicas para Payment-Authorization y el comportamiento predeterminado de Authorization. La tarea estará completa cuando el encabezado seleccionado contenga la credencial y se conserve el valor Authorization existente de quien realiza la llamada.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

bug

Describe the bug

The MPP core spec lets a challenge choose the request header for the credential. With header="Payment-Authorization", the client must send the credential in Payment-Authorization, so that Authorization stays free for the client's own authentication (draft-httpauth-payment-01, section "Credentials"). The server accepts the credential only from the selected field, and a client that does not support Payment-Authorization must not send a credential for such a challenge.

PaymentManager._generate_mpp_payment_header always returns {"Authorization": "Payment <credential>"}, whatever the selected challenge says. For a challenge with header="Payment-Authorization", the SDK:

  • pays it (ProcessPayment is called);
  • returns the credential under Authorization, where the server does not look for it;
  • replaces the caller's own Authorization value (for example a Bearer token) when the Strands plugin or the LangGraph middleware applies the header to the retried request (apply_payment_header updates the headers dict).

mppx servers send this parameter when created with Mppx.create({ requiresAuth: true, ... }) (added in mppx 0.9.0), and then read the credential only from Payment-Authorization.

To Reproduce

bedrock-agentcore 1.24.1 (main at b70e0b7), Python 3.10:

import base64
import json
from unittest.mock import MagicMock, patch

from bedrock_agentcore.payments.integrations.handlers import GenericPaymentHandler
from bedrock_agentcore.payments.manager import PaymentManager

request = {
    "amount": "1000",
    "currency": "0x036CbD53842c5426634e7929541eC2318f3dCF71",
    "recipient": "0x742d35Cc6634C0532925a3b844Bc9e7595f8fE00",
    "methodDetails": {"chainId": 84532},
}
encoded = base64.urlsafe_b64encode(json.dumps(request, separators=(",", ":")).encode()).decode().rstrip("=")
challenge = (
    f'Payment id="x7Tg2pLqR9mKvNwY3hBcZa", realm="api.example.com", method="evm", intent="charge", '
    f'header="Payment-Authorization", request="{encoded}"'
)

with patch("boto3.Session") as session:
    session.return_value.region_name = "us-west-2"
    manager = PaymentManager(
        payment_manager_arn="arn:aws:bedrock-agentcore:us-west-2:123456789012:payment-manager/pm-abc123",
        region_name="us-west-2",
    )
manager._payment_client = MagicMock()
manager._payment_client.get_payment_instrument.return_value = {
    "paymentInstrument": {"paymentInstrumentDetails": {"embeddedCryptoWallet": {"network": "ETHEREUM"}}}
}
manager._payment_client.process_payment.return_value = {
    "processPayment": {
        "status": "PROOF_GENERATED",
        "paymentOutput": {"mpp": {"selectedPaymentId": "x7Tg2pLqR9mKvNwY3hBcZa", "paymentCredential": "eyJ0b2tlbiI6MX0"}},
    }
}

payment_header = manager.generate_payment_header(
    user_id="user-1",
    payment_instrument_id="pi-1",
    payment_session_id="ps-1",
    payment_required_request={"statusCode": 402, "headers": {"WWW-Authenticate": challenge}, "body": {}},
)
print("ProcessPayment calls:", manager._payment_client.process_payment.call_count)
print("payment header:", payment_header)

tool_input = {"url": "https://api.example.com/resource", "headers": {"Authorization": "Bearer mF_9.B5f-4.1JqM"}}
GenericPaymentHandler().apply_payment_header(tool_input, payment_header)
print("retried request headers:", tool_input["headers"])

Output:

ProcessPayment calls: 1
payment header: {'Authorization': 'Payment eyJ0b2tlbiI6MX0'}
retried request headers: {'Authorization': 'Payment eyJ0b2tlbiI6MX0'}

Expected behavior

For a challenge with header="Payment-Authorization", generate_payment_header returns {"Payment-Authorization": "Payment <credential>"}, and the retried request keeps its own Authorization header. A challenge without header keeps using Authorization, as now. Until the field is supported, such a challenge should not be selected or paid.

Additional context

  • The parameter was added to the spec in tempoxyz/mpp-specs#328 (2026-08-25), a week after MPP support landed here in #643 (2026-08-18).
  • The spec also asks the client to echo header in the credential's challenge object. The raw challenge, including header, is already forwarded to ProcessPayment, so that part may be handled by the service; I could not check it.
Lenguaje dominante
Python
Estrellas
786
Forks
163
Merge medio
4 h
PR fusionados (30 d)
22

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de aws/bedrock-agentcore-sdk-python

Todos los issues de aws/bedrock-agentcore-sdk-python

Issues similares

Más issues de Python

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.