delete_all_long_term_memories_in_namespace deletes only the first 10 records

Offen Anfängerfreundlich
#727 0 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen

Maintainer antworten meist innerhalb von 1 Tag

@Fire162 arbeitet bereits daran.

Seit 02.11.2026.

  • #729 von @Fire162 — offen

Bewertung

Schwierigkeit
2/5
Geschätzter Aufwand
1-3 Stunden
Anfängerfreundlichkeit
75/100
Issue-Typ
Bug
Klarheit
Klar beschrieben
Aktivitätsstatus
Aktiv
Tech-Stack
aws, python
Bereich
backend

Rechercherichtung

Der Fehler liegt in delete_all_long_term_memories_in_namespace in src/bedrock_agentcore/memory/session.py, die list_long_term_memory_records ohne max_results aufruft, sodass der Standardwert 10 gilt. Lies diese Methode und den Listing-Code, den sie aufruft, um zu sehen, wie das Paging bei max_results stoppt. Fertig ist, wenn alle Datensätze eines Namespaces seitenübergreifend gelöscht werden, mit einem Unit-Test, der mehr als 10 Datensätze enthält und nur den Paginator von list_memory_records mockt.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Beschreibung

bug high-severity

Describe the bug

MemorySessionManager.delete_all_long_term_memories_in_namespace is documented to delete all long-term memory records in a namespace, but it deletes at most 10. It collects the records with list_long_term_memory_records(namespace=namespace) and does not pass max_results, so it gets the default of 10:

The return value has 10 successfulRecords and an empty failedRecords, so the caller cannot tell that records were left behind.

To Reproduce

Steps to reproduce the behavior (boto3 client mocked, no AWS calls):

  1. Mock the data-plane client so list_memory_records returns 250 records in one namespace, over three pages.
  2. Call MemorySessionManager(...).delete_all_long_term_memories_in_namespace("actor/123/facts").
  3. See that 10 records are deleted with a single batch_delete_memory_records call.

Script:

from unittest.mock import MagicMock, patch
from bedrock_agentcore.memory.session import MemorySessionManager

records = [{"memoryRecordId": f"rec-{i:03d}"} for i in range(250)]
client = MagicMock()
paginator = MagicMock()
paginator.paginate.return_value = [{"memoryRecordSummaries": records[i : i + 100]} for i in range(0, 250, 100)]
client.get_paginator.return_value = paginator
client.batch_delete_memory_records.side_effect = lambda memoryId, records: {
    "successfulRecords": [{"memoryRecordId": r["memoryRecordId"]} for r in records],
    "failedRecords": [],
}

with patch("boto3.Session") as sess:
    sess.return_value.client.return_value = client
    sess.return_value.region_name = "us-west-2"
    mgr = MemorySessionManager(memory_id="mem-1", region_name="us-west-2")

result = mgr.delete_all_long_term_memories_in_namespace("actor/123/facts")
print("deleted:", len(result["successfulRecords"]), "failed:", len(result["failedRecords"]))
print("batch_delete calls:", client.batch_delete_memory_records.call_count)

Output:

deleted: 10 failed: 0
batch_delete calls: 1

Expected behavior

All 250 records are deleted, in three batch_delete_memory_records calls (the method already splits the IDs into chunks of 100).

Screenshots

N/A

Desktop (please complete the following information):

  • OS: Linux
  • Browser: N/A (Python SDK)
  • Version: bedrock-agentcore 1.25.2 (main at 3707a9f), Python 3.12.8, boto3 1.43.123

Smartphone (please complete the following information):

N/A

Additional context

  • The limit has been there since the method was added in #148. The existing unit tests patch list_long_term_memory_records, so they never hit the default.
  • Proposed fix: read every page before deleting, either by passing an unbounded max_results at L1109 or by iterating the list_memory_records paginator in this method, plus a unit test with more than 10 records that mocks only the paginator.
  • Out of scope: whether this call should use namespace or namespace_path (the TODO added in #449). The fix keeps namespace=namespace unchanged.

I'd be happy to work on this if confirmed.

Vorherrschende Sprache
Python
Sterne
786
Forks
163
Ø Merge
4 Std.
Gemergte PRs (30 T.)
22

Entwicklungsumgebung

Erste Schritte

  1. Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
  2. Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
  3. Forken Sie das Repository und arbeiten Sie in einem Branch.
  4. Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.

Mehr aus aws/bedrock-agentcore-sdk-python

Alle Issues in aws/bedrock-agentcore-sdk-python

Ähnliche Issues

Weitere Issues zu Python

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.