MPP: credential is always sent in Authorization, ignoring header="Payment-Authorization" in the challenge

Aperta Adatta ai principianti
#702 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

@abhiramshaji-cyber ci sta già lavorando.

Dal 27/10/2026.

  • #719 di @abhiramshaji-cyber — aperta

Valutazione

Difficoltà
2/5
Tempo stimato
1-3 ore
Idoneità per principianti
68/100
Tipo di issue
Bug
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
python
Ambito
api, backend

Direzione di ricerca

Parti da bedrock_agentcore/payments/manager.py, in corrispondenza di PaymentManager._generate_mpp_payment_header, e segui il percorso dell’header di challenge selezionato fino a generate_payment_header. Verifica come l’handler di Strands e il middleware di LangGraph applicano gli header restituiti, quindi aggiungi o esegui test mirati per Payment-Authorization e il comportamento predefinito di Authorization. Il lavoro è completato quando l’header selezionato contiene la credenziale e il valore Authorization già presente del chiamante viene mantenuto.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

bug

Describe the bug

The MPP core spec lets a challenge choose the request header for the credential. With header="Payment-Authorization", the client must send the credential in Payment-Authorization, so that Authorization stays free for the client's own authentication (draft-httpauth-payment-01, section "Credentials"). The server accepts the credential only from the selected field, and a client that does not support Payment-Authorization must not send a credential for such a challenge.

PaymentManager._generate_mpp_payment_header always returns {"Authorization": "Payment <credential>"}, whatever the selected challenge says. For a challenge with header="Payment-Authorization", the SDK:

  • pays it (ProcessPayment is called);
  • returns the credential under Authorization, where the server does not look for it;
  • replaces the caller's own Authorization value (for example a Bearer token) when the Strands plugin or the LangGraph middleware applies the header to the retried request (apply_payment_header updates the headers dict).

mppx servers send this parameter when created with Mppx.create({ requiresAuth: true, ... }) (added in mppx 0.9.0), and then read the credential only from Payment-Authorization.

To Reproduce

bedrock-agentcore 1.24.1 (main at b70e0b7), Python 3.10:

import base64
import json
from unittest.mock import MagicMock, patch

from bedrock_agentcore.payments.integrations.handlers import GenericPaymentHandler
from bedrock_agentcore.payments.manager import PaymentManager

request = {
    "amount": "1000",
    "currency": "0x036CbD53842c5426634e7929541eC2318f3dCF71",
    "recipient": "0x742d35Cc6634C0532925a3b844Bc9e7595f8fE00",
    "methodDetails": {"chainId": 84532},
}
encoded = base64.urlsafe_b64encode(json.dumps(request, separators=(",", ":")).encode()).decode().rstrip("=")
challenge = (
    f'Payment id="x7Tg2pLqR9mKvNwY3hBcZa", realm="api.example.com", method="evm", intent="charge", '
    f'header="Payment-Authorization", request="{encoded}"'
)

with patch("boto3.Session") as session:
    session.return_value.region_name = "us-west-2"
    manager = PaymentManager(
        payment_manager_arn="arn:aws:bedrock-agentcore:us-west-2:123456789012:payment-manager/pm-abc123",
        region_name="us-west-2",
    )
manager._payment_client = MagicMock()
manager._payment_client.get_payment_instrument.return_value = {
    "paymentInstrument": {"paymentInstrumentDetails": {"embeddedCryptoWallet": {"network": "ETHEREUM"}}}
}
manager._payment_client.process_payment.return_value = {
    "processPayment": {
        "status": "PROOF_GENERATED",
        "paymentOutput": {"mpp": {"selectedPaymentId": "x7Tg2pLqR9mKvNwY3hBcZa", "paymentCredential": "eyJ0b2tlbiI6MX0"}},
    }
}

payment_header = manager.generate_payment_header(
    user_id="user-1",
    payment_instrument_id="pi-1",
    payment_session_id="ps-1",
    payment_required_request={"statusCode": 402, "headers": {"WWW-Authenticate": challenge}, "body": {}},
)
print("ProcessPayment calls:", manager._payment_client.process_payment.call_count)
print("payment header:", payment_header)

tool_input = {"url": "https://api.example.com/resource", "headers": {"Authorization": "Bearer mF_9.B5f-4.1JqM"}}
GenericPaymentHandler().apply_payment_header(tool_input, payment_header)
print("retried request headers:", tool_input["headers"])

Output:

ProcessPayment calls: 1
payment header: {'Authorization': 'Payment eyJ0b2tlbiI6MX0'}
retried request headers: {'Authorization': 'Payment eyJ0b2tlbiI6MX0'}

Expected behavior

For a challenge with header="Payment-Authorization", generate_payment_header returns {"Payment-Authorization": "Payment <credential>"}, and the retried request keeps its own Authorization header. A challenge without header keeps using Authorization, as now. Until the field is supported, such a challenge should not be selected or paid.

Additional context

  • The parameter was added to the spec in tempoxyz/mpp-specs#328 (2026-08-25), a week after MPP support landed here in #643 (2026-08-18).
  • The spec also asks the client to echo header in the credential's challenge object. The raw challenge, including header, is already forwarded to ProcessPayment, so that part may be handled by the service; I could not check it.
Lingua principale
Python
Stelle
786
Fork
163
Merge medio
4h
PR unite (30g)
22

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di aws/bedrock-agentcore-sdk-python

Tutte le issue di aws/bedrock-agentcore-sdk-python

Issue simili

Altre issue su Python

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.