[Bug] GPORCA ignores foreign segments of a postgres_fdw table and returns duplicated rows
Maintainer antworten meist innerhalb von 2 Tagen
Dieses Issue hat noch niemand übernommen.
Bewertung
- Schwierigkeit
- 4/5
- Geschätzter Aufwand
- 3-5 Tage
- Anfängerfreundlichkeit
- 35/100
Rechercherichtung
Start by comparing GPORCA's handling of postgres_fdw foreign segments with the Postgres-based planner path, focusing on the foreign scan and gp_foreign_server behavior described in the issue. Reproduce with the provided SQL on a three-primary demo cluster, then inspect the optimizer code and tests for foreign tables with mpp_execute 'all segments'. Done means GPORCA returns one scan per foreign segment with correct server OIDs, or falls back to the Postgres planner.
Vom Indexierungsmodell aus dem Issue-Text verfasst.
Beschreibung
Apache Cloudberry version
Reproduced on:
REL_2_STABLEat 91582af9baf (PostgreSQL 14.12, 2.2.0-incubating build dev)mainat eb9bf338855 (PostgreSQL 16.9, 3.0.0-devel)
What happened
A postgres_fdw foreign table with mpp_execute 'all segments' that has several foreign
segments (ADD FOREIGN SEGMENT FROM SERVER ... INTO ..., added in #320) is scanned correctly by
the Postgres-based planner: one executor per foreign server. With GPORCA, which is the default
optimizer, the foreign segments are ignored. The table is scanned on all segments of the
cluster, so some remote servers are read more than once and rows are duplicated.
gp_foreign_server is 0 for every row.
What you think should happen instead
GPORCA should produce the same plan shape as the Postgres-based planner: one scan per foreign
segment, each reading its own server, with gp_foreign_server set to that server's OID. If
GPORCA cannot support foreign segments, it should fall back to the Postgres-based planner
instead of returning wrong results.
How to reproduce
Demo cluster with 3 primaries. The remote servers are two databases on the same cluster.
CREATE DATABASE bugfdw1;
CREATE DATABASE bugfdw2;
\c bugfdw1
CREATE TABLE t1 (a int, b text) DISTRIBUTED BY (a);
INSERT INTO t1 SELECT g, 'bugfdw1' FROM generate_series(1, 10) g;
\c bugfdw2
CREATE TABLE t1 (a int, b text) DISTRIBUTED BY (a);
INSERT INTO t1 SELECT g, 'bugfdw2' FROM generate_series(1, 10) g;
CREATE DATABASE bugrepro;
\c bugrepro
CREATE EXTENSION postgres_fdw;
CREATE SERVER mpps1 FOREIGN DATA WRAPPER postgres_fdw OPTIONS (host '127.0.0.1', port '7000', dbname 'bugfdw1');
CREATE SERVER mpps2 FOREIGN DATA WRAPPER postgres_fdw OPTIONS (host '127.0.0.1', port '7000', dbname 'bugfdw2');
CREATE USER MAPPING FOR CURRENT_USER SERVER mpps1;
CREATE USER MAPPING FOR CURRENT_USER SERVER mpps2;
CREATE FOREIGN TABLE fs1 (a int, b text) SERVER mpps1
OPTIONS (table_name 't1', mpp_execute 'all segments');
ADD FOREIGN SEGMENT FROM SERVER mpps1 INTO fs1;
ADD FOREIGN SEGMENT FROM SERVER mpps2 INTO fs1;
SET optimizer = off;
EXPLAIN (COSTS OFF) SELECT * FROM fs1;
SELECT gp_foreign_server, b, count(*) FROM fs1 GROUP BY 1, 2 ORDER BY 1, 2;
SET optimizer = on;
EXPLAIN (COSTS OFF) SELECT * FROM fs1;
SELECT gp_foreign_server, b, count(*) FROM fs1 GROUP BY 1, 2 ORDER BY 1, 2;
Postgres-based planner (correct):
Gather Motion 2:1 (slice1; segments: 2)
-> Foreign Scan on fs1
Optimizer: Postgres query optimizer
gp_foreign_server | b | count
-------------------+---------+-------
17040 | bugfdw1 | 10
17041 | bugfdw2 | 10
GPORCA (wrong):
Gather Motion 3:1 (slice1; segments: 3)
-> Foreign Scan on fs1
Optimizer: GPORCA
gp_foreign_server | b | count
-------------------+---------+-------
0 | bugfdw1 | 20
0 | bugfdw2 | 10
The results are identical on REL_2_STABLE and main. With 3 segments and 2 foreign servers,
segment 2 wraps around to the first server, so bugfdw1 is read twice.
Operating System
Rocky Linux 9.7 (apache/incubator-cloudberry:cbdb-build-rocky9-latest), built with devops/build/automation/cloudberry/scripts.
Anything else
Joins on gp_foreign_server (a.gp_foreign_server = b.gp_foreign_server), which the feature
documents for co-located joins, also return wrong results under GPORCA because the column is
always 0. Workaround: SET optimizer = off before querying such tables.
Bug found by Claude Code. Please review it again.
- Vorherrschende Sprache
- C
- Sterne
- 1.4k
- Forks
- 273
- Ø Merge
- 4 T. 6 Std.
- Gemergte PRs (30 T.)
- 105
Entwicklungsumgebung
- Kein Dockerfile und keine Docker-Compose-Datei
- Hat eine Pull-Request-Vorlage
- Beitragsleitfaden lesen
Erste Schritte
- Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
- Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
- Forken Sie das Repository und arbeiten Sie in einem Branch.
- Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.
Mehr aus apache/cloudberry
-
isolation2 lockmodes fails on cassert builds: extra AccessShareLock on partition rootEvtl. vergeben @tuhaihe hat das heute übernommen. Offen
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 78/100
apache/cloudberry#2356 ·
Maintainer antworten meist innerhalb von 2 Tagen
-
psql tab completion broken for storage servers, tags, profiles and resource groups (pre-PG15 query format)Evtl. vergeben @allenvox hat das vor 5 Tagen übernommen. Offen
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 72/100
apache/cloudberry#2316 ·
Maintainer antworten meist innerhalb von 2 Tagen
-
[Bug] Expand fails to recognize user-defined tablespacesEvtl. vergeben @nix-oss hat das vor 92 Tagen übernommen. Offentype: Bug
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 76/100
apache/cloudberry#1885 · 2 Reaktionen ·
Maintainer antworten meist innerhalb von 2 Tagen
-
gpexpand first stage fails: 'SyncPackages' object has no attribute 'ret' (extension sync never runs; regression)Evtl. vergeben @talmacschen-arch hat das vor 154 Tagen übernommen. Offen
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 86/100
apache/cloudberry#1825 ·
Maintainer antworten meist innerhalb von 2 Tagen
-
type: Bug
Schwierigkeit 4/5 3-5 Tage Anfängerfreundlichkeit 53/100
apache/cloudberry#2350 · 1 Reaktion ·
Maintainer antworten meist innerhalb von 2 Tagen
Alle Issues in apache/cloudberry
Ähnliche Issues
-
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 74/100
389ds/389-ds-base#8152 ·
Maintainer antworten meist innerhalb von 2 Tagen
-
meta:feature-request
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 66/100
mpv-player/mpv#18855 · 2 Kommentare ·
Maintainer antworten meist innerhalb von 1 Tag
-
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 78/100
Maintainer antworten meist innerhalb von 1 Tag
-
[FIX]: File Tree in appOffenbug help wanted
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 64/100
Maintainer antworten meist innerhalb von 1 Tag
-
windows-artifacts: the win-arm64 job uses a Visual Studio generator missing from windows-11-armOffen
Schwierigkeit 1/5 Unter einer Stunde Anfängerfreundlichkeit 86/100