[Bug] GPORCA ignores foreign segments of a postgres_fdw table and returns duplicated rows
Mantenedores costumam responder em até 2 dias
Ninguém assumiu esta issue ainda.
Avaliação
- Dificuldade
- 4/5
- Tempo estimado
- 3-5 dias
- Facilidade para iniciantes
- 35/100
Direção de pesquisa
Start by comparing GPORCA's handling of postgres_fdw foreign segments with the Postgres-based planner path, focusing on the foreign scan and gp_foreign_server behavior described in the issue. Reproduce with the provided SQL on a three-primary demo cluster, then inspect the optimizer code and tests for foreign tables with mpp_execute 'all segments'. Done means GPORCA returns one scan per foreign segment with correct server OIDs, or falls back to the Postgres planner.
Escrita pelo modelo de indexação a partir do texto da issue.
Descrição
Apache Cloudberry version
Reproduced on:
REL_2_STABLEat 91582af9baf (PostgreSQL 14.12, 2.2.0-incubating build dev)mainat eb9bf338855 (PostgreSQL 16.9, 3.0.0-devel)
What happened
A postgres_fdw foreign table with mpp_execute 'all segments' that has several foreign
segments (ADD FOREIGN SEGMENT FROM SERVER ... INTO ..., added in #320) is scanned correctly by
the Postgres-based planner: one executor per foreign server. With GPORCA, which is the default
optimizer, the foreign segments are ignored. The table is scanned on all segments of the
cluster, so some remote servers are read more than once and rows are duplicated.
gp_foreign_server is 0 for every row.
What you think should happen instead
GPORCA should produce the same plan shape as the Postgres-based planner: one scan per foreign
segment, each reading its own server, with gp_foreign_server set to that server's OID. If
GPORCA cannot support foreign segments, it should fall back to the Postgres-based planner
instead of returning wrong results.
How to reproduce
Demo cluster with 3 primaries. The remote servers are two databases on the same cluster.
CREATE DATABASE bugfdw1;
CREATE DATABASE bugfdw2;
\c bugfdw1
CREATE TABLE t1 (a int, b text) DISTRIBUTED BY (a);
INSERT INTO t1 SELECT g, 'bugfdw1' FROM generate_series(1, 10) g;
\c bugfdw2
CREATE TABLE t1 (a int, b text) DISTRIBUTED BY (a);
INSERT INTO t1 SELECT g, 'bugfdw2' FROM generate_series(1, 10) g;
CREATE DATABASE bugrepro;
\c bugrepro
CREATE EXTENSION postgres_fdw;
CREATE SERVER mpps1 FOREIGN DATA WRAPPER postgres_fdw OPTIONS (host '127.0.0.1', port '7000', dbname 'bugfdw1');
CREATE SERVER mpps2 FOREIGN DATA WRAPPER postgres_fdw OPTIONS (host '127.0.0.1', port '7000', dbname 'bugfdw2');
CREATE USER MAPPING FOR CURRENT_USER SERVER mpps1;
CREATE USER MAPPING FOR CURRENT_USER SERVER mpps2;
CREATE FOREIGN TABLE fs1 (a int, b text) SERVER mpps1
OPTIONS (table_name 't1', mpp_execute 'all segments');
ADD FOREIGN SEGMENT FROM SERVER mpps1 INTO fs1;
ADD FOREIGN SEGMENT FROM SERVER mpps2 INTO fs1;
SET optimizer = off;
EXPLAIN (COSTS OFF) SELECT * FROM fs1;
SELECT gp_foreign_server, b, count(*) FROM fs1 GROUP BY 1, 2 ORDER BY 1, 2;
SET optimizer = on;
EXPLAIN (COSTS OFF) SELECT * FROM fs1;
SELECT gp_foreign_server, b, count(*) FROM fs1 GROUP BY 1, 2 ORDER BY 1, 2;
Postgres-based planner (correct):
Gather Motion 2:1 (slice1; segments: 2)
-> Foreign Scan on fs1
Optimizer: Postgres query optimizer
gp_foreign_server | b | count
-------------------+---------+-------
17040 | bugfdw1 | 10
17041 | bugfdw2 | 10
GPORCA (wrong):
Gather Motion 3:1 (slice1; segments: 3)
-> Foreign Scan on fs1
Optimizer: GPORCA
gp_foreign_server | b | count
-------------------+---------+-------
0 | bugfdw1 | 20
0 | bugfdw2 | 10
The results are identical on REL_2_STABLE and main. With 3 segments and 2 foreign servers,
segment 2 wraps around to the first server, so bugfdw1 is read twice.
Operating System
Rocky Linux 9.7 (apache/incubator-cloudberry:cbdb-build-rocky9-latest), built with devops/build/automation/cloudberry/scripts.
Anything else
Joins on gp_foreign_server (a.gp_foreign_server = b.gp_foreign_server), which the feature
documents for co-located joins, also return wrong results under GPORCA because the column is
always 0. Workaround: SET optimizer = off before querying such tables.
Bug found by Claude Code. Please review it again.
- Linguagem predominante
- C
- Estrelas
- 1.4k
- Forks
- 273
- Merge médio
- 4d 6h
- PRs com merge (30d)
- 105
Preparar o ambiente
- Sem Dockerfile nem arquivo Docker Compose
- Tem um modelo de pull request
- Ler o guia de contribuição
Primeiros passos
- Leia a issue inteira e depois o guia de contribuição do projeto.
- Comente na issue dizendo que vai assumir — evita que duas pessoas façam o mesmo trabalho.
- Faça um fork do repositório e trabalhe em uma branch.
- Abra um pull request que referencie o número da issue.
Mais de apache/cloudberry
-
isolation2 lockmodes fails on cassert builds: extra AccessShareLock on partition rootTalvez já em andamento @tuhaihe assumiu hoje. Aberta
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 78/100
apache/cloudberry#2356 ·
Mantenedores costumam responder em até 2 dias
-
psql tab completion broken for storage servers, tags, profiles and resource groups (pre-PG15 query format)Talvez já em andamento @allenvox assumiu há 5 dias. Aberta
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 72/100
apache/cloudberry#2316 ·
Mantenedores costumam responder em até 2 dias
-
[Bug] Expand fails to recognize user-defined tablespacesTalvez já em andamento @nix-oss assumiu há 93 dias. Abertatype: Bug
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 76/100
apache/cloudberry#1885 · 2 reações ·
Mantenedores costumam responder em até 2 dias
-
gpexpand first stage fails: 'SyncPackages' object has no attribute 'ret' (extension sync never runs; regression)Talvez já em andamento @talmacschen-arch assumiu há 154 dias. Aberta
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 86/100
apache/cloudberry#1825 ·
Mantenedores costumam responder em até 2 dias
-
type: Bug
Dificuldade 4/5 3-5 dias Facilidade para iniciantes 53/100
apache/cloudberry#2350 · 1 reação ·
Mantenedores costumam responder em até 2 dias
Todas as issues de apache/cloudberry
Issues semelhantes
-
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 72/100
OpenPrinting/cups#1826 ·
Mantenedores costumam responder em até 1 dia
-
Backport to 3.0 advertises a suffix that does not existTalvez já em andamento Um pull request vinculado a esta issue está aberto ou já foi mesclado. Aberta
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 74/100
389ds/389-ds-base#8152 ·
Mantenedores costumam responder em até 2 dias
-
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 78/100
RetroAchievements/rcheevos#580 · 1 comentário ·
Mantenedores costumam responder em até 5 dias
-
meta:feature-request
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 66/100
mpv-player/mpv#18855 · 2 comentários ·
Mantenedores costumam responder em até 1 dia
-
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 78/100
Mantenedores costumam responder em até 1 dia