[Bug] Parallel dedup semi-join planning takes an exclusive lock on gp_segment_configuration

Offen
#2,350 0 Kommentare 1 Reaktion 0 zugewiesene Personen Auf GitHub ansehen

Maintainer antworten meist innerhalb von 2 Tagen

Dieses Issue hat noch niemand übernommen.

Bewertung

Schwierigkeit
4/5
Geschätzter Aufwand
3-5 Tage
Anfängerfreundlichkeit
53/100
Issue-Typ
Bug
Klarheit
Klar beschrieben
Aktivitätsstatus
Aktiv
Tech-Stack
c, postgresql
Bereich
backend, databases

Rechercherichtung

Start with the parallel semi-join regression fixture in src/test/regress/sql/cbdb_parallel.sql and trace the two planner paths in src/backend/cdb/cdbpath.c to cdbcomponent_get_maxdbid() in src/backend/cdb/cdbutil.c. Check how the catalog is opened and closed, and identify a read-only lookup that preserves locking for topology-changing callers. Verify with EXPLAIN and the fixture that planning no longer holds an AccessExclusiveLock while topology changes retain their required locking.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Beschreibung

type: Bug
Apache Cloudberry version

Apache Cloudberry 2.2.0-incubating, build 13d3c58eaa0 (PostgreSQL 14.10)

What happened

While diagnosing intermittent connection delays on a multi-segment cluster, we observed ordinary read-only SELECTs holding a granted AccessExclusiveLock on pg_catalog.gp_segment_configuration. New connections were waiting for AccessShareLock on the same shared catalog. pg_blocking_pids() identified the SELECT backend as the blocker, including in a different database on the same coordinator.

On a separate three-segment development cluster running the same build, EXPLAIN without ANALYZE alone acquired the lock. In the on/off comparison below, the final plan was Parallel Hash Semi Join in both cases. The lock can therefore come from evaluating a candidate that is never executed.

What you think should happen instead

Planning a read-only query should not hold a transaction-duration AccessExclusiveLock on the shared topology catalog. The planner only needs to read the maximum segment DBID. Please preserve the locking semantics required by topology-changing callers.

How to reproduce

On the affected build in a development environment, use the parallel semi-join regression fixture as a starting point. We compared EXPLAIN (without ANALYZE) on an equivalent EXISTS query joining two distributed tables, with optimizer=off, enable_parallel=on, and two workers per gather.

Planner settings Current backend’s lock on gp_segment_configuration after EXPLAIN
Both parallel dedup semi-join options enabled Granted AccessExclusiveLock
enable_parallel_dedup_semi_join=off and enable_parallel_dedup_semi_reverse_join=off No lock observed

We inspected pg_locks in each read-only test transaction and rolled back immediately after taking the sample.

Operating System

Enterprise Linux 9, x86_64

Anything else

The two parallel join paths in cdbpath.c call cdbcomponent_get_maxdbid() when the deduplicated input uses multiple parallel workers. The catalog implementation opens the relation with AccessExclusiveLock and closes it with NoLock, keeping the lock until transaction end.

A possible fix is to give the planner a separate read-only lookup with appropriately scoped locking. Turning off both dedup options at session scope avoided this path on the tested build while leaving ordinary parallel semi-joins available. We verified the behavior on 2.2.0 only.

Are you willing to submit PR?
  • Yes, I am willing to submit a PR!
Code of Conduct
Vorherrschende Sprache
C
Sterne
1.4k
Forks
273
Ø Merge
4 T. 6 Std.
Gemergte PRs (30 T.)
105

Entwicklungsumgebung

Erste Schritte

  1. Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
  2. Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
  3. Forken Sie das Repository und arbeiten Sie in einem Branch.
  4. Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.

Mehr aus apache/cloudberry

Alle Issues in apache/cloudberry

Ähnliche Issues

Weitere Issues zu C

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.