[Bug] GPORCA ignores foreign segments of a postgres_fdw table and returns duplicated rows

オープン
#2,341 コメント 0 件 リアクション 0 件 担当者 0 名 GitHub で見る

メンテナーはふだん 2 日以内に返信

まだ誰も着手していません。

評価

難易度
4/5
見積もり時間
3〜5日
初心者へのやさしさ
35/100
issue の種類
バグ
明瞭さ
明確に書かれている
活発さ
活発
技術スタック
c, postgresql
領域
databases

調査の方向性

Start by comparing GPORCA's handling of postgres_fdw foreign segments with the Postgres-based planner path, focusing on the foreign scan and gp_foreign_server behavior described in the issue. Reproduce with the provided SQL on a three-primary demo cluster, then inspect the optimizer code and tests for foreign tables with mpp_execute 'all segments'. Done means GPORCA returns one scan per foreign segment with correct server OIDs, or falls back to the Postgres planner.

索引モデルが issue の本文から書いたものです。

説明

type: Bug
Apache Cloudberry version

Reproduced on:

  • REL_2_STABLE at 91582af9baf (PostgreSQL 14.12, 2.2.0-incubating build dev)
  • main at eb9bf338855 (PostgreSQL 16.9, 3.0.0-devel)
What happened

A postgres_fdw foreign table with mpp_execute 'all segments' that has several foreign
segments (ADD FOREIGN SEGMENT FROM SERVER ... INTO ..., added in #320) is scanned correctly by
the Postgres-based planner: one executor per foreign server. With GPORCA, which is the default
optimizer, the foreign segments are ignored. The table is scanned on all segments of the
cluster, so some remote servers are read more than once and rows are duplicated.
gp_foreign_server is 0 for every row.

What you think should happen instead

GPORCA should produce the same plan shape as the Postgres-based planner: one scan per foreign
segment, each reading its own server, with gp_foreign_server set to that server's OID. If
GPORCA cannot support foreign segments, it should fall back to the Postgres-based planner
instead of returning wrong results.

How to reproduce

Demo cluster with 3 primaries. The remote servers are two databases on the same cluster.

CREATE DATABASE bugfdw1;
CREATE DATABASE bugfdw2;
\c bugfdw1
CREATE TABLE t1 (a int, b text) DISTRIBUTED BY (a);
INSERT INTO t1 SELECT g, 'bugfdw1' FROM generate_series(1, 10) g;
\c bugfdw2
CREATE TABLE t1 (a int, b text) DISTRIBUTED BY (a);
INSERT INTO t1 SELECT g, 'bugfdw2' FROM generate_series(1, 10) g;

CREATE DATABASE bugrepro;
\c bugrepro
CREATE EXTENSION postgres_fdw;
CREATE SERVER mpps1 FOREIGN DATA WRAPPER postgres_fdw OPTIONS (host '127.0.0.1', port '7000', dbname 'bugfdw1');
CREATE SERVER mpps2 FOREIGN DATA WRAPPER postgres_fdw OPTIONS (host '127.0.0.1', port '7000', dbname 'bugfdw2');
CREATE USER MAPPING FOR CURRENT_USER SERVER mpps1;
CREATE USER MAPPING FOR CURRENT_USER SERVER mpps2;
CREATE FOREIGN TABLE fs1 (a int, b text) SERVER mpps1
  OPTIONS (table_name 't1', mpp_execute 'all segments');
ADD FOREIGN SEGMENT FROM SERVER mpps1 INTO fs1;
ADD FOREIGN SEGMENT FROM SERVER mpps2 INTO fs1;

SET optimizer = off;
EXPLAIN (COSTS OFF) SELECT * FROM fs1;
SELECT gp_foreign_server, b, count(*) FROM fs1 GROUP BY 1, 2 ORDER BY 1, 2;

SET optimizer = on;
EXPLAIN (COSTS OFF) SELECT * FROM fs1;
SELECT gp_foreign_server, b, count(*) FROM fs1 GROUP BY 1, 2 ORDER BY 1, 2;

Postgres-based planner (correct):

 Gather Motion 2:1  (slice1; segments: 2)
   ->  Foreign Scan on fs1
 Optimizer: Postgres query optimizer

 gp_foreign_server |    b    | count
-------------------+---------+-------
             17040 | bugfdw1 |    10
             17041 | bugfdw2 |    10

GPORCA (wrong):

 Gather Motion 3:1  (slice1; segments: 3)
   ->  Foreign Scan on fs1
 Optimizer: GPORCA

 gp_foreign_server |    b    | count
-------------------+---------+-------
                 0 | bugfdw1 |    20
                 0 | bugfdw2 |    10

The results are identical on REL_2_STABLE and main. With 3 segments and 2 foreign servers,
segment 2 wraps around to the first server, so bugfdw1 is read twice.

Operating System

Rocky Linux 9.7 (apache/incubator-cloudberry:cbdb-build-rocky9-latest), built with devops/build/automation/cloudberry/scripts.

Anything else

Joins on gp_foreign_server (a.gp_foreign_server = b.gp_foreign_server), which the feature
documents for co-located joins, also return wrong results under GPORCA because the column is
always 0. Workaround: SET optimizer = off before querying such tables.

Bug found by Claude Code. Please review it again.

主要言語
C
スター
1.4k
フォーク
273
平均マージ
4日 6時間
マージ済み PR(30日)
105

環境構築

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

apache/cloudberry のほかの issue

apache/cloudberry の issue をすべて見る

似ている issue

C の issue をもっと見る

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。