fix(aidd-dev/plan): plan check hook reports false positives on a two-step plan and on a plan in progress

Offen
#1,190 0 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen

Maintainer antworten meist innerhalb von 1 Tag

Dieses Issue hat noch niemand übernommen.

Bewertung

Schwierigkeit
3/5
Geschätzter Aufwand
1-2 Tage
Anfängerfreundlichkeit
74/100
Issue-Typ
Bug
Klarheit
Klar beschrieben
Aktivitätsstatus
Aktiv
Tech-Stack
typescript

Rechercherichtung

Start with plugins/aidd-dev/skills/01-plan/scripts/validate-plan.cjs and plugins/aidd-dev/skills/02-implement/actions/01-prepare.md; trace how the hook calls the validator at PostToolUse and Stop. Check the hook configuration and existing tests for these paths. Done means changed plans still in pending are checked, missing phase files are ignored while writing and required at Stop, and in-progress or done plans are not flagged.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Beschreibung

Description

A hook that checks plan.md with validate-plan.cjs (PostToolUse on plan.md plus Stop) reports false positives in two cases. Measured in a disposable test with claude -p (haiku).

  1. Plan written in two steps. After plan.md is written, the validator reports phase-1.md: listed in plan.md, file missing. The agent has not written the phase file yet, so the message is wrong mid-work.
  2. Plan already in progress. The validator requires status: pending. 02-implement (actions/01-prepare.md) sets status: in-progress, and a finished plan is done. A hook run at end of turn flags both as invalid.
Affected file(s)
  • plugins/aidd-dev/skills/01-plan/scripts/validate-plan.cjs
  • plugins/aidd-dev/skills/02-implement/actions/01-prepare.md
Expected behaviour

The hook is silent when the plan is valid or still being written. It only judges a plan created or modified during the turn. Phase files are required only at the end of the turn.

Observed behaviour
  • Case 1: message phase-1.md: listed in plan.md, file missing between the plan.md write and the phase-1.md write.
  • Case 2: a plan with status: in-progress or status: done is reported invalid.

Suggested fix, validated on a test hook:

  • Keep a baseline (sha1 of plan.md at SessionStart and at Stop) and judge only plans that changed in the turn.
  • Judge only plans still pending.
  • At PostToolUse, ignore "listed in plan.md, file missing". At Stop, require the phase files.
AI tool

Claude Code

aidd-cli version

Not applicable (reproduced with a standalone hook and the validate-plan.cjs script, not the CLI).

OS

macOS

Additional context
  • No bug label exists in the repo. The issue type is set to Bug.
  • Not applicable to the Code of Conduct checkbox of the form: left to the reporter.
Vorherrschende Sprache
TypeScript
Sterne
481
Forks
45
Ø Merge
1 T. 13 Std.
Gemergte PRs (30 T.)
91

Entwicklungsumgebung

Erste Schritte

  1. Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
  2. Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
  3. Forken Sie das Repository und arbeiten Sie in einem Branch.
  4. Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.

Mehr aus ai-driven-dev/framework

Alle Issues in ai-driven-dev/framework

Ähnliche Issues

Weitere Issues zu TypeScript

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.