fix(aidd-dev/plan): plan check hook reports false positives on a two-step plan and on a plan in progress

Aperta
#1,190 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
3/5
Tempo stimato
1-2 giorni
Idoneità per principianti
74/100
Tipo di issue
Bug
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
typescript

Direzione di ricerca

Start with plugins/aidd-dev/skills/01-plan/scripts/validate-plan.cjs and plugins/aidd-dev/skills/02-implement/actions/01-prepare.md; trace how the hook calls the validator at PostToolUse and Stop. Check the hook configuration and existing tests for these paths. Done means changed plans still in pending are checked, missing phase files are ignored while writing and required at Stop, and in-progress or done plans are not flagged.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

Description

A hook that checks plan.md with validate-plan.cjs (PostToolUse on plan.md plus Stop) reports false positives in two cases. Measured in a disposable test with claude -p (haiku).

  1. Plan written in two steps. After plan.md is written, the validator reports phase-1.md: listed in plan.md, file missing. The agent has not written the phase file yet, so the message is wrong mid-work.
  2. Plan already in progress. The validator requires status: pending. 02-implement (actions/01-prepare.md) sets status: in-progress, and a finished plan is done. A hook run at end of turn flags both as invalid.
Affected file(s)
  • plugins/aidd-dev/skills/01-plan/scripts/validate-plan.cjs
  • plugins/aidd-dev/skills/02-implement/actions/01-prepare.md
Expected behaviour

The hook is silent when the plan is valid or still being written. It only judges a plan created or modified during the turn. Phase files are required only at the end of the turn.

Observed behaviour
  • Case 1: message phase-1.md: listed in plan.md, file missing between the plan.md write and the phase-1.md write.
  • Case 2: a plan with status: in-progress or status: done is reported invalid.

Suggested fix, validated on a test hook:

  • Keep a baseline (sha1 of plan.md at SessionStart and at Stop) and judge only plans that changed in the turn.
  • Judge only plans still pending.
  • At PostToolUse, ignore "listed in plan.md, file missing". At Stop, require the phase files.
AI tool

Claude Code

aidd-cli version

Not applicable (reproduced with a standalone hook and the validate-plan.cjs script, not the CLI).

OS

macOS

Additional context
  • No bug label exists in the repo. The issue type is set to Bug.
  • Not applicable to the Code of Conduct checkbox of the form: left to the reporter.
Lingua principale
TypeScript
Stelle
481
Fork
45
Merge medio
1g 13h
PR unite (30g)
91

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di ai-driven-dev/framework

Tutte le issue di ai-driven-dev/framework

Issue simili

Altre issue su TypeScript

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.