fix(aidd-dev/plan): plan check hook reports false positives on a two-step plan and on a plan in progress

Ouverte
#1,190 0 commentaires 0 réactions 0 personnes assignées Voir sur GitHub

Les mainteneurs répondent en général sous 1 jour

Personne n'a encore pris cette issue.

Évaluation

Difficulté
3/5
Temps estimé
1-2 jours
Accessibilité débutants
74/100
Type d'issue
Bug
Clarté
Clairement spécifiée
Activité
Active
Stack technique
typescript

Piste de recherche

Start with plugins/aidd-dev/skills/01-plan/scripts/validate-plan.cjs and plugins/aidd-dev/skills/02-implement/actions/01-prepare.md; trace how the hook calls the validator at PostToolUse and Stop. Check the hook configuration and existing tests for these paths. Done means changed plans still in pending are checked, missing phase files are ignored while writing and required at Stop, and in-progress or done plans are not flagged.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Description

Description

A hook that checks plan.md with validate-plan.cjs (PostToolUse on plan.md plus Stop) reports false positives in two cases. Measured in a disposable test with claude -p (haiku).

  1. Plan written in two steps. After plan.md is written, the validator reports phase-1.md: listed in plan.md, file missing. The agent has not written the phase file yet, so the message is wrong mid-work.
  2. Plan already in progress. The validator requires status: pending. 02-implement (actions/01-prepare.md) sets status: in-progress, and a finished plan is done. A hook run at end of turn flags both as invalid.
Affected file(s)
  • plugins/aidd-dev/skills/01-plan/scripts/validate-plan.cjs
  • plugins/aidd-dev/skills/02-implement/actions/01-prepare.md
Expected behaviour

The hook is silent when the plan is valid or still being written. It only judges a plan created or modified during the turn. Phase files are required only at the end of the turn.

Observed behaviour
  • Case 1: message phase-1.md: listed in plan.md, file missing between the plan.md write and the phase-1.md write.
  • Case 2: a plan with status: in-progress or status: done is reported invalid.

Suggested fix, validated on a test hook:

  • Keep a baseline (sha1 of plan.md at SessionStart and at Stop) and judge only plans that changed in the turn.
  • Judge only plans still pending.
  • At PostToolUse, ignore "listed in plan.md, file missing". At Stop, require the phase files.
AI tool

Claude Code

aidd-cli version

Not applicable (reproduced with a standalone hook and the validate-plan.cjs script, not the CLI).

OS

macOS

Additional context
  • No bug label exists in the repo. The issue type is set to Bug.
  • Not applicable to the Code of Conduct checkbox of the form: left to the reporter.
Langage dominant
TypeScript
Étoiles
481
Forks
45
Merge moyen
1 j 13 h
PR mergées (30 j)
91

Préparer son environnement

Par où commencer

  1. Lisez l'issue en entier, puis le guide de contribution du projet.
  2. Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
  3. Forkez le dépôt et travaillez sur une branche.
  4. Ouvrez une pull request qui référence le numéro de l'issue.

Autres issues de ai-driven-dev/framework

Toutes les issues de ai-driven-dev/framework

Issues similaires

Plus d'issues TypeScript

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.