fix(aidd-dev/plan): plan check hook reports false positives on a two-step plan and on a plan in progress

未关闭
#1,190 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
3/5
预计耗时
1-2 天
新手友好度
74/100
Issue 类型
缺陷
描述清晰度
描述清楚
活跃度
活跃
技术栈
typescript

调研方向

Start with plugins/aidd-dev/skills/01-plan/scripts/validate-plan.cjs and plugins/aidd-dev/skills/02-implement/actions/01-prepare.md; trace how the hook calls the validator at PostToolUse and Stop. Check the hook configuration and existing tests for these paths. Done means changed plans still in pending are checked, missing phase files are ignored while writing and required at Stop, and in-progress or done plans are not flagged.

由索引模型根据 Issue 内容生成。

描述

Description

A hook that checks plan.md with validate-plan.cjs (PostToolUse on plan.md plus Stop) reports false positives in two cases. Measured in a disposable test with claude -p (haiku).

  1. Plan written in two steps. After plan.md is written, the validator reports phase-1.md: listed in plan.md, file missing. The agent has not written the phase file yet, so the message is wrong mid-work.
  2. Plan already in progress. The validator requires status: pending. 02-implement (actions/01-prepare.md) sets status: in-progress, and a finished plan is done. A hook run at end of turn flags both as invalid.
Affected file(s)
  • plugins/aidd-dev/skills/01-plan/scripts/validate-plan.cjs
  • plugins/aidd-dev/skills/02-implement/actions/01-prepare.md
Expected behaviour

The hook is silent when the plan is valid or still being written. It only judges a plan created or modified during the turn. Phase files are required only at the end of the turn.

Observed behaviour
  • Case 1: message phase-1.md: listed in plan.md, file missing between the plan.md write and the phase-1.md write.
  • Case 2: a plan with status: in-progress or status: done is reported invalid.

Suggested fix, validated on a test hook:

  • Keep a baseline (sha1 of plan.md at SessionStart and at Stop) and judge only plans that changed in the turn.
  • Judge only plans still pending.
  • At PostToolUse, ignore "listed in plan.md, file missing". At Stop, require the phase files.
AI tool

Claude Code

aidd-cli version

Not applicable (reproduced with a standalone hook and the validate-plan.cjs script, not the CLI).

OS

macOS

Additional context
  • No bug label exists in the repo. The issue type is set to Bug.
  • Not applicable to the Code of Conduct checkbox of the form: left to the reporter.
主要语言
TypeScript
星标
481
派生
45
平均合并
1 天 13 小时
30 天内合并 PR
91

环境准备

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

ai-driven-dev/framework 的其他 Issue

查看 ai-driven-dev/framework 的全部 Issue

相似的 Issue

更多 TypeScript Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。