`mirror-token` is sent to GitHub instead of `token` when `mirror` is set

Offen Anfängerfreundlich
#1,662 1 Kommentar 0 Reaktionen 1 zugewiesene Person Auf GitHub ansehen

Maintainer antworten meist innerhalb von 7 Tagen

@v-gowridurgad arbeitet bereits daran.

Seit 09.11.2026.

  • #1669 von @EnesKartal — offen

Bewertung

Schwierigkeit
2/5
Geschätzter Aufwand
1-3 Stunden
Anfängerfreundlichkeit
82/100
Issue-Typ
Bug
Klarheit
Klar beschrieben
Aktivitätsstatus
Aktiv
Tech-Stack
github-actions, node.js, typescript
Bereich
devops, security

Rechercherichtung

Beginne in src/distributions/official_builds/official_builds.ts bei getManifest und setupNodeJs, wo der Issue die Auswahl der Zugangsdaten für die Manifestanfrage und den Binärdownload benennt. Lies tests/official-installer.test.ts und die vorhandenen Mirror-Token-Fälle und ergänze Tests für GitHub- und Mirror-Zugangsdaten. Fertig ist es, wenn GitHub-Anfragen das GitHub-Token verwenden und Mirror-Anfragen weiterhin mirror-token verwenden.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Beschreibung

bug

Description:
When both mirror and mirror-token are set, setup-node sends the mirror token to GitHub. It goes to two places in official_builds.ts:

  1. The actions/node-versions manifest request through tc.getManifestFromRepo, in getManifest.
  2. The binary download through tc.downloadTool, in setupNodeJs. This URL comes from the manifest's download_url, so it always points to github.com/actions/node-versions/releases/....

Both use this pattern:

this.nodeInfo.mirror && this.nodeInfo.mirrorToken
  ? this.nodeInfo.mirrorToken
  : this.nodeInfo.auth

This causes two problems:

  • Security: A credential meant for a private mirror, such as an Artifactory token, gets sent to a third-party host. Mirror tokens should only go to the mirror.
  • Rate limits: Because the mirror token replaces the GitHub token, manifest calls are made without the GitHub token. That makes them more likely to hit GitHub API rate limits. #1548 fixed this only for the case where mirror-token is empty.

The calls that do go to the mirror already use mirrorToken correctly: getNodeJsVersions, downloadNodejs, and the Windows fallback in base-distribution.ts.

Related: #1412, #1467, #1548, #1661

Action version:
actions/setup-node@v7 (current main, 7.1.0). This happens in every version that sends mirror-token to the manifest request.

Platform:

  • Ubuntu
  • macOS
  • Windows

Runner type:

  • Hosted
  • Self-hosted

Tools version:

Any Node.js version that is in the actions/node-versions manifest. This doesn't depend on the package manager.

Repro steps:

  1. Use this step:
- uses: actions/setup-node@v7
  with:
    node-version: '24.9.0'
    mirror: 'https://my-mirror.example.com'
    mirror-token: ${{ secrets.MIRROR_TOKEN }}
  1. Pick a node-version that is in the actions/node-versions manifest and not already in the runner's tool cache.
  2. Watch the outgoing requests, for example with a proxy. The manifest request to the GitHub API and the binary download from github.com/actions/node-versions/releases/... both send Authorization: <MIRROR_TOKEN>.

Expected behavior:
Requests to GitHub always use token, sent as token <token> (this.nodeInfo.auth). mirror-token is only sent to URLs built from mirror.

Actual behavior:
mirror-token is sent to the GitHub API and to github.com release downloads instead of the GitHub token. This sends the mirror credential to GitHub, and the manifest call is made without the GitHub token.

Proposed fix:

  • In official_builds.ts, pass this.nodeInfo.auth to both tc.getManifestFromRepo and the manifest-based tc.downloadTool call. Remove the mirror && mirrorToken ternary.
  • Add tests to __tests__/official-installer.test.ts. No current test checks this case. The existing mirror-token tests only check log messages and that a download happened. With both mirror and mirror-token set, the new tests should check that:
    • getManifestFromRepo is called with 'token <token>', not the mirror token.
    • downloadTool gets 'token <token>' for the github.com/actions/node-versions/releases/... URL.
    • Requests to the mirror still use mirror-token.
Vorherrschende Sprache
TypeScript
Sterne
5k
Forks
1.7k
Ø Merge
5 T. 1 Std.
Gemergte PRs (30 T.)
1

Entwicklungsumgebung

  • Kein Dockerfile und keine Docker-Compose-Datei
  • Hat eine Pull-Request-Vorlage
  • Kein Beitragsleitfaden

Erste Schritte

  1. Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
  2. Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
  3. Forken Sie das Repository und arbeiten Sie in einem Branch.
  4. Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.

Mehr aus actions/setup-node

Alle Issues in actions/setup-node

Ähnliche Issues

Weitere Issues zu TypeScript

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.