`mirror-token` is sent to GitHub instead of `token` when `mirror` is set

Abierto Apto para principiantes
#1,662 1 comentario 0 reacciones 1 asignado Ver en GitHub

Los mantenedores suelen responder en 7 días

@v-gowridurgad ya está trabajando en esto.

Desde el 9/11/2026.

  • #1669 de @EnesKartal — abierto

Evaluación

Dificultad
2/5
Tiempo estimado
1-3 horas
Aptitud para principiantes
82/100
Tipo de issue
Error
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
github-actions, node.js, typescript
Área
devops, security

Línea de trabajo

Empieza en src/distributions/official_builds/official_builds.ts, en getManifest y setupNodeJs, donde el issue identifica la selección de credenciales para la solicitud del manifiesto y la descarga del binario. Lee tests/official-installer.test.ts y los casos existentes de mirror-token, y añade cobertura para las credenciales de GitHub y del mirror. Se considera terminado cuando las solicitudes a GitHub usan el token de GitHub y las solicitudes al mirror siguen usando mirror-token.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

bug

Description:
When both mirror and mirror-token are set, setup-node sends the mirror token to GitHub. It goes to two places in official_builds.ts:

  1. The actions/node-versions manifest request through tc.getManifestFromRepo, in getManifest.
  2. The binary download through tc.downloadTool, in setupNodeJs. This URL comes from the manifest's download_url, so it always points to github.com/actions/node-versions/releases/....

Both use this pattern:

this.nodeInfo.mirror && this.nodeInfo.mirrorToken
  ? this.nodeInfo.mirrorToken
  : this.nodeInfo.auth

This causes two problems:

  • Security: A credential meant for a private mirror, such as an Artifactory token, gets sent to a third-party host. Mirror tokens should only go to the mirror.
  • Rate limits: Because the mirror token replaces the GitHub token, manifest calls are made without the GitHub token. That makes them more likely to hit GitHub API rate limits. #1548 fixed this only for the case where mirror-token is empty.

The calls that do go to the mirror already use mirrorToken correctly: getNodeJsVersions, downloadNodejs, and the Windows fallback in base-distribution.ts.

Related: #1412, #1467, #1548, #1661

Action version:
actions/setup-node@v7 (current main, 7.1.0). This happens in every version that sends mirror-token to the manifest request.

Platform:

  • Ubuntu
  • macOS
  • Windows

Runner type:

  • Hosted
  • Self-hosted

Tools version:

Any Node.js version that is in the actions/node-versions manifest. This doesn't depend on the package manager.

Repro steps:

  1. Use this step:
- uses: actions/setup-node@v7
  with:
    node-version: '24.9.0'
    mirror: 'https://my-mirror.example.com'
    mirror-token: ${{ secrets.MIRROR_TOKEN }}
  1. Pick a node-version that is in the actions/node-versions manifest and not already in the runner's tool cache.
  2. Watch the outgoing requests, for example with a proxy. The manifest request to the GitHub API and the binary download from github.com/actions/node-versions/releases/... both send Authorization: <MIRROR_TOKEN>.

Expected behavior:
Requests to GitHub always use token, sent as token <token> (this.nodeInfo.auth). mirror-token is only sent to URLs built from mirror.

Actual behavior:
mirror-token is sent to the GitHub API and to github.com release downloads instead of the GitHub token. This sends the mirror credential to GitHub, and the manifest call is made without the GitHub token.

Proposed fix:

  • In official_builds.ts, pass this.nodeInfo.auth to both tc.getManifestFromRepo and the manifest-based tc.downloadTool call. Remove the mirror && mirrorToken ternary.
  • Add tests to __tests__/official-installer.test.ts. No current test checks this case. The existing mirror-token tests only check log messages and that a download happened. With both mirror and mirror-token set, the new tests should check that:
    • getManifestFromRepo is called with 'token <token>', not the mirror token.
    • downloadTool gets 'token <token>' for the github.com/actions/node-versions/releases/... URL.
    • Requests to the mirror still use mirror-token.
Lenguaje dominante
TypeScript
Estrellas
5k
Forks
1.7k
Merge medio
5 d 1 h
PR fusionados (30 d)
1

Preparar el entorno

  • Sin Dockerfile ni archivo de Docker Compose
  • Tiene una plantilla de pull request
  • Sin guía de contribución

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de actions/setup-node

Todos los issues de actions/setup-node

Issues similares

Más issues de TypeScript

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.