`mirror-token` is sent to GitHub instead of `token` when `mirror` is set
维护者通常 7 天内回复
评估
- 难度
- 2/5
- 预计耗时
- 1-3 小时
- 新手友好度
- 82/100
- Issue 类型
- 缺陷
- 描述清晰度
- 描述清楚
- 活跃度
- 活跃
- 技术栈
- github-actions, node.js, typescript
调研方向
从 src/distributions/official_builds/official_builds.ts 中的 getManifest 和 setupNodeJs 开始,issue 指出了 manifest 请求和二进制文件下载的凭据选择。阅读 tests/official-installer.test.ts 及其中现有的 mirror-token 用例,然后添加覆盖 GitHub 和 mirror 凭据的测试。完成标准是 GitHub 请求使用 GitHub token,mirror 请求继续使用 mirror-token。
由索引模型根据 Issue 内容生成。
描述
Description:
When both mirror and mirror-token are set, setup-node sends the mirror token to GitHub. It goes to two places in official_builds.ts:
- The
actions/node-versionsmanifest request throughtc.getManifestFromRepo, ingetManifest. - The binary download through
tc.downloadTool, insetupNodeJs. This URL comes from the manifest'sdownload_url, so it always points togithub.com/actions/node-versions/releases/....
Both use this pattern:
this.nodeInfo.mirror && this.nodeInfo.mirrorToken
? this.nodeInfo.mirrorToken
: this.nodeInfo.auth
This causes two problems:
- Security: A credential meant for a private mirror, such as an Artifactory token, gets sent to a third-party host. Mirror tokens should only go to the mirror.
- Rate limits: Because the mirror token replaces the GitHub
token, manifest calls are made without the GitHub token. That makes them more likely to hit GitHub API rate limits. #1548 fixed this only for the case wheremirror-tokenis empty.
The calls that do go to the mirror already use mirrorToken correctly: getNodeJsVersions, downloadNodejs, and the Windows fallback in base-distribution.ts.
Related: #1412, #1467, #1548, #1661
Action version:
actions/setup-node@v7 (current main, 7.1.0). This happens in every version that sends mirror-token to the manifest request.
Platform:
- Ubuntu
- macOS
- Windows
Runner type:
- Hosted
- Self-hosted
Tools version:
Any Node.js version that is in the actions/node-versions manifest. This doesn't depend on the package manager.
Repro steps:
- Use this step:
- uses: actions/setup-node@v7
with:
node-version: '24.9.0'
mirror: 'https://my-mirror.example.com'
mirror-token: ${{ secrets.MIRROR_TOKEN }}
- Pick a
node-versionthat is in theactions/node-versionsmanifest and not already in the runner's tool cache. - Watch the outgoing requests, for example with a proxy. The manifest request to the GitHub API and the binary download from
github.com/actions/node-versions/releases/...both sendAuthorization: <MIRROR_TOKEN>.
Expected behavior:
Requests to GitHub always use token, sent as token <token> (this.nodeInfo.auth). mirror-token is only sent to URLs built from mirror.
Actual behavior:
mirror-token is sent to the GitHub API and to github.com release downloads instead of the GitHub token. This sends the mirror credential to GitHub, and the manifest call is made without the GitHub token.
Proposed fix:
- In
official_builds.ts, passthis.nodeInfo.authto bothtc.getManifestFromRepoand the manifest-basedtc.downloadToolcall. Remove themirror && mirrorTokenternary. - Add tests to
__tests__/official-installer.test.ts. No current test checks this case. The existingmirror-tokentests only check log messages and that a download happened. With bothmirrorandmirror-tokenset, the new tests should check that:getManifestFromRepois called with'token <token>', not the mirror token.downloadToolgets'token <token>'for thegithub.com/actions/node-versions/releases/...URL.- Requests to the mirror still use
mirror-token.
- 主要语言
- TypeScript
- 星标
- 5k
- 派生
- 1.7k
- 平均合并
- 5 天 1 小时
- 30 天内合并 PR
- 1
环境准备
- 没有 Dockerfile 或 Docker Compose 文件
- 有 Pull Request 模板
- 没有贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
actions/setup-node 的其他 Issue
-
feature request
难度 2/5 1-3 小时 新手友好度 65/100
actions/setup-node#1531 · 1 条评论 · 4 个 reaction ·
维护者通常 7 天内回复
-
bug needs triage
难度 4/5 3-5 天 新手友好度 52/100
actions/setup-node#1672 ·
维护者通常 7 天内回复
-
enhancement
难度 3/5 1-2 天 新手友好度 58/100
actions/setup-node#1670 · 1 条评论 ·
维护者通常 7 天内回复
-
Provide `allow-prereleases` (or similar) option for Node.js 27 Alpha可能已有人在做 @v-priyagupta108 于 7 天前认领。 未关闭feature request
难度 3/5 1-2 天 新手友好度 62/100
actions/setup-node#1657 · 5 条评论 · 4 个 reaction · 已指派 1 人 ·
维护者通常 7 天内回复
-
Improved error message when a required os lib is missing可能已有人在做 @OKAN-SOFTWARE 于 20 天前认领。 未关闭feature request
难度 3/5 1-2 天 新手友好度 55/100
actions/setup-node#1651 · 1 条评论 ·
维护者通常 7 天内回复
查看 actions/setup-node 的全部 Issue
相似的 Issue
-
db-d1-sqlite: upsert is aliased to updateOne, so payload.kv.set never inserts new keys可能已有人在做 @pcbeingused333 今天认领。 未关闭Bug db: d1-sqlite Payload OSS
难度 2/5 1-3 小时 新手友好度 76/100
payloadcms/payload#19766 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 68/100
device-management-toolkit/sample-web-ui#3711 ·
维护者通常 1 天内回复
-
bug impact:low Team: SecuritySolution Team:Defend Workflows v9.6.0
难度 2/5 1-3 小时 新手友好度 72/100
elastic/kibana#306401 · 3 条评论 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 68/100
agentes-chat/agentes-chat#927 ·
维护者通常 1 天内回复
-
Closing a pinned tab jumps to the Tabs section instead of the next open pinned tab可能已有人在做 @seenimohamed 今天认领。 未关闭bug
难度 2/5 1-3 小时 新手友好度 78/100
ardia-browser/ardia#2769 ·
维护者通常 1 天内回复