`mirror-token` is sent to GitHub instead of `token` when `mirror` is set

Ouverte Adaptée aux débutants
#1,662 1 commentaire 0 réactions 1 personne assignée Voir sur GitHub

Les mainteneurs répondent en général sous 7 jours

@v-gowridurgad y travaille déjà.

Depuis le 9/11/2026.

  • #1669 par @EnesKartal — ouverte

Évaluation

Difficulté
2/5
Temps estimé
1-3 heures
Accessibilité débutants
82/100
Type d'issue
Bug
Clarté
Clairement spécifiée
Activité
Active
Stack technique
github-actions, node.js, typescript
Domaine
devops, security

Piste de recherche

Commencez dans src/distributions/official_builds/official_builds.ts, au niveau de getManifest et setupNodeJs, où l’issue identifie la sélection des identifiants pour la requête du manifeste et le téléchargement du binaire. Lisez tests/official-installer.test.ts et ses cas existants concernant mirror-token, puis ajoutez des tests pour les identifiants GitHub et mirror. Le travail est terminé lorsque les requêtes GitHub utilisent le jeton GitHub et que les requêtes mirror continuent d’utiliser mirror-token.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Description

bug

Description:
When both mirror and mirror-token are set, setup-node sends the mirror token to GitHub. It goes to two places in official_builds.ts:

  1. The actions/node-versions manifest request through tc.getManifestFromRepo, in getManifest.
  2. The binary download through tc.downloadTool, in setupNodeJs. This URL comes from the manifest's download_url, so it always points to github.com/actions/node-versions/releases/....

Both use this pattern:

this.nodeInfo.mirror && this.nodeInfo.mirrorToken
  ? this.nodeInfo.mirrorToken
  : this.nodeInfo.auth

This causes two problems:

  • Security: A credential meant for a private mirror, such as an Artifactory token, gets sent to a third-party host. Mirror tokens should only go to the mirror.
  • Rate limits: Because the mirror token replaces the GitHub token, manifest calls are made without the GitHub token. That makes them more likely to hit GitHub API rate limits. #1548 fixed this only for the case where mirror-token is empty.

The calls that do go to the mirror already use mirrorToken correctly: getNodeJsVersions, downloadNodejs, and the Windows fallback in base-distribution.ts.

Related: #1412, #1467, #1548, #1661

Action version:
actions/setup-node@v7 (current main, 7.1.0). This happens in every version that sends mirror-token to the manifest request.

Platform:

  • Ubuntu
  • macOS
  • Windows

Runner type:

  • Hosted
  • Self-hosted

Tools version:

Any Node.js version that is in the actions/node-versions manifest. This doesn't depend on the package manager.

Repro steps:

  1. Use this step:
- uses: actions/setup-node@v7
  with:
    node-version: '24.9.0'
    mirror: 'https://my-mirror.example.com'
    mirror-token: ${{ secrets.MIRROR_TOKEN }}
  1. Pick a node-version that is in the actions/node-versions manifest and not already in the runner's tool cache.
  2. Watch the outgoing requests, for example with a proxy. The manifest request to the GitHub API and the binary download from github.com/actions/node-versions/releases/... both send Authorization: <MIRROR_TOKEN>.

Expected behavior:
Requests to GitHub always use token, sent as token <token> (this.nodeInfo.auth). mirror-token is only sent to URLs built from mirror.

Actual behavior:
mirror-token is sent to the GitHub API and to github.com release downloads instead of the GitHub token. This sends the mirror credential to GitHub, and the manifest call is made without the GitHub token.

Proposed fix:

  • In official_builds.ts, pass this.nodeInfo.auth to both tc.getManifestFromRepo and the manifest-based tc.downloadTool call. Remove the mirror && mirrorToken ternary.
  • Add tests to __tests__/official-installer.test.ts. No current test checks this case. The existing mirror-token tests only check log messages and that a download happened. With both mirror and mirror-token set, the new tests should check that:
    • getManifestFromRepo is called with 'token <token>', not the mirror token.
    • downloadTool gets 'token <token>' for the github.com/actions/node-versions/releases/... URL.
    • Requests to the mirror still use mirror-token.
Langage dominant
TypeScript
Étoiles
5k
Forks
1.7k
Merge moyen
5 j 1 h
PR mergées (30 j)
1

Préparer son environnement

  • Aucun Dockerfile ni fichier Docker Compose
  • Propose un modèle de pull request
  • Aucun guide de contribution

Par où commencer

  1. Lisez l'issue en entier, puis le guide de contribution du projet.
  2. Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
  3. Forkez le dépôt et travaillez sur une branche.
  4. Ouvrez une pull request qui référence le numéro de l'issue.

Autres issues de actions/setup-node

Toutes les issues de actions/setup-node

Issues similaires

Plus d'issues TypeScript

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.