`lazyRouteComponent` shares a pending import across requests on the server: on Cloudflare Workers one cancelled request breaks the route for the isolate
Maintainer antworten meist innerhalb von 1 Tag
Bewertung
- Schwierigkeit
- 3/5
- Geschätzter Aufwand
- 1-2 Tage
- Anfängerfreundlichkeit
- 72/100
- Issue-Typ
- Bug
- Klarheit
- Klar beschrieben
- Aktivitätsstatus
- Aktiv
- Tech-Stack
- react, typescript
- Bereich
- backend, performance
Rechercherichtung
Start with packages/react-router/src/lazyRouteComponent.tsx, especially the server and client paths around loadPromise; the issue includes a reproduction and a proposed server-side fix. Run the reproducer in the linked repository, then verify that cancelling an import request no longer makes later requests for the same route fail, while the existing client behavior remains intact.
Vom Indexierungsmodell aus dem Issue-Text verfasst.
Beschreibung
Which project does this relate to?
Router
Describe the bug
On Cloudflare Workers a promise only settles in the request that created it (handle_cross_request_promise_resolution, default since 2024-10-14). On the server, lazyRouteComponent keeps loadPromise for later requests (by design, "SSR can reuse the import"):
If the request that started the import is cancelled before it settles, loadPromise never settles and is never cleared. Every later SSR of that route fails ("Something went wrong!", 500) until the isolate is recycled; other routes keep working.
Reproduction: in 20/20 runs, every later /about answers 500 while / stays 200; with the diff below, 0/20.
Suggested fix, server branch only (keep the component, not the promise):
const load = () => {
+ if (isServer ?? typeof window === 'undefined') {
+ if (comp) {
+ return Promise.resolve()
+ }
+ error = undefined
+ return importer()
+ .then((res) => {
+ comp ??= res[exportName ?? 'default']
+ })
+ .catch((err) => {
+ error = err
+ })
+ }
if (!loadPromise) {
Complete minimal reproducer
https://github.com/LlamaLtda/workers-lazy-import-cross-request-repro/tree/main/tanstack-router
Steps to Reproduce the Bug
cd tanstack-router && npm install && npm run repro- The script starts
wrangler devwith the app (router SSR in a plain Worker,/aboutuseslazyRouteComponent) and a second Worker that calls it through a service binding. - It requests
/, then requests/aboutand aborts that call while the component import is pending (the importer waits 200 ms beforeimport()to make the window deterministic). Aborting a service-binding call cancels the callee's request, as Cloudflare does when a visitor leaves. - It requests
/aboutand/five more times and prints the statuses.npm run repro -- --fixedapplies the diff above.
Also reproduced inside a default TanStack Start app, where autoCodeSplitting wraps every route component in lazyRouteComponent on the server (tanstack-start/, --mode route-component): 20/20, and 0/20 with the diff above.
Expected behavior
Cancelling one request affects only that request: later /about requests answer 200. Instead they answer 500 with Error: This promise was created by a request that has since ended, so it can never settle. serialized in the page.
Platform
- Router / Start Version: @tanstack/react-router 1.170.46 (latest), router-core 1.171.39; Start case: @tanstack/react-start 1.169.5
- OS: Linux x64
- Browser: n/a (server-side)
- Bundler: wrangler 4.164.0 (esbuild) for the Router case; vite 8.3.8 + @cloudflare/vite-plugin 1.70.0 for the Start case
- Runtime: workerd via
wrangler dev,compatibility_date2026-11-01
Additional context
router-core'sloadRouteChunkkeepsroute._lazythe same way (load-client.ts L80-L105); not exercised here (.lazy()routes).- Start has the same pattern in
getEntriesand the manifest caches: TanStack/router#8951. Also h3 (h3js/h3#1661), Nitro (nitrojs/nitro#5153), and Astro (withastro/astro#18764, fixed).
AI disclosure: this report was written and filed by an AI agent (Claude Code) acting for the owner of this account, on the project where the bug was hit in production. The agent built and ran the reproduction; the raw outputs are in the repo's results/ folder.
- Vorherrschende Sprache
- TypeScript
- Sterne
- 15.3k
- Forks
- 1.9k
- Ø Merge
- 1 T. 5 Std.
- Gemergte PRs (30 T.)
- 46
Entwicklungsumgebung
Startet den Dev-Container des Projekts im Browser, mit Ihrem eigenen GitHub-Konto.
- Kein Dockerfile und keine Docker-Compose-Datei
- Hat eine Pull-Request-Vorlage
- Beitragsleitfaden lesen
Erste Schritte
- Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
- Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
- Forken Sie das Repository und arbeiten Sie in einem Branch.
- Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.
Mehr aus TanStack/router
-
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 85/100
Maintainer antworten meist innerhalb von 1 Tag
-
Masked navigation drops the first character of the hash each time (__tempLocation hash missing '#')Evtl. vergeben @hassanabrar202 hat das vor 8 Tagen übernommen. Offen
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 72/100
Maintainer antworten meist innerhalb von 1 Tag
-
router-generator: lazy-load Prettier (costs ~300–450ms per build even when formatting is off)Evtl. vergeben @Sheraff hat das vor 27 Tagen übernommen. Offenpackage: router-generator performance
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 85/100
Maintainer antworten meist innerhalb von 1 Tag
-
router-generator: sibling `physical()` subtrees in a virtual route config generate duplicate identifiersEvtl. vergeben @Sheraff hat das vor 27 Tagen übernommen. Offen
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 76/100
Maintainer antworten meist innerhalb von 1 Tag
-
docs(router): clarify static title fallback in SPA modeEvtl. vergeben @Rohan-Dedhia hat das vor 17 Tagen übernommen. Offen
Schwierigkeit 1/5 1-3 Stunden Anfängerfreundlichkeit 62/100
Maintainer antworten meist innerhalb von 1 Tag
Alle Issues in TanStack/router
Ähnliche Issues
-
[BUG]: Shared links drop the configured basePath on GitHub PagesEvtl. vergeben @anshulchikhale30-p hat das heute übernommen. Offenbug
Schwierigkeit 1/5 Unter einer Stunde Anfängerfreundlichkeit 88/100
StabilityNexus/IdentityTokens-EVM-Frontend#182 · 1 Kommentar ·
Maintainer antworten meist innerhalb von 1 Tag
-
Add: GTrekkerOffencheck:passed streams:add
Schwierigkeit 1/5 Unter einer Stunde Anfängerfreundlichkeit 72/100
Maintainer antworten meist innerhalb von 1 Tag
-
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 70/100
Koenkk/zigbee-herdsman-converters#13900 ·
Maintainer antworten meist innerhalb von 1 Tag
-
area: ui Bug Payload OSS
Schwierigkeit 1/5 Unter einer Stunde Anfängerfreundlichkeit 88/100
payloadcms/payload#19839 ·
Maintainer antworten meist innerhalb von 1 Tag
-
Schwierigkeit 1/5 Unter einer Stunde Anfängerfreundlichkeit 88/100
jeanibarz/knowledge-base-mcp-server#1291 ·
Maintainer antworten meist innerhalb von 1 Tag