`lazyRouteComponent` shares a pending import across requests on the server: on Cloudflare Workers one cancelled request breaks the route for the isolate

オープン
#8,950 コメント 0 件 リアクション 0 件 担当者 0 名 GitHub で見る

メンテナーはふだん 1 日以内に返信

@gentil93 がすでに取り組んでいます。

2026年11月19日 から。

  • #8966 @gentil93 による — オープン

評価

難易度
3/5
見積もり時間
1〜2日
初心者へのやさしさ
72/100
issue の種類
バグ
明瞭さ
明確に書かれている
活発さ
活発
技術スタック
react, typescript

調査の方向性

Start with packages/react-router/src/lazyRouteComponent.tsx, especially the server and client paths around loadPromise; the issue includes a reproduction and a proposed server-side fix. Run the reproducer in the linked repository, then verify that cancelling an import request no longer makes later requests for the same route fail, while the existing client behavior remains intact.

索引モデルが issue の本文から書いたものです。

説明

Which project does this relate to?

Router

Describe the bug

On Cloudflare Workers a promise only settles in the request that created it (handle_cross_request_promise_resolution, default since 2024-10-14). On the server, lazyRouteComponent keeps loadPromise for later requests (by design, "SSR can reuse the import"):

https://github.com/TanStack/router/blob/6b9fe6d29552270836c511bc9b343d73541f4424/packages/react-router/src/lazyRouteComponent.tsx#L25-L50

If the request that started the import is cancelled before it settles, loadPromise never settles and is never cleared. Every later SSR of that route fails ("Something went wrong!", 500) until the isolate is recycled; other routes keep working.

Reproduction: in 20/20 runs, every later /about answers 500 while / stays 200; with the diff below, 0/20.

Suggested fix, server branch only (keep the component, not the promise):

   const load = () => {
+    if (isServer ?? typeof window === 'undefined') {
+      if (comp) {
+        return Promise.resolve()
+      }
+      error = undefined
+      return importer()
+        .then((res) => {
+          comp ??= res[exportName ?? 'default']
+        })
+        .catch((err) => {
+          error = err
+        })
+    }
     if (!loadPromise) {
Complete minimal reproducer

https://github.com/LlamaLtda/workers-lazy-import-cross-request-repro/tree/main/tanstack-router

Steps to Reproduce the Bug
  1. cd tanstack-router && npm install && npm run repro
  2. The script starts wrangler dev with the app (router SSR in a plain Worker, /about uses lazyRouteComponent) and a second Worker that calls it through a service binding.
  3. It requests /, then requests /about and aborts that call while the component import is pending (the importer waits 200 ms before import() to make the window deterministic). Aborting a service-binding call cancels the callee's request, as Cloudflare does when a visitor leaves.
  4. It requests /about and / five more times and prints the statuses. npm run repro -- --fixed applies the diff above.

Also reproduced inside a default TanStack Start app, where autoCodeSplitting wraps every route component in lazyRouteComponent on the server (tanstack-start/, --mode route-component): 20/20, and 0/20 with the diff above.

Expected behavior

Cancelling one request affects only that request: later /about requests answer 200. Instead they answer 500 with Error: This promise was created by a request that has since ended, so it can never settle. serialized in the page.

Platform
  • Router / Start Version: @tanstack/react-router 1.170.46 (latest), router-core 1.171.39; Start case: @tanstack/react-start 1.169.5
  • OS: Linux x64
  • Browser: n/a (server-side)
  • Bundler: wrangler 4.164.0 (esbuild) for the Router case; vite 8.3.8 + @cloudflare/vite-plugin 1.70.0 for the Start case
  • Runtime: workerd via wrangler dev, compatibility_date 2026-11-01
Additional context
  • router-core's loadRouteChunk keeps route._lazy the same way (load-client.ts L80-L105); not exercised here (.lazy() routes).
  • Start has the same pattern in getEntries and the manifest caches: TanStack/router#8951. Also h3 (h3js/h3#1661), Nitro (nitrojs/nitro#5153), and Astro (withastro/astro#18764, fixed).

AI disclosure: this report was written and filed by an AI agent (Claude Code) acting for the owner of this account, on the project where the bug was hit in production. The agent built and ran the reproduction; the raw outputs are in the repo's results/ folder.

主要言語
TypeScript
スター
15.3k
フォーク
1.9k
平均マージ
1日 5時間
マージ済み PR(30日)
46

環境構築

Codespaces で開く

このプロジェクトの開発コンテナを、あなたの GitHub アカウントでブラウザ上に起動します。

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

TanStack/router のほかの issue

TanStack/router の issue をすべて見る

似ている issue

TypeScript の issue をもっと見る

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。