`lazyRouteComponent` shares a pending import across requests on the server: on Cloudflare Workers one cancelled request breaks the route for the isolate

未关闭
#8,950 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

@gentil93 已经在做这个了。

开始于 2026年11月19日。

  • #8966 来自 @gentil93 —— 未关闭

评估

难度
3/5
预计耗时
1-2 天
新手友好度
72/100
Issue 类型
缺陷
描述清晰度
描述清楚
活跃度
活跃
技术栈
react, typescript

调研方向

Start with packages/react-router/src/lazyRouteComponent.tsx, especially the server and client paths around loadPromise; the issue includes a reproduction and a proposed server-side fix. Run the reproducer in the linked repository, then verify that cancelling an import request no longer makes later requests for the same route fail, while the existing client behavior remains intact.

由索引模型根据 Issue 内容生成。

描述

Which project does this relate to?

Router

Describe the bug

On Cloudflare Workers a promise only settles in the request that created it (handle_cross_request_promise_resolution, default since 2024-10-14). On the server, lazyRouteComponent keeps loadPromise for later requests (by design, "SSR can reuse the import"):

https://github.com/TanStack/router/blob/6b9fe6d29552270836c511bc9b343d73541f4424/packages/react-router/src/lazyRouteComponent.tsx#L25-L50

If the request that started the import is cancelled before it settles, loadPromise never settles and is never cleared. Every later SSR of that route fails ("Something went wrong!", 500) until the isolate is recycled; other routes keep working.

Reproduction: in 20/20 runs, every later /about answers 500 while / stays 200; with the diff below, 0/20.

Suggested fix, server branch only (keep the component, not the promise):

   const load = () => {
+    if (isServer ?? typeof window === 'undefined') {
+      if (comp) {
+        return Promise.resolve()
+      }
+      error = undefined
+      return importer()
+        .then((res) => {
+          comp ??= res[exportName ?? 'default']
+        })
+        .catch((err) => {
+          error = err
+        })
+    }
     if (!loadPromise) {
Complete minimal reproducer

https://github.com/LlamaLtda/workers-lazy-import-cross-request-repro/tree/main/tanstack-router

Steps to Reproduce the Bug
  1. cd tanstack-router && npm install && npm run repro
  2. The script starts wrangler dev with the app (router SSR in a plain Worker, /about uses lazyRouteComponent) and a second Worker that calls it through a service binding.
  3. It requests /, then requests /about and aborts that call while the component import is pending (the importer waits 200 ms before import() to make the window deterministic). Aborting a service-binding call cancels the callee's request, as Cloudflare does when a visitor leaves.
  4. It requests /about and / five more times and prints the statuses. npm run repro -- --fixed applies the diff above.

Also reproduced inside a default TanStack Start app, where autoCodeSplitting wraps every route component in lazyRouteComponent on the server (tanstack-start/, --mode route-component): 20/20, and 0/20 with the diff above.

Expected behavior

Cancelling one request affects only that request: later /about requests answer 200. Instead they answer 500 with Error: This promise was created by a request that has since ended, so it can never settle. serialized in the page.

Platform
  • Router / Start Version: @tanstack/react-router 1.170.46 (latest), router-core 1.171.39; Start case: @tanstack/react-start 1.169.5
  • OS: Linux x64
  • Browser: n/a (server-side)
  • Bundler: wrangler 4.164.0 (esbuild) for the Router case; vite 8.3.8 + @cloudflare/vite-plugin 1.70.0 for the Start case
  • Runtime: workerd via wrangler dev, compatibility_date 2026-11-01
Additional context
  • router-core's loadRouteChunk keeps route._lazy the same way (load-client.ts L80-L105); not exercised here (.lazy() routes).
  • Start has the same pattern in getEntries and the manifest caches: TanStack/router#8951. Also h3 (h3js/h3#1661), Nitro (nitrojs/nitro#5153), and Astro (withastro/astro#18764, fixed).

AI disclosure: this report was written and filed by an AI agent (Claude Code) acting for the owner of this account, on the project where the bug was hit in production. The agent built and ran the reproduction; the raw outputs are in the repo's results/ folder.

主要语言
TypeScript
星标
15.3k
派生
1.9k
平均合并
1 天 5 小时
30 天内合并 PR
46

环境准备

在 Codespaces 中打开

在浏览器里用你自己的 GitHub 账号启动这个项目的开发容器。

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

TanStack/router 的其他 Issue

查看 TanStack/router 的全部 Issue

相似的 Issue

更多 TypeScript Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。