`lazyRouteComponent` shares a pending import across requests on the server: on Cloudflare Workers one cancelled request breaks the route for the isolate

Đang mở
#8,950 0 bình luận 0 reaction 0 người được giao Xem trên GitHub

Maintainer thường phản hồi trong vòng 1 ngày

@gentil93 đang làm issue này rồi.

Từ ngày 19/11/2026.

  • #8966 của @gentil93 — đang mở

Đánh giá

Độ khó
3/5
Thời gian dự kiến
1-2 ngày
Mức phù hợp với người mới
72/100
Loại issue
Lỗi
Độ rõ ràng
Đặc tả rõ ràng
Mức độ hoạt động
Sôi nổi
Công nghệ
react, typescript
Lĩnh vực
backend, performance

Hướng nghiên cứu

Start with packages/react-router/src/lazyRouteComponent.tsx, especially the server and client paths around loadPromise; the issue includes a reproduction and a proposed server-side fix. Run the reproducer in the linked repository, then verify that cancelling an import request no longer makes later requests for the same route fail, while the existing client behavior remains intact.

Do mô hình lập chỉ mục viết ra từ nội dung của issue.

Mô tả

Which project does this relate to?

Router

Describe the bug

On Cloudflare Workers a promise only settles in the request that created it (handle_cross_request_promise_resolution, default since 2024-10-14). On the server, lazyRouteComponent keeps loadPromise for later requests (by design, "SSR can reuse the import"):

https://github.com/TanStack/router/blob/6b9fe6d29552270836c511bc9b343d73541f4424/packages/react-router/src/lazyRouteComponent.tsx#L25-L50

If the request that started the import is cancelled before it settles, loadPromise never settles and is never cleared. Every later SSR of that route fails ("Something went wrong!", 500) until the isolate is recycled; other routes keep working.

Reproduction: in 20/20 runs, every later /about answers 500 while / stays 200; with the diff below, 0/20.

Suggested fix, server branch only (keep the component, not the promise):

   const load = () => {
+    if (isServer ?? typeof window === 'undefined') {
+      if (comp) {
+        return Promise.resolve()
+      }
+      error = undefined
+      return importer()
+        .then((res) => {
+          comp ??= res[exportName ?? 'default']
+        })
+        .catch((err) => {
+          error = err
+        })
+    }
     if (!loadPromise) {
Complete minimal reproducer

https://github.com/LlamaLtda/workers-lazy-import-cross-request-repro/tree/main/tanstack-router

Steps to Reproduce the Bug
  1. cd tanstack-router && npm install && npm run repro
  2. The script starts wrangler dev with the app (router SSR in a plain Worker, /about uses lazyRouteComponent) and a second Worker that calls it through a service binding.
  3. It requests /, then requests /about and aborts that call while the component import is pending (the importer waits 200 ms before import() to make the window deterministic). Aborting a service-binding call cancels the callee's request, as Cloudflare does when a visitor leaves.
  4. It requests /about and / five more times and prints the statuses. npm run repro -- --fixed applies the diff above.

Also reproduced inside a default TanStack Start app, where autoCodeSplitting wraps every route component in lazyRouteComponent on the server (tanstack-start/, --mode route-component): 20/20, and 0/20 with the diff above.

Expected behavior

Cancelling one request affects only that request: later /about requests answer 200. Instead they answer 500 with Error: This promise was created by a request that has since ended, so it can never settle. serialized in the page.

Platform
  • Router / Start Version: @tanstack/react-router 1.170.46 (latest), router-core 1.171.39; Start case: @tanstack/react-start 1.169.5
  • OS: Linux x64
  • Browser: n/a (server-side)
  • Bundler: wrangler 4.164.0 (esbuild) for the Router case; vite 8.3.8 + @cloudflare/vite-plugin 1.70.0 for the Start case
  • Runtime: workerd via wrangler dev, compatibility_date 2026-11-01
Additional context
  • router-core's loadRouteChunk keeps route._lazy the same way (load-client.ts L80-L105); not exercised here (.lazy() routes).
  • Start has the same pattern in getEntries and the manifest caches: TanStack/router#8951. Also h3 (h3js/h3#1661), Nitro (nitrojs/nitro#5153), and Astro (withastro/astro#18764, fixed).

AI disclosure: this report was written and filed by an AI agent (Claude Code) acting for the owner of this account, on the project where the bug was hit in production. The agent built and ran the reproduction; the raw outputs are in the repo's results/ folder.

Ngôn ngữ chính
TypeScript
Star
15.3k
Fork
1.9k
Merge trung bình
1 ngày 5 giờ
Pull request đã merge (30 ngày)
46

Chuẩn bị môi trường

Mở trong Codespaces

Khởi chạy dev container của dự án ngay trên trình duyệt, bằng tài khoản GitHub của bạn.

Bắt đầu từ đâu

  1. Đọc hết issue, rồi đọc hướng dẫn đóng góp của dự án.
  2. Bình luận trên issue rằng bạn sẽ nhận — tránh hai người làm cùng một việc.
  3. Fork repository và làm thay đổi trên một nhánh.
  4. Mở pull request có tham chiếu số hiệu của issue.

Issue khác của TanStack/router

Tất cả issue của TanStack/router

Issue tương tự

Thêm issue về TypeScript

Nhận issue mới trong hộp thư của bạn

Bản tóm tắt ngắn những issue GitHub phù hợp với người mới.