Ordered loader retains earlier requests after a newer authoritative read succeeds

Offen
#2,296 0 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen

Maintainer antworten meist innerhalb von 1 Tag

Dieses Issue hat noch niemand übernommen.

Bewertung

Schwierigkeit
4/5
Geschätzter Aufwand
3-5 Tage
Anfängerfreundlichkeit
35/100
Issue-Typ
Bug
Klarheit
Größtenteils klar
Aktivitätsstatus
Aktiv
Tech-Stack
typescript
Bereich
backend, testing

Rechercherichtung

Start with packages/db/tests/query/ordered-source-loader-state-oracle.test.ts, especially checkAuthorityCase near line 1632, and replay the recorded seed and path on the specified commit. Compare production request retirement with the oracle’s model and observation checkpoint, then exercise the nearby synchronous repair, release-triggered truncate, and joined-work histories. Done means the original failure is reproduced, a repair passes the shared comparisons, a hostile mutant fails, and a real Collection or provider witness supports any public resource claim.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Beschreibung

The Release workflow for the first RC failed the ordered-loader request-authority oracle on merged release commit 71bf598a3d13d37db28ac112431fd8be790957fe (#2217).

Executed CI evidence

  • Failed Test (db-2) job
  • Owner: packages/db/tests/query/ordered-source-loader-state-oracle.test.ts
  • Test: holds, retires, and recovers requests under generated settlement orders (random campaign)
  • Property: ordered-loader.request-authority
  • Seed: -845274422
  • Path: 2109:1:3:6:4:8:10:13:15
  • Failed after 2,110 generated tests, shrunk eight times.
  • Assertion checkpoint: checkAuthorityCase, line 1632, after the history drain and any explicit retry.
no leak: requests [3,4] are still held after authoritative request 5 succeeded
{"indexed":false,"limit":1,"settledFirst":true,"releaseFault":false,"syncRepair":true,"requiresFullSource":false,"joined":true,"snapshotRows":1,"needsMore":true,"retryTimer":false,"releaseTruncates":true,"offset":0,"releaseReenters":false,"releaseDisposes":false,"history":[{"type":"settle","pick":0,"ok":true},{"type":"settle","pick":0,"ok":true},{"type":"report","react":false},{"type":"move","delta":-1},{"type":"joinedBusy"},{"type":"settleNewest"}]}

Accepted law and limits of this report

The owner's “No leak” law states that once loading is quiet and no failure blocks it, the loader holds nothing issued before its last successful authoritative read. Retained demands can be read again on later refetches. The oracle uses the real loader with a controlled subscription; this mismatch establishes a failing request-ledger comparison, not incorrect public query rows or a measured production resource leak. Diagnose production retirement versus the oracle's model, replay ownership and observation checkpoint before changing either one.

This exact trace has not yet been replayed independently. The observed assertion is from the executed CI run; it is not a timeout or a reach failure.

Replay

Run from packages/db on the recorded commit:

TANSTACK_DB_ORACLE_PROPERTY=ordered-loader.request-authority \
TANSTACK_DB_ORACLE_SEED=-845274422 \
TANSTACK_DB_ORACLE_PATH=2109:1:3:6:4:8:10:13:15 \
pnpm exec vitest run --coverage.enabled=false --typecheck.enabled=false \
  tests/query/ordered-source-loader-state-oracle.test.ts -t 'random campaign'

Keep this history in the shared comparison and exercise nearby synchronous repair, release-triggered truncate and joined-work histories before a production repair. Show RED on the original code, GREEN after repair and a hostile mutant that fails. A real Collection/provider receiving witness is needed before claiming the public resource consequence is closed.

Related loader retirement investigations: #2223 (failed request across cursor reset) and #2191 (request authority/retirement). This trace has only successful explicit settlements; identity with either earlier report is not established. It is separate from the publication-retention report #2294 and multi-tab Electric report #2281.

The maintainer explicitly approved recording this counterexample as a follow-up and retrying the first RC release while leaving the defect open. No test, comparison or run budget has been weakened. A passing retry does not close this issue.

Vorherrschende Sprache
TypeScript
Sterne
4k
Forks
277
Ø Merge
1 T. 7 Std.
Gemergte PRs (30 T.)
170

Entwicklungsumgebung

Erste Schritte

  1. Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
  2. Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
  3. Forken Sie das Repository und arbeiten Sie in einem Branch.
  4. Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.

Mehr aus TanStack/db

Alle Issues in TanStack/db

Ähnliche Issues

Weitere Issues zu TypeScript

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.