Hacktoberfest 2026: die Issues, die Maintainer für den Oktober markiert haben – offen und einsteigerfreundlich. Hacktoberfest-Issues durchsuchen

Request: SQLite compiler falls back to full-table reads for zero/one-argument AND and OR

Geschlossen
  • Stimmt etwas nicht?
#1,994 0 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen

Maintainer antworten meist innerhalb von 1 Tag

Dieses Issue hat noch niemand übernommen.

Bewertung

Schwierigkeit
3/5
Geschätzter Aufwand
1-2 Tage
Anfängerfreundlichkeit
68/100
Issue-Typ
Bug
Klarheit
Größtenteils klar
Aktivitätsstatus
Aktiv
Tech-Stack
sqlite, typescript
Bereich
database

Rechercherichtung

Start by locating the SQLite persistence SQL compiler and inspect its handling of and/or expressions with zero or one argument. Check the existing compiler tests and the downstream regression assertion for the generated SQL. Done means one-argument predicates compile directly, empty and/or become true/false predicates, and unsupported children retain fallback behavior.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Beschreibung

Problem

The SQLite persistence compiler marks and and or expressions with fewer than two arguments as unsupported.

loadSubsetInternal then omits the SQL WHERE clause, reads and deserializes the entire collection, and filters the rows in JavaScript.

Results can still be correct, but a selective query—or a query that should return no rows—does unnecessary work over the whole cached table.

Versions

  • @tanstack/db-sqlite-persistence-core: 0.4.0
  • @tanstack/browser-db-sqlite-persistence: 0.2.25
  • @tanstack/db: 0.11.0

The same compiler checks are present in upstream main inspected on October 2, 2026.

Reproduction

Populate a persisted collection with many rows and instrument the SQL passed to its driver:

import { IR } from '@tanstack/db'

const predicate = new IR.Func('eq', [
  new IR.PropRef(['id']),
  new IR.Value('row-1'),
])

await adapter.loadSubset(collectionId, {
  where: new IR.Func('and', [predicate]),
})

await adapter.loadSubset(collectionId, {
  where: new IR.Func('or', [predicate]),
})

await adapter.loadSubset(collectionId, {
  where: new IR.Func('or', []),
})

Source inspection shows that each expression is rejected by the SQL compiler. The resulting collection read has no WHERE clause.

The empty or case is particularly wasteful: the final result is empty, but the adapter first reads every persisted row.

Expected behavior

Compile these expressions consistently with the core evaluator:

  • One-argument and or or: compile the contained predicate.
  • Empty and: compile a true predicate.
  • Empty or: compile a false predicate.

Unsupported child expressions should retain the existing fallback behavior.

Downstream workaround

We add these cases to the SQLite compiler. An existing downstream regression assertion checks that an empty-result initialization query includes WHERE (0 = 1) rather than reading the entire cache.

This report is based on source inspection; downstream tests were not rerun for this report.

Related issue

#506 discusses zero/one-argument support in the public query API. This report specifically concerns SQL compilation and full-table fallback in the persistence adapter.

Vorherrschende Sprache
TypeScript
Sterne
4k
Forks
277
Ø Merge
17 Std. 40 Min.
Gemergte PRs (30 T.)
223

Entwicklungsumgebung

Erste Schritte

  1. Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
  2. Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
  3. Forken Sie das Repository und arbeiten Sie in einem Branch.
  4. Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.

Mehr aus TanStack/db

Alle Issues in TanStack/db

Ähnliche Issues

Weitere Issues zu TypeScript

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.