Hacktoberfest 2026 : les issues que les mainteneurs ont marquées pour octobre, ouvertes et accessibles aux débutants. Parcourir les issues Hacktoberfest

Request: SQLite compiler falls back to full-table reads for zero/one-argument AND and OR

Fermée
  • Quelque chose ne va pas ?
#1,994 0 commentaires 0 réactions 0 personnes assignées Voir sur GitHub

Les mainteneurs répondent en général sous 1 jour

Personne n'a encore pris cette issue.

Évaluation

Difficulté
3/5
Temps estimé
1-2 jours
Accessibilité débutants
68/100
Type d'issue
Bug
Clarté
Plutôt claire
Activité
Active
Stack technique
sqlite, typescript
Domaine
database

Piste de recherche

Start by locating the SQLite persistence SQL compiler and inspect its handling of and/or expressions with zero or one argument. Check the existing compiler tests and the downstream regression assertion for the generated SQL. Done means one-argument predicates compile directly, empty and/or become true/false predicates, and unsupported children retain fallback behavior.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Description

Problem

The SQLite persistence compiler marks and and or expressions with fewer than two arguments as unsupported.

loadSubsetInternal then omits the SQL WHERE clause, reads and deserializes the entire collection, and filters the rows in JavaScript.

Results can still be correct, but a selective query—or a query that should return no rows—does unnecessary work over the whole cached table.

Versions

  • @tanstack/db-sqlite-persistence-core: 0.4.0
  • @tanstack/browser-db-sqlite-persistence: 0.2.25
  • @tanstack/db: 0.11.0

The same compiler checks are present in upstream main inspected on October 2, 2026.

Reproduction

Populate a persisted collection with many rows and instrument the SQL passed to its driver:

import { IR } from '@tanstack/db'

const predicate = new IR.Func('eq', [
  new IR.PropRef(['id']),
  new IR.Value('row-1'),
])

await adapter.loadSubset(collectionId, {
  where: new IR.Func('and', [predicate]),
})

await adapter.loadSubset(collectionId, {
  where: new IR.Func('or', [predicate]),
})

await adapter.loadSubset(collectionId, {
  where: new IR.Func('or', []),
})

Source inspection shows that each expression is rejected by the SQL compiler. The resulting collection read has no WHERE clause.

The empty or case is particularly wasteful: the final result is empty, but the adapter first reads every persisted row.

Expected behavior

Compile these expressions consistently with the core evaluator:

  • One-argument and or or: compile the contained predicate.
  • Empty and: compile a true predicate.
  • Empty or: compile a false predicate.

Unsupported child expressions should retain the existing fallback behavior.

Downstream workaround

We add these cases to the SQLite compiler. An existing downstream regression assertion checks that an empty-result initialization query includes WHERE (0 = 1) rather than reading the entire cache.

This report is based on source inspection; downstream tests were not rerun for this report.

Related issue

#506 discusses zero/one-argument support in the public query API. This report specifically concerns SQL compilation and full-table fallback in the persistence adapter.

Langage dominant
TypeScript
Étoiles
4k
Forks
277
Merge moyen
18 h 49 min
PR mergées (30 j)
224

Préparer son environnement

Par où commencer

  1. Lisez l'issue en entier, puis le guide de contribution du projet.
  2. Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
  3. Forkez le dépôt et travaillez sur une branche.
  4. Ouvrez une pull request qui référence le numéro de l'issue.

Autres issues de TanStack/db

Toutes les issues de TanStack/db

Issues similaires

Plus d'issues TypeScript

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.