Hacktoberfest 2026: as issues que os mantenedores marcaram para outubro, abertas e boas para iniciantes. Ver issues do Hacktoberfest

Request: SQLite compiler falls back to full-table reads for zero/one-argument AND and OR

Fechada
  • Algo errado?
#1,994 0 comentários 0 reações 0 responsáveis Ver no GitHub

Mantenedores costumam responder em até 1 dia

Ninguém assumiu esta issue ainda.

Avaliação

Dificuldade
3/5
Tempo estimado
1-2 dias
Facilidade para iniciantes
68/100
Tipo de issue
Bug
Clareza
Razoavelmente clara
Status de atividade
Ativa
Stack de tecnologia
sqlite, typescript
Domínio
database

Direção de pesquisa

Start by locating the SQLite persistence SQL compiler and inspect its handling of and/or expressions with zero or one argument. Check the existing compiler tests and the downstream regression assertion for the generated SQL. Done means one-argument predicates compile directly, empty and/or become true/false predicates, and unsupported children retain fallback behavior.

Escrita pelo modelo de indexação a partir do texto da issue.

Descrição

Problem

The SQLite persistence compiler marks and and or expressions with fewer than two arguments as unsupported.

loadSubsetInternal then omits the SQL WHERE clause, reads and deserializes the entire collection, and filters the rows in JavaScript.

Results can still be correct, but a selective query—or a query that should return no rows—does unnecessary work over the whole cached table.

Versions

  • @tanstack/db-sqlite-persistence-core: 0.4.0
  • @tanstack/browser-db-sqlite-persistence: 0.2.25
  • @tanstack/db: 0.11.0

The same compiler checks are present in upstream main inspected on October 2, 2026.

Reproduction

Populate a persisted collection with many rows and instrument the SQL passed to its driver:

import { IR } from '@tanstack/db'

const predicate = new IR.Func('eq', [
  new IR.PropRef(['id']),
  new IR.Value('row-1'),
])

await adapter.loadSubset(collectionId, {
  where: new IR.Func('and', [predicate]),
})

await adapter.loadSubset(collectionId, {
  where: new IR.Func('or', [predicate]),
})

await adapter.loadSubset(collectionId, {
  where: new IR.Func('or', []),
})

Source inspection shows that each expression is rejected by the SQL compiler. The resulting collection read has no WHERE clause.

The empty or case is particularly wasteful: the final result is empty, but the adapter first reads every persisted row.

Expected behavior

Compile these expressions consistently with the core evaluator:

  • One-argument and or or: compile the contained predicate.
  • Empty and: compile a true predicate.
  • Empty or: compile a false predicate.

Unsupported child expressions should retain the existing fallback behavior.

Downstream workaround

We add these cases to the SQLite compiler. An existing downstream regression assertion checks that an empty-result initialization query includes WHERE (0 = 1) rather than reading the entire cache.

This report is based on source inspection; downstream tests were not rerun for this report.

Related issue

#506 discusses zero/one-argument support in the public query API. This report specifically concerns SQL compilation and full-table fallback in the persistence adapter.

Linguagem predominante
TypeScript
Estrelas
3.9k
Forks
268
Merge médio
1d 1h
PRs com merge (30d)
212

Preparar o ambiente

Primeiros passos

  1. Leia a issue inteira e depois o guia de contribuição do projeto.
  2. Comente na issue dizendo que vai assumir — evita que duas pessoas façam o mesmo trabalho.
  3. Faça um fork do repositório e trabalhe em uma branch.
  4. Abra um pull request que referencie o número da issue.

Mais de TanStack/db

Todas as issues de TanStack/db

Issues semelhantes

Mais issues de TypeScript

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.